From b42676d867392a331e7f5f7a22efe0694f488df1 Mon Sep 17 00:00:00 2001 From: Darshan Date: Sat, 4 Oct 2025 12:01:32 +0530 Subject: [PATCH 1/3] fix: nullable not shown in datetime column type. --- src/lib/elements/forms/inputDateTime.svelte | 35 ++++++++++--------- .../table-[table]/columns/datetime.svelte | 1 + 2 files changed, 19 insertions(+), 17 deletions(-) diff --git a/src/lib/elements/forms/inputDateTime.svelte b/src/lib/elements/forms/inputDateTime.svelte index 11bd78fd8..08d5cfdd7 100644 --- a/src/lib/elements/forms/inputDateTime.svelte +++ b/src/lib/elements/forms/inputDateTime.svelte @@ -4,7 +4,7 @@ export let id: string; export let label: string = ''; - export let value: string; + export let value: string | null; export let required = false; export let nullable = false; export let disabled = false; @@ -17,6 +17,7 @@ let error: string; let element: HTMLInputElement; + let previousValue: string | null = null; onMount(() => { if (element && autofocus) { @@ -24,14 +25,16 @@ } }); - let prevValue = ''; function handleNullChange(e: CustomEvent) { const isNull = e.detail; + if (isNull) { - prevValue = value; + if (value) { + previousValue = value; + } value = null; } else { - value = prevValue; + value = previousValue; } } @@ -39,9 +42,7 @@ error = null; } - function onChange(event: CustomEvent) { - value = (event.target as HTMLInputElement).value; - } + $: isValueNull = value === null; @@ -51,20 +52,20 @@ {disabled} {readonly} {required} - {value} + bind:value {step} {type} helper={error} {leadingIcon} - on:change={onChange} autocomplete={autocomplete ? 'on' : 'off'}> - {#if nullable} - - {/if} + + {#if nullable} + + {/if} + diff --git a/src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/columns/datetime.svelte b/src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/columns/datetime.svelte index c1c3cbeae..827d77798 100644 --- a/src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/columns/datetime.svelte +++ b/src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/columns/datetime.svelte @@ -68,6 +68,7 @@ array: false, ...data }); + $: listen(data); $: handleDefaultState($required || $array); From b13fac8880486c6a74f3fd7284d1ebcb8938f716 Mon Sep 17 00:00:00 2001 From: Darshan Date: Sat, 4 Oct 2025 12:12:06 +0530 Subject: [PATCH 2/3] address rabbit's comment. --- src/lib/elements/forms/inputDateTime.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/elements/forms/inputDateTime.svelte b/src/lib/elements/forms/inputDateTime.svelte index 08d5cfdd7..6a904cd53 100644 --- a/src/lib/elements/forms/inputDateTime.svelte +++ b/src/lib/elements/forms/inputDateTime.svelte @@ -29,7 +29,7 @@ const isNull = e.detail; if (isNull) { - if (value) { + if (value !== null) { previousValue = value; } value = null; From 59f5a2b79e79739833d52dc4a6a767f877167bbf Mon Sep 17 00:00:00 2001 From: Darshan Date: Sat, 4 Oct 2025 12:17:12 +0530 Subject: [PATCH 3/3] fix: style. --- .../database-[database]/table-[table]/spreadsheet.svelte | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte b/src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte index 582d7a894..6923ba7e7 100644 --- a/src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte +++ b/src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte @@ -1217,6 +1217,10 @@ padding-inline: 8px !important; } + & :global(.input:has([type^='date'])) { + padding: 12px !important; + } + & :global(.input:focus-within) { top: 0 !important; }