From d9217687e74c7467574e006d88e4db2430a391f8 Mon Sep 17 00:00:00 2001 From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com> Date: Thu, 11 Sep 2025 12:44:37 +0530 Subject: [PATCH 1/3] 4xx codes use the orange warning badge, and 5xx stay red error --- .../function-[function]/executions/sheet.svelte | 10 ++++++---- .../function-[function]/executions/table.svelte | 10 ++++++---- .../sites/site-[site]/logs/sheet.svelte | 6 ++++-- .../sites/site-[site]/logs/table.svelte | 6 +++++- 4 files changed, 21 insertions(+), 11 deletions(-) diff --git a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/executions/sheet.svelte b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/executions/sheet.svelte index e31caff20..328fb80da 100644 --- a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/executions/sheet.svelte +++ b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/executions/sheet.svelte @@ -98,11 +98,13 @@ = 400 + type={selectedLog?.responseStatusCode >= 500 ? 'error' - : selectedLog.responseStatusCode === 0 - ? undefined - : 'success'} /> + : selectedLog.responseStatusCode >= 400 + ? 'warning' + : selectedLog.responseStatusCode === 0 + ? undefined + : 'success'} /> diff --git a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/executions/table.svelte b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/executions/table.svelte index 71e45d8be..d439e4037 100644 --- a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/executions/table.svelte +++ b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/executions/table.svelte @@ -96,11 +96,13 @@ {:else if column.id === 'responseStatusCode'} = 400 + type={log.responseStatusCode >= 500 ? 'error' - : log.responseStatusCode === 0 - ? undefined - : 'success'} + : log.responseStatusCode >= 400 + ? 'warning' + : log.responseStatusCode === 0 + ? undefined + : 'success'} content={log.responseStatusCode.toString()} /> {:else if column.id === 'requestMethod'} diff --git a/src/routes/(console)/project-[region]-[project]/sites/site-[site]/logs/sheet.svelte b/src/routes/(console)/project-[region]-[project]/sites/site-[site]/logs/sheet.svelte index 184406e24..1263905eb 100644 --- a/src/routes/(console)/project-[region]-[project]/sites/site-[site]/logs/sheet.svelte +++ b/src/routes/(console)/project-[region]-[project]/sites/site-[site]/logs/sheet.svelte @@ -99,9 +99,11 @@ = 400 + type={selectedLog?.responseStatusCode >= 500 ? 'error' - : 'success'} /> + : selectedLog.responseStatusCode >= 400 + ? 'warning' + : 'success'} /> diff --git a/src/routes/(console)/project-[region]-[project]/sites/site-[site]/logs/table.svelte b/src/routes/(console)/project-[region]-[project]/sites/site-[site]/logs/table.svelte index 37afff287..fce977900 100644 --- a/src/routes/(console)/project-[region]-[project]/sites/site-[site]/logs/table.svelte +++ b/src/routes/(console)/project-[region]-[project]/sites/site-[site]/logs/table.svelte @@ -87,7 +87,11 @@
= 400 ? 'error' : 'success'} + type={log.responseStatusCode >= 500 + ? 'error' + : log.responseStatusCode >= 400 + ? 'warning' + : 'success'} content={log.responseStatusCode.toString()} />
{:else if column.id === 'requestPath'} From 45ac73acc7b30a024c6e152a02d317f90431ad38 Mon Sep 17 00:00:00 2001 From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com> Date: Mon, 15 Sep 2025 11:04:51 +0530 Subject: [PATCH 2/3] fix: created a helper function --- src/lib/helpers/httpStatus.ts | 23 +++++++++++++++++++ .../executions/sheet.svelte | 11 ++++----- .../executions/table.svelte | 9 ++------ .../sites/site-[site]/logs/sheet.svelte | 9 ++++---- .../sites/site-[site]/logs/table.svelte | 7 ++---- 5 files changed, 35 insertions(+), 24 deletions(-) create mode 100644 src/lib/helpers/httpStatus.ts diff --git a/src/lib/helpers/httpStatus.ts b/src/lib/helpers/httpStatus.ts new file mode 100644 index 000000000..4c5df2c71 --- /dev/null +++ b/src/lib/helpers/httpStatus.ts @@ -0,0 +1,23 @@ +/** + * determines the badge color based on HTTP status code + * + * @param statusCode + * @returns badge coklor + */ +export function getBadgeTypeFromStatusCode( + statusCode: number +): 'error' | 'warning' | 'success' | undefined { + if (statusCode >= 500) { + return 'error'; + } + + if (statusCode >= 400) { + return 'warning'; + } + + if (statusCode === 0) { + return undefined; + } + + return 'success'; +} diff --git a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/executions/sheet.svelte b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/executions/sheet.svelte index 328fb80da..af47ba07c 100644 --- a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/executions/sheet.svelte +++ b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/executions/sheet.svelte @@ -17,6 +17,7 @@ } from '@appwrite.io/pink-svelte'; import { timeFromNow, toLocaleDateTime } from '$lib/helpers/date'; import { capitalize } from '$lib/helpers/string'; + import { getBadgeTypeFromStatusCode } from '$lib/helpers/httpStatus'; import { Copy } from '$lib/components'; import { logStatusConverter } from './store'; import { LogsRequest, LogsResponse } from '$lib/components/logs'; @@ -98,13 +99,9 @@ = 500 - ? 'error' - : selectedLog.responseStatusCode >= 400 - ? 'warning' - : selectedLog.responseStatusCode === 0 - ? undefined - : 'success'} /> + type={getBadgeTypeFromStatusCode( + selectedLog.responseStatusCode + )} />
diff --git a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/executions/table.svelte b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/executions/table.svelte index d439e4037..bc4573006 100644 --- a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/executions/table.svelte +++ b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/executions/table.svelte @@ -14,6 +14,7 @@ import Sheet from './sheet.svelte'; import { capitalize } from '$lib/helpers/string'; import { calculateTime } from '$lib/helpers/timeConversion'; + import { getBadgeTypeFromStatusCode } from '$lib/helpers/httpStatus'; import { logStatusConverter } from './store'; import DualTimeView from '$lib/components/dualTimeView.svelte'; import { func } from '../store'; @@ -96,13 +97,7 @@ {:else if column.id === 'responseStatusCode'} = 500 - ? 'error' - : log.responseStatusCode >= 400 - ? 'warning' - : log.responseStatusCode === 0 - ? undefined - : 'success'} + type={getBadgeTypeFromStatusCode(log.responseStatusCode)} content={log.responseStatusCode.toString()} /> {:else if column.id === 'requestMethod'} diff --git a/src/routes/(console)/project-[region]-[project]/sites/site-[site]/logs/sheet.svelte b/src/routes/(console)/project-[region]-[project]/sites/site-[site]/logs/sheet.svelte index 1263905eb..a0c6f9b81 100644 --- a/src/routes/(console)/project-[region]-[project]/sites/site-[site]/logs/sheet.svelte +++ b/src/routes/(console)/project-[region]-[project]/sites/site-[site]/logs/sheet.svelte @@ -15,6 +15,7 @@ } from '@appwrite.io/pink-svelte'; import { timeFromNow } from '$lib/helpers/date'; import { capitalize } from '$lib/helpers/string'; + import { getBadgeTypeFromStatusCode } from '$lib/helpers/httpStatus'; import { Copy } from '$lib/components'; import { LogsRequest, LogsResponse } from '$lib/components/logs'; import { site } from '../store'; @@ -99,11 +100,9 @@ = 500 - ? 'error' - : selectedLog.responseStatusCode >= 400 - ? 'warning' - : 'success'} /> + type={getBadgeTypeFromStatusCode( + selectedLog.responseStatusCode + )} /> diff --git a/src/routes/(console)/project-[region]-[project]/sites/site-[site]/logs/table.svelte b/src/routes/(console)/project-[region]-[project]/sites/site-[site]/logs/table.svelte index fce977900..1d5011dd2 100644 --- a/src/routes/(console)/project-[region]-[project]/sites/site-[site]/logs/table.svelte +++ b/src/routes/(console)/project-[region]-[project]/sites/site-[site]/logs/table.svelte @@ -12,6 +12,7 @@ import { invalidate } from '$app/navigation'; import { Dependencies } from '$lib/constants'; import { calculateTime } from '$lib/helpers/timeConversion'; + import { getBadgeTypeFromStatusCode } from '$lib/helpers/httpStatus'; import { Button } from '$lib/elements/forms'; export let columns: Column[]; @@ -87,11 +88,7 @@
= 500 - ? 'error' - : log.responseStatusCode >= 400 - ? 'warning' - : 'success'} + type={getBadgeTypeFromStatusCode(log.responseStatusCode)} content={log.responseStatusCode.toString()} />
{:else if column.id === 'requestPath'} From ae60d14968b01c7b7642ad764e6fc97a0422a275 Mon Sep 17 00:00:00 2001 From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com> Date: Mon, 15 Sep 2025 11:06:13 +0530 Subject: [PATCH 3/3] fix: typo --- src/lib/helpers/httpStatus.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/helpers/httpStatus.ts b/src/lib/helpers/httpStatus.ts index 4c5df2c71..fee77802a 100644 --- a/src/lib/helpers/httpStatus.ts +++ b/src/lib/helpers/httpStatus.ts @@ -2,7 +2,7 @@ * determines the badge color based on HTTP status code * * @param statusCode - * @returns badge coklor + * @returns badge color */ export function getBadgeTypeFromStatusCode( statusCode: number