From b433fbf0420803ec83efa327a622532839c5f4fc Mon Sep 17 00:00:00 2001 From: Steven Nguyen Date: Thu, 8 Feb 2024 16:00:21 -0800 Subject: [PATCH 1/2] Fix unresponsive edit message A bug in the handling of custom data caused an error that prevented the wizard from opening. --- .../project-[project]/messaging/createMessageDropdown.svelte | 3 ++- .../messaging/message-[message]/+page.svelte | 4 +++- .../project-[project]/messaging/wizard/pushFormList.svelte | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/routes/console/project-[project]/messaging/createMessageDropdown.svelte b/src/routes/console/project-[project]/messaging/createMessageDropdown.svelte index db2850cca..f35e08683 100644 --- a/src/routes/console/project-[project]/messaging/createMessageDropdown.svelte +++ b/src/routes/console/project-[project]/messaging/createMessageDropdown.svelte @@ -56,7 +56,8 @@ $messageParams[$providerType] = { ...common, title: '', - body: '' + body: '', + data: [['', '']] }; break; } diff --git a/src/routes/console/project-[project]/messaging/message-[message]/+page.svelte b/src/routes/console/project-[project]/messaging/message-[message]/+page.svelte index 9a094f8c0..5e680c334 100644 --- a/src/routes/console/project-[project]/messaging/message-[message]/+page.svelte +++ b/src/routes/console/project-[project]/messaging/message-[message]/+page.svelte @@ -84,7 +84,9 @@ Object.entries(data['data'] ?? {}).forEach(([key, value]) => { dataEntries.push([key, value.toString()]); }); - $messageParams[$providerType]['data'] = dataEntries || [['', '']]; + $messageParams[$providerType]['data'] = dataEntries.length + ? dataEntries + : [['', '']]; } break; } diff --git a/src/routes/console/project-[project]/messaging/wizard/pushFormList.svelte b/src/routes/console/project-[project]/messaging/wizard/pushFormList.svelte index 7b9b37982..b15e65d15 100644 --- a/src/routes/console/project-[project]/messaging/wizard/pushFormList.svelte +++ b/src/routes/console/project-[project]/messaging/wizard/pushFormList.svelte @@ -54,7 +54,7 @@ let customData: [string, string][] = []; onMount(() => { - $messageParams[MessagingProviderType.Push].data = customData || [['', '']]; + customData = $messageParams[MessagingProviderType.Push].data; }); async function sendTestMessage() { From 44df59c758ddf47165f5772e00ed4a55aa63d527 Mon Sep 17 00:00:00 2001 From: Steven Nguyen Date: Thu, 8 Feb 2024 16:22:09 -0800 Subject: [PATCH 2/2] Fix alignment of the push phone preview --- .../messaging/message-[message]/pushPreview.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/routes/console/project-[project]/messaging/message-[message]/pushPreview.svelte b/src/routes/console/project-[project]/messaging/message-[message]/pushPreview.svelte index 956bdc8de..eefb59c0a 100644 --- a/src/routes/console/project-[project]/messaging/message-[message]/pushPreview.svelte +++ b/src/routes/console/project-[project]/messaging/message-[message]/pushPreview.svelte @@ -11,7 +11,7 @@
Preview -
+