From 7353396c38939ecaa5f9b3f6c357300c6ef2e5fe Mon Sep 17 00:00:00 2001
From: Darshan <itznotabug@gmail.com>
Date: Mon, 2 Jun 2025 20:03:13 +0530
Subject: [PATCH] fix: priority checks.

---
 .../domains/domain-[domain]/createRecordModal.svelte  |  3 ++-
 .../domains/domain-[domain]/table.svelte              | 11 ++++++++++-
 .../domains/domain-[domain]/updateRecordModal.svelte  |  6 ++----
 3 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/src/routes/(console)/organization-[organization]/domains/domain-[domain]/createRecordModal.svelte b/src/routes/(console)/organization-[organization]/domains/domain-[domain]/createRecordModal.svelte
index 14f0adc61..1ddcdb4e6 100644
--- a/src/routes/(console)/organization-[organization]/domains/domain-[domain]/createRecordModal.svelte
+++ b/src/routes/(console)/organization-[organization]/domains/domain-[domain]/createRecordModal.svelte
@@ -17,6 +17,7 @@
     import { invalidate } from '$app/navigation';
     import type { RecordType } from '$lib/stores/domains';
     import { createRecord } from '$lib/helpers/domains';
+    import { showPriority } from './table.svelte';
 
     export let show = false;
 
@@ -110,7 +111,7 @@
                     </span>
                 </Tooltip>
             </InputNumber>
-            {#if type === 'MX'}
+            {#if showPriority(type)}
                 <InputNumber
                     id="priority"
                     label="Priority"
diff --git a/src/routes/(console)/organization-[organization]/domains/domain-[domain]/table.svelte b/src/routes/(console)/organization-[organization]/domains/domain-[domain]/table.svelte
index f25e433d7..f7f6d76ee 100644
--- a/src/routes/(console)/organization-[organization]/domains/domain-[domain]/table.svelte
+++ b/src/routes/(console)/organization-[organization]/domains/domain-[domain]/table.svelte
@@ -1,3 +1,12 @@
+<script lang="ts" context="module">
+    import type { RecordType } from '$lib/stores/domains';
+
+    export function showPriority(record: Models.DnsRecord | RecordType): boolean {
+        const type = typeof record === 'string' ? record : record.type;
+        return type.toLowerCase() === 'mx' || type.toLowerCase() === 'srv';
+    }
+</script>
+
 <script lang="ts">
     import { PaginationWithLimit } from '$lib/components';
     import {
@@ -86,7 +95,7 @@
                             </Typography.Text>
                         {:else if column.id === 'priority'}
                             <Typography.Text>
-                                {record?.priority || '-'}
+                                {showPriority(record) ? record?.priority || '-' : '-'}
                             </Typography.Text>
                         {:else if column.id === 'comment'}
                             <Typography.Text truncate>
diff --git a/src/routes/(console)/organization-[organization]/domains/domain-[domain]/updateRecordModal.svelte b/src/routes/(console)/organization-[organization]/domains/domain-[domain]/updateRecordModal.svelte
index c22d18a00..c8d4d1f49 100644
--- a/src/routes/(console)/organization-[organization]/domains/domain-[domain]/updateRecordModal.svelte
+++ b/src/routes/(console)/organization-[organization]/domains/domain-[domain]/updateRecordModal.svelte
@@ -20,6 +20,7 @@
     import type { Models } from '@appwrite.io/console';
     import type { RecordType } from '$lib/stores/domains';
     import { updateRecord } from '$lib/helpers/domains';
+    import { showPriority } from './table.svelte';
 
     export let show = false;
     export let selectedRecord: Models.DnsRecord;
@@ -63,9 +64,6 @@
 
     $: isDisabled = !symmetricDifference(Object.values(record), Object.values(selectedRecord))
         ?.length;
-
-    $: showPriority =
-        record.name.toLocaleLowerCase() === 'mx' || record.name.toLocaleLowerCase() === 'srv';
 </script>
 
 <Modal title="Update DNS record" bind:show bind:error onSubmit={handleSubmit}>
@@ -104,7 +102,7 @@
                     </span>
                 </Tooltip>
             </InputNumber>
-            {#if showPriority}
+            {#if showPriority(record)}
                 <InputNumber
                     id="priority"
                     label="Priority"