From 2cad4301f2c30df01eb831e761a2e444bebf6f75 Mon Sep 17 00:00:00 2001 From: Damodar Lohani Date: Wed, 3 Sep 2025 04:35:18 +0000 Subject: [PATCH 1/4] Fix: remove hacks on determining service limits --- src/lib/stores/billing.ts | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/src/lib/stores/billing.ts b/src/lib/stores/billing.ts index 2a88fa83a..7a6e8a2e0 100644 --- a/src/lib/stores/billing.ts +++ b/src/lib/stores/billing.ts @@ -154,20 +154,18 @@ export type PlanServices = export function getServiceLimit(serviceId: PlanServices, tier: Tier = null, plan?: Plan): number { if (!isCloud) return 0; if (!serviceId) return 0; - const info = get(plansInfo); - if (!info) return 0; - plan ??= info.get(tier ?? get(organization)?.billingPlan); - // members are no longer a variable on plan itself! - // the correct info for members/seats, resides in `addons`. - // plan > addons > seats/others + + plan ??= get(currentPlan); + + if (tier) { + const info = get(plansInfo); + if (!info) return 0; + plan ??= info.get(tier); + } + if (serviceId === 'members') { - // pro and scale plans have unlimited seats (per-project NEW pricing model) - const currentTier = tier ?? get(organization)?.billingPlan; - if (currentTier === BillingPlan.PRO || currentTier === BillingPlan.SCALE) { - return Infinity; // unlimited seats for Pro and Scale plans - } - // Free plan still has 1 member limit - return (plan?.['addons']['seats'] || [])['limit'] ?? 1; + if (!(plan.addons.seats?.supported ?? false)) return Infinity; + return plan.addons.seats?.limit ?? 1; } return plan?.[serviceId] ?? 0; From 2be481f606e70b516a6fab63a45a4e0d1ae6000d Mon Sep 17 00:00:00 2001 From: Damodar Lohani Date: Wed, 3 Sep 2025 04:48:42 +0000 Subject: [PATCH 2/4] improve fix: disable project creation --- src/lib/stores/billing.ts | 10 ++++++++-- .../organization-[organization]/+page.svelte | 11 ++++++++--- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/src/lib/stores/billing.ts b/src/lib/stores/billing.ts index 7a6e8a2e0..9438cbd19 100644 --- a/src/lib/stores/billing.ts +++ b/src/lib/stores/billing.ts @@ -138,6 +138,7 @@ export type PlanServices = | 'logs' | 'memberAddon' | 'members' + | 'projects' | 'platforms' | 'realtime' | 'realtimeAddon' @@ -156,7 +157,7 @@ export function getServiceLimit(serviceId: PlanServices, tier: Tier = null, plan if (!serviceId) return 0; plan ??= get(currentPlan); - + if (tier) { const info = get(plansInfo); if (!info) return 0; @@ -164,10 +165,15 @@ export function getServiceLimit(serviceId: PlanServices, tier: Tier = null, plan } if (serviceId === 'members') { - if (!(plan.addons.seats?.supported ?? false)) return Infinity; + if (!plan.addons.seats) return Infinity; return plan.addons.seats?.limit ?? 1; } + if (serviceId === 'projects') { + if (!plan.addons.seats) return Infinity; + return plan.addons.projects?.limit ?? 1; + } + return plan?.[serviceId] ?? 0; } diff --git a/src/routes/(console)/organization-[organization]/+page.svelte b/src/routes/(console)/organization-[organization]/+page.svelte index 27af7cbff..9e22a5fa3 100644 --- a/src/routes/(console)/organization-[organization]/+page.svelte +++ b/src/routes/(console)/organization-[organization]/+page.svelte @@ -18,7 +18,7 @@ } from '$lib/components'; import { trackEvent, Click } from '$lib/actions/analytics'; import { type Models } from '@appwrite.io/console'; - import { readOnly, upgradeURL } from '$lib/stores/billing'; + import { getServiceLimit, readOnly, upgradeURL } from '$lib/stores/billing'; import { onMount, type ComponentType } from 'svelte'; import { canWriteProjects } from '$lib/stores/roles'; import { checkPricingRefAndRedirect } from '$lib/helpers/pricingRedirect'; @@ -79,6 +79,11 @@ } } + $: projectCreationDisabled = + (isCloud && getServiceLimit('projects') <= data.allProjectsCount) || + ($readOnly && !GRACE_PERIOD_OVERRIDE) || + !$canWriteProjects; + $: $registerCommands([ { label: 'Create project', @@ -86,7 +91,7 @@ showCreate = true; }, keys: ['c'], - disabled: ($readOnly && !GRACE_PERIOD_OVERRIDE) || !$canWriteProjects, + disabled: projectCreationDisabled, group: 'projects', icon: IconPlus } @@ -125,7 +130,7 @@ From 8c6e809b6ddbdaec9f0cd6ba05ce0eb695848f12 Mon Sep 17 00:00:00 2001 From: Damodar Lohani Date: Wed, 3 Sep 2025 05:33:43 +0000 Subject: [PATCH 3/4] fix typo --- src/lib/stores/billing.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/stores/billing.ts b/src/lib/stores/billing.ts index 9438cbd19..cb7515024 100644 --- a/src/lib/stores/billing.ts +++ b/src/lib/stores/billing.ts @@ -165,12 +165,12 @@ export function getServiceLimit(serviceId: PlanServices, tier: Tier = null, plan } if (serviceId === 'members') { - if (!plan.addons.seats) return Infinity; + if (!plan.addons?.seats) return Infinity; return plan.addons.seats?.limit ?? 1; } if (serviceId === 'projects') { - if (!plan.addons.seats) return Infinity; + if (!plan.addons?.projects) return Infinity; return plan.addons.projects?.limit ?? 1; } From 08500bb187e58e6a8f4d60f5ebfb30fd631545e2 Mon Sep 17 00:00:00 2001 From: Damodar Lohani Date: Wed, 3 Sep 2025 05:57:57 +0000 Subject: [PATCH 4/4] fix plan check --- src/lib/stores/billing.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/stores/billing.ts b/src/lib/stores/billing.ts index cb7515024..3564a1c27 100644 --- a/src/lib/stores/billing.ts +++ b/src/lib/stores/billing.ts @@ -165,12 +165,12 @@ export function getServiceLimit(serviceId: PlanServices, tier: Tier = null, plan } if (serviceId === 'members') { - if (!plan.addons?.seats) return Infinity; + if (!plan?.addons?.seats) return Infinity; return plan.addons.seats?.limit ?? 1; } if (serviceId === 'projects') { - if (!plan.addons?.projects) return Infinity; + if (!plan?.addons?.projects) return Infinity; return plan.addons.projects?.limit ?? 1; }