From a297513115ef8758d1f7e3936298aae0805e4f26 Mon Sep 17 00:00:00 2001 From: Arman Date: Tue, 11 Feb 2025 15:38:43 +0100 Subject: [PATCH 1/8] fix: add variables --- .../sites/create-site/manual/+page.svelte | 17 ++++++++--------- .../template-[template]/+page.svelte | 19 +++++++++---------- 2 files changed, 17 insertions(+), 19 deletions(-) diff --git a/src/routes/(console)/project-[project]/sites/create-site/manual/+page.svelte b/src/routes/(console)/project-[project]/sites/create-site/manual/+page.svelte index 2e2e3dafb..993872a45 100644 --- a/src/routes/(console)/project-[project]/sites/create-site/manual/+page.svelte +++ b/src/routes/(console)/project-[project]/sites/create-site/manual/+page.svelte @@ -104,16 +104,15 @@ }); //Add variables - await Promise.all( - Object.keys(variables).map(async (key) => { - await sdk.forProject.sites.createVariable( - site.$id, - key, - variables[key].value, - variables[key].secret - ); - }) + const promises = variables.map((variable) => + sdk.forProject.sites.createVariable( + site.$id, + variable.key, + variable.value, + variable?.secret ?? false + ) ); + await Promise.all(promises); const { deployments } = await sdk.forProject.sites.listDeployments(site.$id, [ Query.limit(1) diff --git a/src/routes/(console)/project-[project]/sites/create-site/templates/template-[template]/+page.svelte b/src/routes/(console)/project-[project]/sites/create-site/templates/template-[template]/+page.svelte index 8a0d806a9..c303c65ca 100644 --- a/src/routes/(console)/project-[project]/sites/create-site/templates/template-[template]/+page.svelte +++ b/src/routes/(console)/project-[project]/sites/create-site/templates/template-[template]/+page.svelte @@ -3,7 +3,7 @@ import { base } from '$app/paths'; import { page } from '$app/stores'; import { Submit, trackError, trackEvent } from '$lib/actions/analytics'; - import { Card, SvgIcon } from '$lib/components'; + import { Card } from '$lib/components'; import { Button, Form } from '$lib/elements/forms'; import { Wizard } from '$lib/layout'; import { addNotification } from '$lib/stores/notifications'; @@ -153,16 +153,15 @@ }); //Add variables - await Promise.all( - Object.keys(variables).map(async (key) => { - await sdk.forProject.sites.createVariable( - site.$id, - key, - variables[key].value, - variables[key].secret - ); - }) + const promises = variables.map((variable) => + sdk.forProject.sites.createVariable( + site.$id, + variable.key, + variable.value, + variable?.secret ?? false + ) ); + await Promise.all(promises); const { deployments } = await sdk.forProject.sites.listDeployments(site.$id, [ Query.limit(1) From bc7dcebddb9b3ff66181eede1cee4520f154ac86 Mon Sep 17 00:00:00 2001 From: Arman Date: Tue, 11 Feb 2025 16:21:43 +0100 Subject: [PATCH 2/8] feat: create variable --- .../project-[project]/createVariable.svelte | 11 +- .../configuration.svelte | 19 +- .../sites/create-site/createVariable.svelte | 74 ++++++ .../sites/create-site/manual/+page.svelte | 2 +- .../create-site/manual/configuration.svelte | 219 ------------------ .../repository-[repository]/+page.svelte | 5 +- 6 files changed, 96 insertions(+), 234 deletions(-) rename src/routes/(console)/project-[project]/sites/create-site/{repositories/repository-[repository] => }/configuration.svelte (94%) create mode 100644 src/routes/(console)/project-[project]/sites/create-site/createVariable.svelte delete mode 100644 src/routes/(console)/project-[project]/sites/create-site/manual/configuration.svelte diff --git a/src/routes/(console)/project-[project]/createVariable.svelte b/src/routes/(console)/project-[project]/createVariable.svelte index 27568f2e3..8e4373f22 100644 --- a/src/routes/(console)/project-[project]/createVariable.svelte +++ b/src/routes/(console)/project-[project]/createVariable.svelte @@ -1,5 +1,5 @@ + + + + Set the environment variables or secret that will be passed to your site. Global variables + can be set in project settings. + + + + + + + + + + + diff --git a/src/routes/(console)/project-[project]/sites/create-site/manual/+page.svelte b/src/routes/(console)/project-[project]/sites/create-site/manual/+page.svelte index 993872a45..014951811 100644 --- a/src/routes/(console)/project-[project]/sites/create-site/manual/+page.svelte +++ b/src/routes/(console)/project-[project]/sites/create-site/manual/+page.svelte @@ -11,12 +11,12 @@ import { IconInfo } from '@appwrite.io/pink-icons-svelte'; import { writable } from 'svelte/store'; import Details from '../details.svelte'; - import Configuration from './configuration.svelte'; import Aside from './aside.svelte'; import { BuildRuntime, Framework, ID, Query } from '@appwrite.io/console'; import type { Models } from '@appwrite.io/console'; import { processFileList } from '$lib/helpers/files'; import { createTarGzip } from 'nanotar'; + import Configuration from '../configuration.svelte'; export let data; let showExitModal = false; diff --git a/src/routes/(console)/project-[project]/sites/create-site/manual/configuration.svelte b/src/routes/(console)/project-[project]/sites/create-site/manual/configuration.svelte deleted file mode 100644 index 1716552f8..000000000 --- a/src/routes/(console)/project-[project]/sites/create-site/manual/configuration.svelte +++ /dev/null @@ -1,219 +0,0 @@ - - -
- - ({ - value: framework.key, - label: framework.name - }))} - on:change={() => { - selectedFramework = frameworks.find((framework) => framework.key === frameworkId); - }} /> - - - - - Set up how your project is built and where the output files are stored. - - - - - - - - - - - - - - - - - - - Set up environment variables to securely manage keys and settings for your - project. - - {#if variables?.length} - - - Key - Value - - - {#each variables as variable} - - {variable.key} - - -
- {#if variable.secret} - - {:else} - - {/if} -
-
- -
- - - - - { - showEditorModal = true; - }}> - Edit - - {#if !variable?.secret} - { - currentVariable = variable; - showSecretModal = true; - }}> - Secret - - {/if} - { - showImportModal = true; - }}> - Delete - - - - -
-
-
- {/each} -
- {:else} - Create variables to get started - {/if} -
- - - - - - - -
-
-
-
-
- -{#if showEditorModal} - -{/if} - -{#if showSecretModal} - -{/if} - -{#if showImportModal} - -{/if} diff --git a/src/routes/(console)/project-[project]/sites/create-site/repositories/repository-[repository]/+page.svelte b/src/routes/(console)/project-[project]/sites/create-site/repositories/repository-[repository]/+page.svelte index a08a2ea9e..de9436cc9 100644 --- a/src/routes/(console)/project-[project]/sites/create-site/repositories/repository-[repository]/+page.svelte +++ b/src/routes/(console)/project-[project]/sites/create-site/repositories/repository-[repository]/+page.svelte @@ -14,11 +14,11 @@ import { writable } from 'svelte/store'; import Details from '../../details.svelte'; import ProductionBranch from '../../productionBranch.svelte'; - import Configuration from './configuration.svelte'; import Aside from '../../aside.svelte'; import { BuildRuntime, Framework, ID, Query } from '@appwrite.io/console'; import type { Models } from '@appwrite.io/console'; import { onMount } from 'svelte'; + import Configuration from '../../configuration.svelte'; export let data; let showExitModal = false; @@ -103,7 +103,6 @@ const { deployments } = await sdk.forProject.sites.listDeployments(site.$id, [ Query.limit(1) ]); - console.log(deployments); const deployment = deployments[0]; await goto( `${base}/project-${$page.params.project}/sites/create-site/deploying?site=${site.$id}&deployment=${deployment.$id}` @@ -116,8 +115,6 @@ trackError(e, Submit.SiteCreate); } } - - $: console.log(variables); From 9f54caa64305a1c0658f102def72faca82033da4 Mon Sep 17 00:00:00 2001 From: Arman Date: Tue, 11 Feb 2025 16:39:09 +0100 Subject: [PATCH 3/8] fix: double scroll wizard on mobile --- src/lib/layout/wizard.svelte | 4 ++++ .../repositories/repository-[repository]/+page.svelte | 5 +---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/lib/layout/wizard.svelte b/src/lib/layout/wizard.svelte index 589fe9a6f..8074d4792 100644 --- a/src/lib/layout/wizard.svelte +++ b/src/lib/layout/wizard.svelte @@ -117,4 +117,8 @@ max-height: 100dvh; overflow-y: auto; } + + :globla(html) { + overflow-y: hidden; + } diff --git a/src/routes/(console)/project-[project]/sites/create-site/repositories/repository-[repository]/+page.svelte b/src/routes/(console)/project-[project]/sites/create-site/repositories/repository-[repository]/+page.svelte index de9436cc9..f89fe548c 100644 --- a/src/routes/(console)/project-[project]/sites/create-site/repositories/repository-[repository]/+page.svelte +++ b/src/routes/(console)/project-[project]/sites/create-site/repositories/repository-[repository]/+page.svelte @@ -184,11 +184,8 @@ - +