From 79b7f90c210d9559c9c3b1f72771ce182d634d13 Mon Sep 17 00:00:00 2001 From: Torsten Dittmann Date: Mon, 7 Jul 2025 16:23:47 +0400 Subject: [PATCH 1/2] fix: checkbox event propagation in permissions tables --- src/lib/components/permissions/team.svelte | 12 ++++++---- src/lib/components/permissions/user.svelte | 28 +++++++++++++++------- 2 files changed, 26 insertions(+), 14 deletions(-) diff --git a/src/lib/components/permissions/team.svelte b/src/lib/components/permissions/team.svelte index 23f3ae0ea..5774857e9 100644 --- a/src/lib/components/permissions/team.svelte +++ b/src/lib/components/permissions/team.svelte @@ -88,11 +88,13 @@ {@const exists = $groups.has(role)} onSelection(role)} disabled={exists}> - +
+ +
diff --git a/src/lib/components/permissions/user.svelte b/src/lib/components/permissions/user.svelte index 8c30e7968..861149134 100644 --- a/src/lib/components/permissions/user.svelte +++ b/src/lib/components/permissions/user.svelte @@ -53,12 +53,20 @@ isLoading = false; } - function onSelection(role: string) { + function onSelection(role: string, value: boolean | null = null) { const checked = selected.has(role); - if (checked) { - selected.delete(role); + if (value === null) { + if (checked) { + selected.delete(role); + } else { + selected.add(role); + } } else { - selected.add(role); + if (value) { + selected.add(role); + } else { + selected.delete(role); + } } selected = selected; @@ -90,11 +98,13 @@ {@const exists = $groups.has(role)} onSelection(role)} disabled={exists}> - +
+ +
From 460d1229e06681ef4f4172644f060120c5e22f62 Mon Sep 17 00:00:00 2001 From: Torsten Dittmann Date: Mon, 7 Jul 2025 16:24:21 +0400 Subject: [PATCH 2/2] remove accidental change --- src/lib/components/permissions/user.svelte | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/lib/components/permissions/user.svelte b/src/lib/components/permissions/user.svelte index 861149134..c1242fc0c 100644 --- a/src/lib/components/permissions/user.svelte +++ b/src/lib/components/permissions/user.svelte @@ -53,20 +53,12 @@ isLoading = false; } - function onSelection(role: string, value: boolean | null = null) { + function onSelection(role: string) { const checked = selected.has(role); - if (value === null) { - if (checked) { - selected.delete(role); - } else { - selected.add(role); - } + if (checked) { + selected.delete(role); } else { - if (value) { - selected.add(role); - } else { - selected.delete(role); - } + selected.add(role); } selected = selected;