From 5b64a17cd46c0f2a60134b6bd12d0abdba970d39 Mon Sep 17 00:00:00 2001
From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com>
Date: Thu, 30 Oct 2025 18:09:48 +0530
Subject: [PATCH] addressed comments like duplicate component and use route id

---
 .../(modals)/deleteModal.svelte               |  2 +-
 .../function-[function]/delete.svelte         | 46 -------------------
 .../deployments/deleteDeploymentModal.svelte  |  2 +-
 3 files changed, 2 insertions(+), 48 deletions(-)
 delete mode 100644 src/routes/(console)/project-[region]-[project]/functions/function-[function]/delete.svelte

diff --git a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/(modals)/deleteModal.svelte b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/(modals)/deleteModal.svelte
index 57acdf677..e913d705b 100644
--- a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/(modals)/deleteModal.svelte
+++ b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/(modals)/deleteModal.svelte
@@ -21,7 +21,7 @@
                     functionId: selectedDeployment.resourceId,
                     deploymentId: selectedDeployment.$id
                 });
-            if (page.url.href.includes(`deployment-${selectedDeployment.$id}`)) {
+            if (page.route.id?.includes('deployment-[deployment]')) {
                 goto(
                     `${base}/project-${page.params.region}-${page.params.project}/functions/function-${page.params.function}/deployments`
                 );
diff --git a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/delete.svelte b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/delete.svelte
deleted file mode 100644
index 57acdf677..000000000
--- a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/delete.svelte
+++ /dev/null
@@ -1,46 +0,0 @@
-<script lang="ts">
-    import { goto, invalidate } from '$app/navigation';
-    import { base } from '$app/paths';
-    import { Submit, trackEvent, trackError } from '$lib/actions/analytics';
-    import Confirm from '$lib/components/confirm.svelte';
-    import { Dependencies } from '$lib/constants';
-    import { addNotification } from '$lib/stores/notifications';
-    import { sdk } from '$lib/stores/sdk';
-    import { page } from '$app/state';
-    import type { Models } from '@appwrite.io/console';
-
-    export let showDelete = false;
-    export let selectedDeployment: Models.Deployment = null;
-    let error: string;
-
-    async function handleSubmit() {
-        try {
-            await sdk
-                .forProject(page.params.region, page.params.project)
-                .functions.deleteDeployment({
-                    functionId: selectedDeployment.resourceId,
-                    deploymentId: selectedDeployment.$id
-                });
-            if (page.url.href.includes(`deployment-${selectedDeployment.$id}`)) {
-                goto(
-                    `${base}/project-${page.params.region}-${page.params.project}/functions/function-${page.params.function}/deployments`
-                );
-                return;
-            }
-            await invalidate(Dependencies.FUNCTION);
-            showDelete = false;
-            addNotification({
-                type: 'success',
-                message: `Deployment has been deleted`
-            });
-            trackEvent(Submit.DeploymentDelete);
-        } catch (e) {
-            error = e.message;
-            trackError(e, Submit.DeploymentDelete);
-        }
-    }
-</script>
-
-<Confirm onSubmit={handleSubmit} title="Delete deployment" bind:open={showDelete} bind:error>
-    Are you sure you want to delete this deployment?
-</Confirm>
diff --git a/src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/deleteDeploymentModal.svelte b/src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/deleteDeploymentModal.svelte
index 74a66080b..4d781eca8 100644
--- a/src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/deleteDeploymentModal.svelte
+++ b/src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/deleteDeploymentModal.svelte
@@ -22,7 +22,7 @@
                 siteId: selectedDeployment.resourceId,
                 deploymentId: selectedDeployment.$id
             });
-            if (page.url.href.includes(`deployment-${selectedDeployment.$id}`)) {
+            if (page.route.id?.includes('deployment-[deployment]')) {
                 goto(
                     `${base}/project-${page.params.region}-${page.params.project}/sites/site-${page.params.site}/deployments`
                 );