From e099c2b4563da62e87f9b0a2e8d9d2e04709208d Mon Sep 17 00:00:00 2001
From: Torsten Dittmann <torsten.dittmann@googlemail.com>
Date: Fri, 27 Sep 2024 15:53:41 +0200
Subject: [PATCH 1/2] fix: torsten review

---
 .../databases/database-[database]/backups/+page.svelte       | 5 +++--
 .../database-[database]/backups/containerHeader.svelte       | 3 +--
 .../databases/database-[database]/backups/policy.svelte      | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/routes/(console)/project-[project]/databases/database-[database]/backups/+page.svelte b/src/routes/(console)/project-[project]/databases/database-[database]/backups/+page.svelte
index 0414ba64a..b17e49eac 100644
--- a/src/routes/(console)/project-[project]/databases/database-[database]/backups/+page.svelte
+++ b/src/routes/(console)/project-[project]/databases/database-[database]/backups/+page.svelte
@@ -22,6 +22,7 @@
     import { onMount } from 'svelte';
     import { feedback } from '$lib/stores/feedback';
     import { cronExpression, type UserBackupPolicy } from '$lib/helpers/backups';
+    import { ID } from '@appwrite.io/console';
 
     let showCreatePolicy = false;
     let policyCreateError: string;
@@ -88,7 +89,7 @@
             cronExpression(policy);
 
             return sdk.forProject.backups.createPolicy(
-                policy.id,
+                ID.unique(),
                 ['databases'],
                 policy.retained,
                 policy.schedule,
@@ -153,7 +154,7 @@
             <div class="u-flex-vertical u-width-full-line">
                 <ContainerHeader
                     title="Backups"
-                    buttonText="Manual Backup"
+                    buttonText="Manual backup"
                     buttonEvent="create_backup"
                     buttonType="secondary"
                     buttonDisabled={isDisabled}
diff --git a/src/routes/(console)/project-[project]/databases/database-[database]/backups/containerHeader.svelte b/src/routes/(console)/project-[project]/databases/database-[database]/backups/containerHeader.svelte
index 2062f87ce..67c241f4a 100644
--- a/src/routes/(console)/project-[project]/databases/database-[database]/backups/containerHeader.svelte
+++ b/src/routes/(console)/project-[project]/databases/database-[database]/backups/containerHeader.svelte
@@ -21,10 +21,9 @@
         on:click={buttonMethod}
         disabled={buttonDisabled}
         text={buttonType === 'text'}
-        class="small-radius-border-button"
         secondary={buttonType === 'secondary'}>
         <span class="icon-plus" aria-hidden="true" />
-        <span class="body-text-1">{buttonText}</span>
+        {buttonText}
     </Button>
 </header>
 
diff --git a/src/routes/(console)/project-[project]/databases/database-[database]/backups/policy.svelte b/src/routes/(console)/project-[project]/databases/database-[database]/backups/policy.svelte
index 346541437..b5846a7a2 100644
--- a/src/routes/(console)/project-[project]/databases/database-[database]/backups/policy.svelte
+++ b/src/routes/(console)/project-[project]/databases/database-[database]/backups/policy.svelte
@@ -213,7 +213,7 @@
                             class="small-radius-border-button"
                             on:click={() => (showCreatePolicy = true)}>
                             <span class="icon-plus" aria-hidden="true" />
-                            <span class="text">Create Policy</span>
+                            <span class="text">Create policy</span>
                         </Button>
                     </div>
                 </div>

From 59478cb8e452ee27b1f9f6cbefe36df6c2b704aa Mon Sep 17 00:00:00 2001
From: Torsten Dittmann <torsten.dittmann@googlemail.com>
Date: Fri, 27 Sep 2024 16:21:40 +0200
Subject: [PATCH 2/2] fix: responsive table

---
 .../database-[database]/backups/+page.svelte     | 10 ++--------
 .../database-[database]/backups/table.svelte     | 16 +++++++---------
 2 files changed, 9 insertions(+), 17 deletions(-)

diff --git a/src/routes/(console)/project-[project]/databases/database-[database]/backups/+page.svelte b/src/routes/(console)/project-[project]/databases/database-[database]/backups/+page.svelte
index b17e49eac..d8731c5c2 100644
--- a/src/routes/(console)/project-[project]/databases/database-[database]/backups/+page.svelte
+++ b/src/routes/(console)/project-[project]/databases/database-[database]/backups/+page.svelte
@@ -151,7 +151,7 @@
                     lastBackupDates={data.lastBackupDates} />
             </div>
 
-            <div class="u-flex-vertical u-width-full-line">
+            <div class="u-flex-vertical u-width-full-line u-overflow-x-auto">
                 <ContainerHeader
                     title="Backups"
                     buttonText="Manual backup"
@@ -242,14 +242,8 @@
 
 <style>
     .empty {
-        block-size: 365px;
+        /* block-size: 365px; TODO: check with design */
         text-align: center;
         align-content: center;
     }
-
-    @media (min-width: 768px) {
-        .empty {
-            min-width: 802px; /* match with the table width with items */
-        }
-    }
 </style>
diff --git a/src/routes/(console)/project-[project]/databases/database-[database]/backups/table.svelte b/src/routes/(console)/project-[project]/databases/database-[database]/backups/table.svelte
index 88f235583..854cb94bb 100644
--- a/src/routes/(console)/project-[project]/databases/database-[database]/backups/table.svelte
+++ b/src/routes/(console)/project-[project]/databases/database-[database]/backups/table.svelte
@@ -109,11 +109,10 @@
         <TableCellHeadCheck
             bind:selected={selectedBackups}
             pageItemsIds={data.backups.archives.map((b) => b.$id)} />
-
         <TableCellHead width={192}>Backups</TableCellHead>
-        <TableCellHead width={120}>Size</TableCellHead>
+        <TableCellHead width={80}>Size</TableCellHead>
         <TableCellHead width={120}>Status</TableCellHead>
-        <TableCellHead width={120}>Policy</TableCellHead>
+        <TableCellHead width={80}>Policy</TableCellHead>
         <TableCellHead width={48} />
     </TableHeader>
     <TableBody>
@@ -127,18 +126,17 @@
                     bind:selectedIds={selectedBackups}
                     disabled={backup.status !== 'completed'}
                     id={backup.status !== 'completed' ? null : backup.$id} />
-
-                <TableCell width={192} title={backup.$createdAt}>
+                <TableCell title={backup.$createdAt}>
                     {cleanBackupName(backup)}
                 </TableCell>
-                <TableCell width={120} title="Backup Size">
+                <TableCell title="Backup Size">
                     {#if backup.status === 'completed'}
                         {calculateSize(backup.size)}
                     {:else}
                         -
                     {/if}
                 </TableCell>
-                <TableCell width={120} title="Backup Status">
+                <TableCell title="Backup Status">
                     <div class="u-flex u-gap-8 u-cross-baseline">
                         <Pill
                             warning={backup.status === 'pending'}
@@ -151,7 +149,7 @@
                         <!--{/if}-->
                     </div>
                 </TableCell>
-                <TableCell width={168} title="Backup Policy">
+                <TableCell title="Backup Policy">
                     <div class="u-flex u-main-space-between u-cross-baseline">
                         <span
                             use:tooltip={{
@@ -164,7 +162,7 @@
                     </div>
                 </TableCell>
 
-                <TableCell width={48}>
+                <TableCell>
                     <div class="u-flex u-cross-center">
                         <DropList bind:show={showDropdown[index]} placement="bottom-end">
                             <button