From 4fff9bbc9521e4ad75c7687cfbfccb9298f8a0c4 Mon Sep 17 00:00:00 2001
From: ItzNotABug <itznotabug@gmail.com>
Date: Mon, 19 Aug 2024 17:01:49 +0530
Subject: [PATCH] address comments: max dialog height, load collections on
 demand.

---
 .../database-[database]/delete.svelte         | 199 +++++++++++-------
 1 file changed, 120 insertions(+), 79 deletions(-)

diff --git a/src/routes/console/project-[project]/databases/database-[database]/delete.svelte b/src/routes/console/project-[project]/databases/database-[database]/delete.svelte
index c8fba4eed..93db8bc3f 100644
--- a/src/routes/console/project-[project]/databases/database-[database]/delete.svelte
+++ b/src/routes/console/project-[project]/databases/database-[database]/delete.svelte
@@ -7,7 +7,7 @@
     import { Button, FormList, InputText } from '$lib/elements/forms';
     import { addNotification } from '$lib/stores/notifications';
     import { sdk } from '$lib/stores/sdk';
-    import { database, collections } from './store';
+    import { database } from './store';
     import {
         TableBody,
         TableCellHead,
@@ -17,7 +17,7 @@
         TableScroll
     } from '$lib/elements/table';
     import { toLocaleDateTime } from '$lib/helpers/date';
-    import { Query } from '@appwrite.io/console';
+    import { type Models, Query } from '@appwrite.io/console';
     const databaseId = $page.params.database;
 
     export let showDelete = false;
@@ -26,12 +26,34 @@
     let databaseName: string = null;
     let isLoadingDocumentsCount = false;
 
+    $: collectionItems = [];
+    let collections: Models.CollectionList = null;
+
+    function buildQueries(): string[] {
+        const queries = [
+            Query.limit(3),
+            Query.orderDesc('$updatedAt'),
+        ];
+
+        if (collectionItems.length > 0) {
+            queries.push(Query.offset(collectionItems.length));
+        }
+
+        return queries;
+    }
+
     async function listCollections() {
+        // let's just wait...
+        if (isLoadingDocumentsCount) return;
+
         isLoadingDocumentsCount = true;
 
         try {
-            /* can we improve this? */
-            const collectionPromises = $collections.collections.map(async (collection) => {
+            const queries = buildQueries();
+
+            collections = await sdk.forProject.databases.listCollections(databaseId, queries);
+
+            const collectionPromises = collections.collections.map(async (collection) => {
                 const { total: totalDocuments } = await sdk.forProject.databases.listDocuments(
                     databaseId,
                     collection.$id,
@@ -46,8 +68,8 @@
                 };
             });
 
-            return await Promise.all(collectionPromises);
-        } catch {
+            collectionItems = [...collectionItems, ...await Promise.all(collectionPromises)];
+        } catch (err) {
             error = true;
         } finally {
             isLoadingDocumentsCount = false;
@@ -72,81 +94,106 @@
             trackError(error, Submit.DatabaseDelete);
         }
     };
+
+    /* reset data on modal close */
+    $: if (!showDelete) {
+        collections = null;
+        collectionItems = [];
+    }
 </script>
 
-<Modal
-    title="Delete database"
-    icon="exclamation"
-    state="warning"
-    bind:show={showDelete}
-    onSubmit={handleDelete}
-    headerDivider={false}>
-    {#await listCollections()}
-        <div class="u-flex u-main-center">
-            <div class="loader" />
-        </div>
-    {:then collections}
-        {#if error}
-            <p class="text" data-private>
-                Are you sure you want to delete <b>{$database.name}</b>?
-            </p>
-        {:else if collections.length > 0}
-            <p class="text" data-private>
-                The following collections and all data associated with <b>{$database.name}</b> will
-                be permanently deleted.
-                <b>This action is irreversible.</b>
-            </p>
+<div class="max-height-dialog">
+    <Modal
+        title="Delete database"
+        icon="exclamation"
+        size="big"
+        state="warning"
+        bind:show={showDelete}
+        onSubmit={handleDelete}
+        headerDivider={false}>
+        {#await listCollections()}
+            <div class="u-flex u-main-center">
+                <div class="loader" />
+            </div>
+        {:then}
+            {#if error}
+                <p class="text" data-private>
+                    Are you sure you want to delete <b>{$database.name}</b>?
+                </p>
+            {:else if collectionItems.length > 0}
+                <p class="text" data-private>
+                    The following collections and all data associated with <b>{$database.name}</b>
+                    will be permanently deleted.
+                    <b>This action is irreversible.</b>
+                </p>
 
-            <TableScroll dense noMargin isSticky class="table limited-modal-height">
-                <TableHeader>
-                    <TableCellHead>Collection</TableCellHead>
-                    <TableCellHead># of Documents</TableCellHead>
-                    <TableCellHead>Last Updated</TableCellHead>
-                </TableHeader>
-                <TableBody>
-                    {#each collections as collection}
-                        <TableRow>
-                            <TableCell title="Collection">{collection.name}</TableCell>
-                            <TableCell title="Documents">{collection.count}</TableCell>
-                            <TableCell>{toLocaleDateTime(collection.updatedAt)}</TableCell>
-                        </TableRow>
-                    {/each}
-                </TableBody>
-            </TableScroll>
+                <div class="u-flex-vertical u-gap-16">
+                    <TableScroll dense noMargin isSticky class="table limited-modal-height">
+                        <TableHeader>
+                            <TableCellHead>Collection</TableCellHead>
+                            <TableCellHead># of Documents</TableCellHead>
+                            <TableCellHead>Last Updated</TableCellHead>
+                        </TableHeader>
+                        <TableBody>
+                            {#each collectionItems as collection}
+                                <TableRow>
+                                    <TableCell title="Collection">{collection.name}</TableCell>
+                                    <TableCell title="Documents">{collection.count}</TableCell>
+                                    <TableCell>{toLocaleDateTime(collection.updatedAt)}</TableCell>
+                                </TableRow>
+                            {/each}
+                        </TableBody>
+                    </TableScroll>
 
-            <FormList class="u-padding-block-start-24">
-                <InputText
-                    label={`Confirm the database name to continue`}
-                    placeholder="Enter {$database.name} to continue"
-                    id="database-name"
-                    autofocus
-                    required
-                    bind:value={databaseName} />
-            </FormList>
-        {:else}
-            <p class="text" data-private>
-                Are you sure you want to delete <b>{$database.name}</b>?
-            </p>
-        {/if}
-    {/await}
+                    {#if collectionItems.length < collections.total}
+                        <div class="u-flex u-gap-16 u-cross-center">
+                            <button class="u-underline" on:click={listCollections} type="button">
+                                Show more
+                            </button>
 
-    <svelte:fragment slot="footer">
-        <Button text on:click={() => (showDelete = false)}>Cancel</Button>
-        <Button
-            secondary
-            submit
-            disabled={isLoadingDocumentsCount ||
-                ($collections.total > 0 &&
-                    !error &&
-                    (!databaseName || databaseName !== $database.name))}>
-            Delete
-        </Button>
-    </svelte:fragment>
-</Modal>
+                            {#if isLoadingDocumentsCount}
+                                <div class="loader is-small" />
+                            {/if}
+                        </div>
+                    {/if}
+                </div>
+
+                <FormList class="u-padding-block-start-24">
+                    <InputText
+                        label={`Confirm the database name to continue`}
+                        placeholder="Enter {$database.name} to continue"
+                        id="database-name"
+                        required
+                        bind:value={databaseName} />
+                </FormList>
+            {:else}
+                <p class="text" data-private>
+                    Are you sure you want to delete <b>{$database.name}</b>?
+                </p>
+            {/if}
+        {/await}
+
+        <svelte:fragment slot="footer">
+            <Button text on:click={() => (showDelete = false)}>Cancel</Button>
+            <Button
+                secondary
+                submit
+                disabled={isLoadingDocumentsCount ||
+                    (collections.total > 0 &&
+                        !error &&
+                        (!databaseName || databaseName !== $database.name))}>
+                Delete
+            </Button>
+        </svelte:fragment>
+    </Modal>
+</div>
 
 <style>
+    :global(.max-height-dialog dialog) {
+        max-height: 650px !important;
+    }
+
     :global(.limited-modal-height .table-wrapper) {
-        max-height: 450px; /* tentative, 650px [in design] looks too big and requires a scroll */
         overflow-y: scroll;
         scrollbar-width: none;
         -ms-overflow-style: none;
@@ -155,10 +202,4 @@
     :global(.limited-modal-height .table-wrapper)::-webkit-scrollbar {
         display: none;
     }
-
-    @media (max-width: 1024px) {
-        :global(.limited-modal-height .table-wrapper) {
-            max-height: 275px;
-        }
-    }
 </style>