From 3912824d95711c90e72da29e671b6fc167fafdff Mon Sep 17 00:00:00 2001 From: Harsh Mahajan Date: Fri, 27 Mar 2026 17:17:54 +0530 Subject: [PATCH] The stale reopen bug fix --- .../settings/+page.svelte | 1 - .../settings/+page.ts | 26 +------- .../updateVariables.svelte | 61 +++++++++++++++++-- 3 files changed, 58 insertions(+), 30 deletions(-) diff --git a/src/routes/(console)/project-[region]-[project]/settings/+page.svelte b/src/routes/(console)/project-[region]-[project]/settings/+page.svelte index a49c3fbfc..bed3bb541 100644 --- a/src/routes/(console)/project-[region]-[project]/settings/+page.svelte +++ b/src/routes/(console)/project-[region]-[project]/settings/+page.svelte @@ -97,7 +97,6 @@ {sdkDeleteVariable} isGlobal variableList={data.variables} - allVariableList={data.allVariables} backendPagination variablesOffset={data.variablesOffset} variablesLimit={data.limit} diff --git a/src/routes/(console)/project-[region]-[project]/settings/+page.ts b/src/routes/(console)/project-[region]-[project]/settings/+page.ts index 31f719abe..321f06ada 100644 --- a/src/routes/(console)/project-[region]-[project]/settings/+page.ts +++ b/src/routes/(console)/project-[region]-[project]/settings/+page.ts @@ -10,33 +10,10 @@ export const load: PageLoad = async ({ depends, url, params }) => { const offset = Number(url.searchParams.get('offset') ?? 0); const variablesOffset = Number(url.searchParams.get('variablesOffset') ?? 0); const projectSdk = sdk.forProject(params.region, params.project); - - async function listAllVariables() { - const allVariables = []; - let nextOffset = 0; - let total = 0; - - do { - const response = await projectSdk.projectApi.listVariables({ - queries: [Query.limit(limit), Query.offset(nextOffset)] - }); - - allVariables.push(...response.variables); - total = response.total; - nextOffset += response.variables.length; - } while (nextOffset < total); - - return { - total, - variables: allVariables - }; - } - - const [variables, allVariables, installations] = await Promise.all([ + const [variables, installations] = await Promise.all([ projectSdk.projectApi.listVariables({ queries: [Query.limit(limit), Query.offset(variablesOffset)] }), - listAllVariables(), projectSdk.vcs.listInstallations({ queries: [Query.limit(limit), Query.offset(offset)] }) @@ -47,7 +24,6 @@ export const load: PageLoad = async ({ depends, url, params }) => { offset, variablesOffset, variables, - allVariables, installations }; }; diff --git a/src/routes/(console)/project-[region]-[project]/updateVariables.svelte b/src/routes/(console)/project-[region]-[project]/updateVariables.svelte index 168aad860..6ef2bc04c 100644 --- a/src/routes/(console)/project-[region]-[project]/updateVariables.svelte +++ b/src/routes/(console)/project-[region]-[project]/updateVariables.svelte @@ -1,6 +1,6 @@