From 174b07711de07f4a85478eca9ac05caa0cf9727d Mon Sep 17 00:00:00 2001 From: hmacr Date: Mon, 21 Jul 2025 16:41:24 +0530 Subject: [PATCH 1/2] fix: Hide redeploy button when `sourceSize` is 0 --- .../functions/function-[function]/+page.svelte | 2 +- .../function-[function]/deployment-[deployment]/+page.svelte | 2 +- .../deployments/deployment-[deployment]/+page.svelte | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/+page.svelte b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/+page.svelte index 3c35c79b8..f12b3c5cf 100644 --- a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/+page.svelte +++ b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/+page.svelte @@ -98,7 +98,7 @@ - {#if $canWriteFunctions} + {#if $canWriteFunctions && activeDeployment.sourceSize !== 0} { diff --git a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/deployment-[deployment]/+page.svelte b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/deployment-[deployment]/+page.svelte index 7f64649ea..edb10ae8d 100644 --- a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/deployment-[deployment]/+page.svelte +++ b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/deployment-[deployment]/+page.svelte @@ -97,7 +97,7 @@ - {#if $canWriteFunctions} + {#if $canWriteFunctions && data.deployment.sourceSize !== 0} { diff --git a/src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/deployment-[deployment]/+page.svelte b/src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/deployment-[deployment]/+page.svelte index 82db52688..850493263 100644 --- a/src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/deployment-[deployment]/+page.svelte +++ b/src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/deployment-[deployment]/+page.svelte @@ -56,7 +56,9 @@ {/if} - + {#if deployment?.sourceSize !== 0} + + {/if} Date: Tue, 22 Jul 2025 09:37:05 +0530 Subject: [PATCH 2/2] disabled button with tooltip --- .../function-[function]/+page.svelte | 43 +++++++++++++------ .../deployment-[deployment]/+page.svelte | 30 ++++++++----- .../function-[function]/table.svelte | 32 ++++++++------ .../(components)/deploymentActionMenu.svelte | 31 +++++++------ .../deployment-[deployment]/+page.svelte | 16 +++++-- 5 files changed, 101 insertions(+), 51 deletions(-) diff --git a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/+page.svelte b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/+page.svelte index f12b3c5cf..ed9a8cc36 100644 --- a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/+page.svelte +++ b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/+page.svelte @@ -12,7 +12,15 @@ import DeploymentCard from './(components)/deploymentCard.svelte'; import RedeployModal from './(modals)/redeployModal.svelte'; import { canWriteFunctions } from '$lib/stores/roles'; - import { ActionMenu, Alert, Card, Empty, Icon, Layout } from '@appwrite.io/pink-svelte'; + import { + ActionMenu, + Alert, + Card, + Empty, + Icon, + Layout, + Tooltip + } from '@appwrite.io/pink-svelte'; import { Click, trackEvent } from '$lib/actions/analytics'; import { IconDotsHorizontal, @@ -98,17 +106,28 @@ - {#if $canWriteFunctions && activeDeployment.sourceSize !== 0} - { - selectedDeployment = activeDeployment; - showRedeploy = true; - trackEvent(Click.FunctionsRedeployClick); - toggle(); - }}> - Redeploy - + {#if $canWriteFunctions} + +
+ { + selectedDeployment = activeDeployment; + showRedeploy = true; + trackEvent( + Click.FunctionsRedeployClick + ); + toggle(); + }} + style="width: 100%"> + Redeploy + +
+
Source is empty
+
{/if} - {#if $canWriteFunctions && data.deployment.sourceSize !== 0} - { - showRedeploy = true; - trackEvent(Click.FunctionsRedeployClick); - toggle(); - }}> - Redeploy - + {#if $canWriteFunctions} + +
+ { + showRedeploy = true; + trackEvent(Click.FunctionsRedeployClick); + toggle(); + }} + style="width: 100%"> + Redeploy + +
+
Source is empty
+
{/if} {#if !!data.deployment?.sourceSize || !!data.deployment?.sourceSize} diff --git a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/table.svelte b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/table.svelte index fdfdfdb14..d4691d150 100644 --- a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/table.svelte +++ b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/table.svelte @@ -20,7 +20,8 @@ FloatingActionBar, Icon, Status, - Table + Table, + Tooltip } from '@appwrite.io/pink-svelte'; import { Click, Submit, trackError, trackEvent } from '$lib/actions/analytics'; import { @@ -149,18 +150,23 @@ - {#if deployment.sourceSize !== 0} - { - selectedDeployment = deployment; - showRedeploy = true; - toggle(); - trackEvent(Click.FunctionsRedeployClick); - }}> - Redeploy - - {/if} + +
+ { + selectedDeployment = deployment; + showRedeploy = true; + toggle(); + trackEvent(Click.FunctionsRedeployClick); + }} + style="width: 100%"> + Redeploy + +
+
Source is empty
+
{#if deployment.status === 'ready' && deployment.$id !== $func.deploymentId} - {#if !inCard && selectedDeployment?.sourceSize !== 0} - { - e.preventDefault(); - selectedDeployment = deployment; - showRedeploy = true; - toggle(); - }}> - Redeploy - + {#if !inCard} + +
+ { + e.preventDefault(); + selectedDeployment = deployment; + showRedeploy = true; + toggle(); + }} + style="width: 100%"> + Redeploy + +
+
Source is empty
+
{/if} {#if deployment?.status === 'ready' && deployment?.$id !== activeDeployment} {/if} - {#if deployment?.sourceSize !== 0} - - {/if} + +
+ +
+
Source is empty
+