From b0b2cfc69ca1dd8bd647ff08cae5fb6fdf6c0690 Mon Sep 17 00:00:00 2001 From: Harsh Mahajan Date: Fri, 6 Feb 2026 14:32:05 +0530 Subject: [PATCH 1/5] fix: badges not visible on filter button --- src/lib/layout/responsiveContainerHeader.svelte | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/lib/layout/responsiveContainerHeader.svelte b/src/lib/layout/responsiveContainerHeader.svelte index 571d325c7..7ef634fe2 100644 --- a/src/lib/layout/responsiveContainerHeader.svelte +++ b/src/lib/layout/responsiveContainerHeader.svelte @@ -14,7 +14,7 @@ import DisplaySettingsModal from './displaySettingsModal.svelte'; import { buildFilterCol } from '$lib/components/filters/quickFilters'; import { afterNavigate } from '$app/navigation'; - import { setFilters } from '$lib/components/filters/setFilters'; + import { parsedTags, setFilters } from '$lib/components/filters/setFilters'; let { columns, @@ -192,7 +192,14 @@ {/snippet} {#snippet filtersButton(icon = false)} - {/snippet} From 3e7b155cb7e06678799485ed2ced379ca82e2721 Mon Sep 17 00:00:00 2001 From: Harsh Mahajan Date: Fri, 6 Feb 2026 15:07:51 +0530 Subject: [PATCH 2/5] fix filters connected using a global state --- src/lib/components/filters/setFilters.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/lib/components/filters/setFilters.ts b/src/lib/components/filters/setFilters.ts index 301a66a0a..ff83314a5 100644 --- a/src/lib/components/filters/setFilters.ts +++ b/src/lib/components/filters/setFilters.ts @@ -11,11 +11,13 @@ export const parsedTags = writable([]); export function setFilters(localTags: TagValue[], filterCols: FilterData[], $columns: Column[]) { if (!localTags?.length) { + parsedTags.set([]); filterCols.forEach((filter) => { resetOptions(filter); cleanOldTags(filter?.title); }); } else { + parsedTags.set([]); filterCols.forEach((filter) => { const id = filter?.id?.toLowerCase(); if (id?.includes('duration')) { From e9f96a75bc5530728d56f06e708495ccd13e965f Mon Sep 17 00:00:00 2001 From: Harsh Mahajan Date: Fri, 6 Feb 2026 15:12:00 +0530 Subject: [PATCH 3/5] extracted to dervied const --- src/lib/layout/responsiveContainerHeader.svelte | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/lib/layout/responsiveContainerHeader.svelte b/src/lib/layout/responsiveContainerHeader.svelte index 7ef634fe2..6a42519b4 100644 --- a/src/lib/layout/responsiveContainerHeader.svelte +++ b/src/lib/layout/responsiveContainerHeader.svelte @@ -51,6 +51,9 @@ let filterCols = $derived( $columns.map((col) => (col.filter !== false ? buildFilterCol(col) : null)).filter(Boolean) ); + let filtersBadge = $derived( + filtersStyle === 'dropdown' && $parsedTags?.length ? `${$parsedTags.length}` : undefined + ); afterNavigate((p) => { if (!hasFilters) return; @@ -197,9 +200,7 @@ on:click={() => (showFilters = !showFilters)} text {icon} - badge={filtersStyle === 'dropdown' && $parsedTags?.length - ? `${$parsedTags.length}` - : undefined}> + badge={filtersBadge}> {/snippet} From 32d411fda91307ee51ee937f4b1a87d4d0ca436c Mon Sep 17 00:00:00 2001 From: Harsh Mahajan Date: Fri, 6 Feb 2026 15:16:21 +0530 Subject: [PATCH 4/5] use const --- src/lib/layout/responsiveContainerHeader.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/layout/responsiveContainerHeader.svelte b/src/lib/layout/responsiveContainerHeader.svelte index 6a42519b4..b67dcf430 100644 --- a/src/lib/layout/responsiveContainerHeader.svelte +++ b/src/lib/layout/responsiveContainerHeader.svelte @@ -51,7 +51,7 @@ let filterCols = $derived( $columns.map((col) => (col.filter !== false ? buildFilterCol(col) : null)).filter(Boolean) ); - let filtersBadge = $derived( + const filtersBadge = $derived( filtersStyle === 'dropdown' && $parsedTags?.length ? `${$parsedTags.length}` : undefined ); From 0968a91bc52c6968c2588da702edf3ae5eb29d21 Mon Sep 17 00:00:00 2001 From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com> Date: Fri, 6 Feb 2026 15:18:35 +0530 Subject: [PATCH 5/5] Apply suggestion from @ItzNotABug Co-authored-by: Darshan --- src/lib/layout/responsiveContainerHeader.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/layout/responsiveContainerHeader.svelte b/src/lib/layout/responsiveContainerHeader.svelte index b67dcf430..fd33b1339 100644 --- a/src/lib/layout/responsiveContainerHeader.svelte +++ b/src/lib/layout/responsiveContainerHeader.svelte @@ -48,7 +48,7 @@ let showDisplaySettingsModal = $state(false); let showFilters = $state(false); - let filterCols = $derived( + const filterCols = $derived( $columns.map((col) => (col.filter !== false ? buildFilterCol(col) : null)).filter(Boolean) ); const filtersBadge = $derived(