From 5786f3a4e36a13361815a6eff5edef4a82a7144e Mon Sep 17 00:00:00 2001 From: Binyamin Yawitz <316103+byawitz@users.noreply.github.com> Date: Wed, 2 Oct 2024 13:31:49 -0400 Subject: [PATCH 1/3] fix: getting value instead of specific enum value --- .../project-[project]/settings/smtp/+page.svelte | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/routes/(console)/project-[project]/settings/smtp/+page.svelte b/src/routes/(console)/project-[project]/settings/smtp/+page.svelte index b57172f45..17586ee5c 100644 --- a/src/routes/(console)/project-[project]/settings/smtp/+page.svelte +++ b/src/routes/(console)/project-[project]/settings/smtp/+page.svelte @@ -65,6 +65,13 @@ username = undefined; password = undefined; } + + let secureProtocol = undefined; + + if (secure) { + secureProtocol = secure as SMTPSecure + } + await sdk.forConsole.projects.updateSmtp( $project.$id, enabled, @@ -75,7 +82,7 @@ port ? port : undefined, username ? username : undefined, password ? password : undefined, - secure ? SMTPSecure.Tls : undefined + secureProtocol ); invalidate(Dependencies.PROJECT); From 9148c1590282a8616533216331decd68ea862367 Mon Sep 17 00:00:00 2001 From: Binyamin Yawitz <316103+byawitz@users.noreply.github.com> Date: Wed, 2 Oct 2024 13:38:11 -0400 Subject: [PATCH 2/3] chore: formatting --- .../(console)/project-[project]/settings/smtp/+page.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/routes/(console)/project-[project]/settings/smtp/+page.svelte b/src/routes/(console)/project-[project]/settings/smtp/+page.svelte index 17586ee5c..5e5b2be7c 100644 --- a/src/routes/(console)/project-[project]/settings/smtp/+page.svelte +++ b/src/routes/(console)/project-[project]/settings/smtp/+page.svelte @@ -69,7 +69,7 @@ let secureProtocol = undefined; if (secure) { - secureProtocol = secure as SMTPSecure + secureProtocol = secure as SMTPSecure; } await sdk.forConsole.projects.updateSmtp( From 42175f6b514135dc98e46828870912e565198827 Mon Sep 17 00:00:00 2001 From: Binyamin Yawitz <316103+byawitz@users.noreply.github.com> Date: Wed, 2 Oct 2024 14:32:48 -0400 Subject: [PATCH 3/3] fix: reviews --- .../project-[project]/settings/smtp/+page.svelte | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/routes/(console)/project-[project]/settings/smtp/+page.svelte b/src/routes/(console)/project-[project]/settings/smtp/+page.svelte index 5e5b2be7c..02d78057c 100644 --- a/src/routes/(console)/project-[project]/settings/smtp/+page.svelte +++ b/src/routes/(console)/project-[project]/settings/smtp/+page.svelte @@ -66,12 +66,6 @@ password = undefined; } - let secureProtocol = undefined; - - if (secure) { - secureProtocol = secure as SMTPSecure; - } - await sdk.forConsole.projects.updateSmtp( $project.$id, enabled, @@ -82,7 +76,7 @@ port ? port : undefined, username ? username : undefined, password ? password : undefined, - secureProtocol + secure ? (secure as SMTPSecure) : undefined ); invalidate(Dependencies.PROJECT);