Files
appwrite/tests/e2e/Services/GraphQL/StorageClientTest.php
T
Chirag Aggarwal d2230f8fe7 chore: bump PHPStan to level 4 and fix all new errors
Raises `phpstan.neon` level from 3 to 4 and fixes the 549 new errors
that level 4 surfaces across 157 files. Fixes are root-cause — no
`@phpstan-ignore`, no `@var` casts, no baseline entries, no widened
types. A handful of latent bugs were fixed along the way:

- `app/controllers/general.php`: path-traversal guard was negating
  `\substr(...)` before the strict comparison (`!\substr(...) === $base`
  was always `false === $base`). Rewritten as `\substr(...) !== $base`.
- `src/Appwrite/Platform/Modules/Databases/Http/Databases/Logs/XList.php`
  and `.../TablesDB/Logs/XList.php`: were importing the raw Matomo
  `DeviceDetector` (whose `getDevice()` returns `?int`) but treating the
  result as an array with `deviceName/deviceBrand/deviceModel` keys.
  Swapped to `Appwrite\Detector\Detector`, matching the wrapper already
  used a few lines below for `$os`/`$client`.
- `src/Appwrite/Platform/Modules/Functions/Workers/Builds.php`: a match
  key was checking `$resourceKey === 'functions'` when `$resourceKey`
  is `'functionId'|'siteId'` — always false. Switched to the intended
  `$resource->getCollection() === 'functions'` check.
- `src/Appwrite/OpenSSL/OpenSSL.php`: `encrypt()` return type tightened
  to `string|false` to match `openssl_encrypt`; this lets callers'
  `=== false` error handling remain meaningful.
- `app/controllers/api/messaging.php`: removed a dead
  `array_key_exists('from', [])` branch in the Msg91 provider (empty
  array literal; branch was unreachable).

Large cleanup categories across the 549 fixes:
- Removed redundant `?? default` on array offsets and expressions that
  PHPStan now knows are non-nullable.
- Removed unreachable statements (mostly `return;` after `throw` or
  `markTestSkipped()`).
- Removed redundant `is_array`/`is_string`/`is_bool`/`instanceof` checks
  on already-narrowed types.
- Added `default =>` arms (or throwing arms) to non-exhaustive matches
  on `string`/`mixed` input.
- Removed dead `$document === false` branches where method return types
  were tightened to non-nullable `Document`.
- Removed unused properties (`$version` on Etsy/Zoom OAuth2, `$paths` on
  Installer State, `$source` on MigrationsWorker, `$account2` on two
  GraphQL auth tests), unused traits (`ApiVectorsDB`, `DatabaseFixture`),
  and an unused `cleanupStaleExecutions` task method.
- Replaced `assertTrue(true)` and redundant `assertIsArray`/`assertIsString`/
  `assertNotNull` assertions with `addToAssertionCount(1)` or
  `assertNotEmpty` where the runtime type was already known.
2026-04-19 17:31:20 +05:30

327 lines
9.7 KiB
PHP

<?php
namespace Tests\E2E\Services\GraphQL;
use CURLFile;
use Tests\E2E\Client;
use Tests\E2E\Scopes\ProjectCustom;
use Tests\E2E\Scopes\Scope;
use Tests\E2E\Scopes\SideClient;
use Utopia\Database\Helpers\ID;
use Utopia\Database\Helpers\Permission;
use Utopia\Database\Helpers\Role;
class StorageClientTest extends Scope
{
use ProjectCustom;
use SideClient;
use Base;
private static array $cachedBucket = [];
private static array $cachedFile = [];
protected function setupBucket(): array
{
$key = $this->getProject()['$id'];
if (!empty(self::$cachedBucket[$key])) {
return self::$cachedBucket[$key];
}
$projectId = $this->getProject()['$id'];
$query = $this->getQuery(self::CREATE_BUCKET);
$gqlPayload = [
'query' => $query,
'variables' => [
'bucketId' => ID::unique(),
'name' => 'Actors',
'fileSecurity' => false,
'permissions' => [
Permission::read(Role::any()),
Permission::create(Role::any()),
Permission::update(Role::any()),
Permission::delete(Role::any()),
],
]
];
$bucket = $this->client->call(Client::METHOD_POST, '/graphql', [
'content-type' => 'application/json',
'x-appwrite-project' => $projectId,
'x-appwrite-key' => $this->getProject()['apiKey'],
], $gqlPayload);
$this->assertIsArray($bucket['body']['data']);
$this->assertArrayNotHasKey('errors', $bucket['body']);
$bucket = $bucket['body']['data']['storageCreateBucket'];
$this->assertEquals('Actors', $bucket['name']);
self::$cachedBucket[$key] = $bucket;
return $bucket;
}
protected function setupFile(): array
{
$key = $this->getProject()['$id'];
if (!empty(self::$cachedFile[$key])) {
return self::$cachedFile[$key];
}
$bucket = $this->setupBucket();
$projectId = $this->getProject()['$id'];
$query = $this->getQuery(self::CREATE_FILE);
$gqlPayload = [
'operations' => \json_encode([
'query' => $query,
'variables' => [
'bucketId' => $bucket['_id'],
'fileId' => ID::unique(),
'file' => null,
'fileSecurity' => true,
'permissions' => [
Permission::read(Role::any()),
Permission::update(Role::any()),
Permission::delete(Role::any()),
],
]
]),
'map' => \json_encode([
'0' => ["variables.file"]
]),
'0' => new CURLFile(realpath(__DIR__ . '/../../../resources/logo.png'), 'image/png', 'logo.png'),
];
$file = $this->client->call(Client::METHOD_POST, '/graphql', \array_merge([
'content-type' => 'multipart/form-data',
'x-appwrite-project' => $projectId,
], $this->getHeaders()), $gqlPayload);
$this->assertIsArray($file['body']['data']);
$this->assertArrayNotHasKey('errors', $file['body']);
self::$cachedFile[$key] = $file['body']['data']['storageCreateFile'];
return self::$cachedFile[$key];
}
public function testCreateBucket(): void
{
$bucket = $this->setupBucket();
$this->assertEquals('Actors', $bucket['name']);
}
public function testCreateFile(): void
{
$file = $this->setupFile();
$this->assertNotEmpty($file);
}
/**
* @return array
* @throws \Exception
*/
public function testGetFiles(): array
{
$bucket = $this->setupBucket();
$projectId = $this->getProject()['$id'];
$query = $this->getQuery(self::GET_FILES);
$gqlPayload = [
'query' => $query,
'variables' => [
'bucketId' => $bucket['_id'],
]
];
$files = $this->client->call(Client::METHOD_POST, '/graphql', \array_merge([
'content-type' => 'application/json',
'x-appwrite-project' => $projectId,
], $this->getHeaders()), $gqlPayload);
$this->assertIsArray($files['body']['data']);
$this->assertArrayNotHasKey('errors', $files['body']);
$files = $files['body']['data']['storageListFiles'];
$this->assertIsArray($files);
return $files;
}
/**
* @return array
* @throws \Exception
*/
public function testGetFile()
{
$bucket = $this->setupBucket();
$file = $this->setupFile();
$projectId = $this->getProject()['$id'];
$query = $this->getQuery(self::GET_FILE);
$gqlPayload = [
'query' => $query,
'variables' => [
'bucketId' => $bucket['_id'],
'fileId' => $file['_id'],
]
];
$file = $this->client->call(Client::METHOD_POST, '/graphql', \array_merge([
'content-type' => 'application/json',
'x-appwrite-project' => $projectId,
], $this->getHeaders()), $gqlPayload);
$this->assertIsArray($file['body']['data']);
$this->assertArrayNotHasKey('errors', $file['body']);
return $file['body']['data']['storageGetFile'];
}
/**
* @return array
* @throws \Exception
*/
public function testGetFilePreview()
{
$file = $this->setupFile();
$projectId = $this->getProject()['$id'];
$query = $this->getQuery(self::GET_FILE_PREVIEW);
$gqlPayload = [
'query' => $query,
'variables' => [
'bucketId' => $file['bucketId'],
'fileId' => $file['_id'],
'width' => 100,
'height' => 100,
]
];
$file = $this->client->call(Client::METHOD_POST, '/graphql', \array_merge([
'content-type' => 'application/json',
'x-appwrite-project' => $projectId,
], $this->getHeaders()), $gqlPayload);
$this->assertEquals(46719, \strlen($file['body']));
return $file;
}
/**
* @return array
* @throws \Exception
*/
public function testGetFileDownload()
{
$file = $this->setupFile();
$projectId = $this->getProject()['$id'];
$query = $this->getQuery(self::GET_FILE_DOWNLOAD);
$gqlPayload = [
'query' => $query,
'variables' => [
'bucketId' => $file['bucketId'],
'fileId' => $file['_id'],
]
];
$file = $this->client->call(Client::METHOD_POST, '/graphql', \array_merge([
'content-type' => 'application/json',
'x-appwrite-project' => $projectId,
], $this->getHeaders()), $gqlPayload);
$this->assertEquals(47218, \strlen($file['body']));
return $file;
}
/**
* @throws \Exception
*/
public function testGetFileView(): void
{
$file = $this->setupFile();
$projectId = $this->getProject()['$id'];
$query = $this->getQuery(self::GET_FILE_VIEW);
$gqlPayload = [
'query' => $query,
'variables' => [
'bucketId' => $file['bucketId'],
'fileId' => $file['_id'],
]
];
$file = $this->client->call(Client::METHOD_POST, '/graphql', \array_merge([
'content-type' => 'application/json',
'x-appwrite-project' => $projectId,
], $this->getHeaders()), $gqlPayload);
$this->assertEquals(47218, \strlen($file['body']));
}
/**
* @return array
* @throws \Exception
*/
public function testUpdateFile(): array
{
$file = $this->setupFile();
$projectId = $this->getProject()['$id'];
$query = $this->getQuery(self::UPDATE_FILE);
$gqlPayload = [
'query' => $query,
'variables' => [
'bucketId' => $file['bucketId'],
'fileId' => $file['_id'],
'permissions' => [
Permission::read(Role::any()),
Permission::update(Role::any()),
Permission::delete(Role::any()),
],
]
];
$file = $this->client->call(Client::METHOD_POST, '/graphql', \array_merge([
'content-type' => 'application/json',
'x-appwrite-project' => $projectId,
], $this->getHeaders()), $gqlPayload);
$this->assertIsArray($file['body']['data']);
$this->assertArrayNotHasKey('errors', $file['body']);
$file = $file['body']['data']['storageUpdateFile'];
$this->assertIsArray($file);
return $file;
}
/**
* @throws \Exception
*/
public function testDeleteFile(): void
{
$file = $this->setupFile();
$projectId = $this->getProject()['$id'];
$query = $this->getQuery(self::DELETE_FILE);
$gqlPayload = [
'query' => $query,
'variables' => [
'bucketId' => $file['bucketId'],
'fileId' => $file['_id'],
]
];
$file = $this->client->call(Client::METHOD_POST, '/graphql', \array_merge([
'content-type' => 'application/json',
'x-appwrite-project' => $projectId,
], $this->getHeaders()), $gqlPayload);
$this->assertIsNotArray($file['body']);
$this->assertEquals(204, $file['headers']['status-code']);
// Clear cache after deletion
$key = $this->getProject()['$id'];
self::$cachedFile[$key] = [];
}
}