Commit Graph

111 Commits

Author SHA1 Message Date
Jake Barnby e21614088f fix: Address CodeRabbit review comments
- Fix OR precheck bug: skip attribute existence check when OR conditions
  exist, since OR can match with partial attributes present
- Remove dead code in app/realtime.php (unused $names and $channels variables)
- Add tests for OR queries with missing attributes in one branch

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-05 22:24:26 +13:00
Jake Barnby 18125156d2 fix: Update compileAndFilter return type to nullable array
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-05 22:14:41 +13:00
Jake Barnby 765d334674 fix: Return null instead of empty array for non-matching queries
RuntimeQuery::filter() now returns null when the query doesn't match,
instead of an empty array. This distinguishes between "no match" and
"match with empty payload", fixing the issue where subscriptions with
empty payloads weren't being delivered.

Updated Realtime::getSubscribers() to check for null instead of using
!empty(), and updated all tests to expect null for non-matches.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-05 22:08:43 +13:00
Jake Barnby 3e31094e1e fix: Fix unit test failures for RuntimeQuery and Messaging tests
- Add missing isSelectAll() method to RuntimeQuery class
- Update RuntimeQueryTest to use compile() before filter() since filter()
  expects pre-compiled query arrays, not Query objects
- Remove incorrect break statement in Realtime::getSubscribers() that was
  stopping iteration after the first matching channel, causing subscribers
  to not be found for subsequent channels
- Use local variable $subscriptionsByChannel to avoid unused variable warning

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-05 21:57:00 +13:00
ArnabChatterjee20k 6e576b5140 added realtime query new channel and channel wise filters 2026-02-02 19:45:21 +05:30
ArnabChatterjee20k b1fab79dc4 updated query logic in array to be of and format 2026-01-16 19:06:55 +05:30
ArnabChatterjee20k da871635d9 Fix namespace import for RuntimeQuery class and update test file accordingly 2026-01-16 16:16:03 +05:30
ArnabChatterjee20k b2486fcb6c Merge remote-tracking branch 'upstream/1.8.x' into dat-969 2026-01-16 15:47:25 +05:30
Jake Barnby 2cfb5ecfd9 Reapply "Merge pull request #11130 from appwrite/feat-auth-instance"
This reverts commit 38687bc24e.
2026-01-15 04:08:00 +13:00
Jake Barnby 38687bc24e Revert "Merge pull request #11130 from appwrite/feat-auth-instance"
This reverts commit c12cad80bb, reversing
changes made to 2a17429226.

# Conflicts:
#	composer.lock
2026-01-15 03:48:42 +13:00
Jake Barnby 5c915ef92f Reapply "Merge pull request #11099 from appwrite/feat-auth-instance"
This reverts commit 321fc8ee70.
2026-01-14 19:07:49 +13:00
Jake Barnby 321fc8ee70 Revert "Merge pull request #11099 from appwrite/feat-auth-instance"
This reverts commit a4734a5de7, reversing
changes made to 15922fb88c.

# Conflicts:
#	composer.lock
2026-01-14 02:37:17 +13:00
Jake Barnby 7573ee75a2 Use authorization instance 2026-01-07 20:04:28 +13:00
ArnabChatterjee20k 874e5f61f0 Merge remote-tracking branch 'upstream/1.8.x' into dat-969 2025-12-24 19:01:13 +05:30
ArnabChatterjee20k 39cf207df9 re 2025-12-24 18:57:58 +05:30
Jake Barnby dc85d44647 Revert "Refactor auth single instance" 2025-12-20 02:54:50 +13:00
shimon 5b3659af7c Remove unused Auth import in storage controller and fix formatting in UserTest class 2025-11-28 16:11:48 +02:00
shimon 67311fe5d6 Refactor: Update role retrieval to use authorization object in multiple files 2025-11-27 18:56:33 +02:00
Damodar Lohani 12c27edaf9 Fix user test 2025-11-05 05:23:32 +00:00
Damodar Lohani 918ad4a545 remove auth test and add user test 2025-11-04 07:41:42 +00:00
Chirag Aggarwal 5d4a9e8c56 chore: add request filter v19 tests 2025-05-16 18:31:36 +00:00
Chirag Aggarwal 608eacc773 chore: removed values from response filters 2025-05-16 18:26:21 +00:00
Jake Barnby 3203ea5d43 Fix request filters with multi-method routes 2025-05-12 17:41:03 +12:00
Chirag Aggarwal d9b7a018ea chore: update specs 2025-03-31 06:23:31 +00:00
Bradley Schofield 95dcb67747 Implement new SDK Class on 1.6.x 2025-01-17 13:31:39 +09:00
Jake Barnby 8bc37026cd Revert "Feat adding coroutines" 2024-10-08 20:54:40 +13:00
Binyamin Yawitz d14edf4207 reverting: to set coroutines as head 2024-10-01 10:30:47 -04:00
Damodar Lohani 8c46f73f69 Merge branch 'main' into lohanidamodar-patch-3 2024-09-19 10:10:24 +05:45
Matej Bačo 695844faa1 Merge remote-tracking branch 'origin/1.6.x' into feat-separate-function-sizes 2024-08-21 07:17:46 +00:00
Matej Bačo 12b6351060 Separate deployment and build sizes 2024-08-19 11:06:58 +00:00
Bradley Schofield 0488a4582b Add tests 2024-08-19 14:56:43 +09:00
Matej Bačo 90b9d176ba Fix unit test placement 2024-08-08 09:02:49 +00:00
Matej Bačo f8fb98d377 Update response filter 2024-08-08 08:42:38 +00:00
Matej Bačo 51c163a42f Apply migrations properly 2024-07-24 06:55:36 +00:00
Bradley Schofield efa1924f26 Run Linter 2024-07-17 18:00:41 +09:00
Bradley Schofield 5d6b74e447 Add migrations and filters for 1.6.x 2024-07-17 14:52:17 +09:00
Damodar Lohani 1c7e6d7d81 fix test 2024-07-15 07:08:22 +00:00
Damodar Lohani b3aaca317c format and update test 2024-07-14 06:05:51 +00:00
Torsten Dittmann c3fc9e6567 tests: add request/response filter tests 2024-03-07 16:20:34 +01:00
Torsten Dittmann bcebe02eef chore: run formatter 2024-03-07 15:05:14 +01:00
Torsten Dittmann d721843ea8 test: response filters 2024-03-07 15:03:43 +01:00
Torsten Dittmann 0a1d572c72 chore: run formatter 2024-03-06 18:34:21 +01:00
Torsten Dittmann dd13d17377 feat: const for totp values 2024-03-01 03:07:58 +01:00
Bradley Schofield 4050e93b1d Run Linter 2024-02-27 13:19:35 +00:00
Bradley Schofield f4b8ae8b88 Change factors code and update Response model tests 2024-02-26 11:50:25 +00:00
Jake Barnby f28412ccd9 Add compound UID unit test 2024-02-20 20:10:20 +13:00
Jake Barnby 4d7becc459 Apply suggestions from code review 2024-02-16 20:23:31 +13:00
Bradley Schofield 38c0f8ddab Add Query Converter 2024-02-08 11:39:01 +00:00
shimon f477be7521 Merge branch '1.5.x' of github.com:appwrite/appwrite into 1.5.x-response-request-models
 Conflicts:
	composer.json
2024-01-31 20:28:03 +02:00
Bradley Schofield b88ff90c22 Update V17Test.php 2024-01-22 11:23:23 +00:00