From 95b3db0228c65b65a128d4ab0454ae17d7430bbe Mon Sep 17 00:00:00 2001
From: loks0n <22452787+loks0n@users.noreply.github.com>
Date: Mon, 9 Mar 2026 20:40:34 +0000
Subject: [PATCH 1/2] fix: storage health error swallowing

---
 .../Health/Http/Health/Storage/Get.php        | 36 ++++++-------------
 1 file changed, 11 insertions(+), 25 deletions(-)

diff --git a/src/Appwrite/Platform/Modules/Health/Http/Health/Storage/Get.php b/src/Appwrite/Platform/Modules/Health/Http/Health/Storage/Get.php
index 52468cab5a..6757f6a334 100644
--- a/src/Appwrite/Platform/Modules/Health/Http/Health/Storage/Get.php
+++ b/src/Appwrite/Platform/Modules/Health/Http/Health/Storage/Get.php
@@ -2,7 +2,6 @@
 
 namespace Appwrite\Platform\Modules\Health\Http\Health\Storage;
 
-use Appwrite\Extend\Exception;
 use Appwrite\SDK\AuthType;
 use Appwrite\SDK\ContentType;
 use Appwrite\SDK\Method;
@@ -58,34 +57,21 @@ class Get extends Action
         $checkStart = \microtime(true);
 
         foreach ($devices as $device) {
-            $uniqueFileName = \uniqid('health', true);
-            $filePath = $device->getPath($uniqueFileName);
+            $path = $device->getPath(\uniqid('health', true));
 
-            if (!$device->write($filePath, 'test', 'text/plain')) {
-                throw new Exception(Exception::GENERAL_SERVER_ERROR, 'Failed writing test file to ' . $device->getRoot());
-            }
-
-            $readError = null;
             try {
-                if ($device->read($filePath) !== 'test') {
-                    $readError = new Exception(Exception::GENERAL_SERVER_ERROR, 'Failed reading test file from ' . $device->getRoot());
+                if (!$device->write($path, 'test', 'text/plain')) {
+                    throw new \Exception("Failed writing test file to {$device->getRoot()}");
+                }
+
+                $content = $device->read($path);
+                if ($content !== 'test') {
+                    throw new \Exception("Failed reading test file from {$device->getRoot()}: content mismatch");
                 }
-            } catch (\Throwable $e) {
-                $readError = $e;
             } finally {
-                // Always attempt to clean up test file
-                if (!$device->delete($filePath)) {
-                    if ($readError !== null) {
-                        // If read already failed, wrap delete error but preserve original
-                        \error_log('Failed deleting test file from ' . $device->getRoot() . ' during read error recovery');
-                    } else {
-                        throw new Exception(Exception::GENERAL_SERVER_ERROR, 'Failed deleting test file from ' . $device->getRoot());
-                    }
-                }
-                // Re-throw read error if it occurred
-                if ($readError !== null) {
-                    throw $readError;
-                }
+                try {
+                    $device->delete($path);
+                } catch (\Throwable) {}
             }
         }
 

From 4d7aa6d8ab241ea5e43917e459b682072d6b0767 Mon Sep 17 00:00:00 2001
From: loks0n <22452787+loks0n@users.noreply.github.com>
Date: Mon, 9 Mar 2026 20:47:07 +0000
Subject: [PATCH 2/2] style: format storage health check braces

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 .../Platform/Modules/Health/Http/Health/Storage/Get.php        | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/Appwrite/Platform/Modules/Health/Http/Health/Storage/Get.php b/src/Appwrite/Platform/Modules/Health/Http/Health/Storage/Get.php
index 6757f6a334..93c9483959 100644
--- a/src/Appwrite/Platform/Modules/Health/Http/Health/Storage/Get.php
+++ b/src/Appwrite/Platform/Modules/Health/Http/Health/Storage/Get.php
@@ -71,7 +71,8 @@ class Get extends Action
             } finally {
                 try {
                     $device->delete($path);
-                } catch (\Throwable) {}
+                } catch (\Throwable) {
+                }
             }
         }