diff --git a/app/controllers/api/avatars.php b/app/controllers/api/avatars.php index f5f40cd3cd..161e87b130 100644 --- a/app/controllers/api/avatars.php +++ b/app/controllers/api/avatars.php @@ -95,9 +95,7 @@ App::get('/v1/avatars/credit-cards/:code') ->param('height', 100, new Range(0, 2000), 'Image height. Pass an integer between 0 to 2000. Defaults to 100.', true) ->param('quality', 100, new Range(0, 100), 'Image quality. Pass an integer between 0 to 100. Defaults to 100.', true) ->inject('response') - ->action(function ($code, $width, $height, $quality, $response) use ($avatarCallback) { - return $avatarCallback('credit-cards', $code, $width, $height, $quality, $response); - }); + ->action(fn($code, $width, $height, $quality, $response) => $avatarCallback('credit-cards', $code, $width, $height, $quality, $response)); App::get('/v1/avatars/browsers/:code') ->desc('Get Browser Icon') @@ -115,9 +113,7 @@ App::get('/v1/avatars/browsers/:code') ->param('height', 100, new Range(0, 2000), 'Image height. Pass an integer between 0 to 2000. Defaults to 100.', true) ->param('quality', 100, new Range(0, 100), 'Image quality. Pass an integer between 0 to 100. Defaults to 100.', true) ->inject('response') - ->action(function ($code, $width, $height, $quality, $response) use ($avatarCallback) { - return $avatarCallback('browsers', $code, $width, $height, $quality, $response); - }); + ->action(fn($code, $width, $height, $quality, $response) => $avatarCallback('browsers', $code, $width, $height, $quality, $response)); App::get('/v1/avatars/flags/:code') ->desc('Get Country Flag') @@ -135,9 +131,7 @@ App::get('/v1/avatars/flags/:code') ->param('height', 100, new Range(0, 2000), 'Image height. Pass an integer between 0 to 2000. Defaults to 100.', true) ->param('quality', 100, new Range(0, 100), 'Image quality. Pass an integer between 0 to 100. Defaults to 100.', true) ->inject('response') - ->action(function ($code, $width, $height, $quality, $response) use ($avatarCallback) { - return $avatarCallback('flags', $code, $width, $height, $quality, $response); - }); + ->action(fn($code, $width, $height, $quality, $response) => $avatarCallback('flags', $code, $width, $height, $quality, $response)); App::get('/v1/avatars/image') ->desc('Get Image from URL') diff --git a/app/http.php b/app/http.php index 28b070d3a4..78152126be 100644 --- a/app/http.php +++ b/app/http.php @@ -73,17 +73,8 @@ $http->on('start', function (Server $http) use ($payloadSize, $register) { } } while ($attempts < $max); - App::setResource('db', function () use (&$db) { - return $db; - }); - - App::setResource('cache', function () use (&$redis) { - return $redis; - }); - - App::setResource('app', function() use (&$app) { - return $app; - }); + App::setResource('db', fn() => $db); + App::setResource('cache', fn() => $redis); $dbForConsole = $app->getResource('dbForConsole'); /** @var Utopia\Database\Database $dbForConsole */ @@ -170,14 +161,9 @@ $http->on('request', function (SwooleRequest $swooleRequest, SwooleResponse $swo $db = $register->get('dbPool')->get(); $redis = $register->get('redisPool')->get(); - App::setResource('db', function () use (&$db) { - return $db; - }); + App::setResource('db', fn() => $db); + App::setResource('cache', fn() => $redis); - App::setResource('cache', function () use (&$redis) { - return $redis; - }); - try { Authorization::cleanRoles(); Authorization::setRole('role:all'); diff --git a/app/init.php b/app/init.php index 45cdf438b6..e97e51ae1f 100644 --- a/app/init.php +++ b/app/init.php @@ -543,9 +543,7 @@ Locale::setLanguageFromJSON('zh-tw', __DIR__.'/config/locale/translations/zh-tw. // Runtime Execution -App::setResource('register', function() use ($register) { - return $register; -}); +App::setResource('register', fn() => $register); App::setResource('layout', function($locale) { $layout = new View(__DIR__.'/views/layouts/default.phtml'); diff --git a/app/realtime.php b/app/realtime.php index 80d1494208..5215cd2477 100644 --- a/app/realtime.php +++ b/app/realtime.php @@ -323,21 +323,10 @@ $server->onOpen(function (int $connection, SwooleRequest $request) use ($server, Console::info("Connection open (user: {$connection})"); - App::setResource('db', function () use (&$db) { - return $db; - }); - - App::setResource('cache', function () use (&$redis) { - return $redis; - }); - - App::setResource('request', function () use ($request) { - return $request; - }); - - App::setResource('response', function () use ($response) { - return $response; - }); + App::setResource('db', fn() => $db); + App::setResource('cache', fn() => $redis); + App::setResource('request', fn() => $request); + App::setResource('response', fn() => $response); try { /** @var \Utopia\Database\Document $user */ diff --git a/tests/e2e/Services/Realtime/RealtimeCustomClientTest.php b/tests/e2e/Services/Realtime/RealtimeCustomClientTest.php index 6b815c9043..0c5b7b61e7 100644 --- a/tests/e2e/Services/Realtime/RealtimeCustomClientTest.php +++ b/tests/e2e/Services/Realtime/RealtimeCustomClientTest.php @@ -569,7 +569,7 @@ class RealtimeCustomClientTest extends Scope 'x-appwrite-project' => $this->getProject()['$id'], 'x-appwrite-key' => $this->getProject()['apiKey'] ]), [ - 'attributeId' => 'name', + 'key' => 'name', 'size' => 256, 'required' => true, ]);