From da8ff0f99c649f02964ccf3081c4a92d7b51c663 Mon Sep 17 00:00:00 2001 From: loks0n <22452787+loks0n@users.noreply.github.com> Date: Mon, 1 Jun 2026 15:50:03 +0100 Subject: [PATCH] chore: replace deprecated Route::getParamsValues() in shared API Reconstruct request param values from per-request sources (path values + request params + param defaults) instead of reading the deprecated mutable value store on the shared Route object, mirroring the framework's own Http::getArguments() resolution precedence. Co-Authored-By: Claude Opus 4.8 (1M context) --- app/controllers/shared/api.php | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/app/controllers/shared/api.php b/app/controllers/shared/api.php index 2b39208fcd..7a36b012e3 100644 --- a/app/controllers/shared/api.php +++ b/app/controllers/shared/api.php @@ -38,6 +38,7 @@ use Utopia\Database\Validator\Authorization\Input; use Utopia\Database\Validator\Roles; use Utopia\Http\Http; use Utopia\Http\Route; +use Utopia\Http\Router; use Utopia\Span\Span; use Utopia\System\System; use Utopia\Telemetry\Adapter as Telemetry; @@ -862,7 +863,14 @@ Http::shutdown() } } - $requestParams = $route->getParamsValues(); + $preparedPath = Router::preparePath($route->getMatchedPath()); + $pathValues = $route->getPathValues($request, $preparedPath[0]); + $reqParams = $request->getParams(); + + $requestParams = []; + foreach ($route->getParams() as $key => $param) { + $requestParams[$key] = $pathValues[$key] ?? $reqParams[$key] ?? $param['default']; + } /** * Abuse labels