From da8ba47d7e12cd923b8848cd0f05fa92732ab594 Mon Sep 17 00:00:00 2001 From: Chirag Aggarwal Date: Tue, 14 Jul 2026 09:58:56 +0530 Subject: [PATCH] fix: handle mail adapter delivery failures --- src/Appwrite/Platform/Workers/Mails.php | 7 ++- tests/unit/Platform/Workers/MailsTest.php | 59 ++++++++++++++++++++++- 2 files changed, 63 insertions(+), 3 deletions(-) diff --git a/src/Appwrite/Platform/Workers/Mails.php b/src/Appwrite/Platform/Workers/Mails.php index 48cb58722d..63fe9af39f 100644 --- a/src/Appwrite/Platform/Workers/Mails.php +++ b/src/Appwrite/Platform/Workers/Mails.php @@ -216,7 +216,12 @@ class Mails extends Action $emailMessage->setOrigin(MESSAGE_SEND_TYPE_INTERNAL); try { - $adapter->send($emailMessage); + $result = $adapter->send($emailMessage); + + if (($result['deliveredTo'] ?? 0) === 0) { + $error = $result['results'][0]['error'] ?? 'Unknown error'; + throw new Exception($error); + } } catch (\Throwable $error) { Span::add('mail.status', 'failure'); diff --git a/tests/unit/Platform/Workers/MailsTest.php b/tests/unit/Platform/Workers/MailsTest.php index a6b7a123d7..f15935a8d0 100644 --- a/tests/unit/Platform/Workers/MailsTest.php +++ b/tests/unit/Platform/Workers/MailsTest.php @@ -17,6 +17,8 @@ use Utopia\Telemetry\Adapter\None; final class SpyMailAdapter extends EmailAdapter { public ?EmailMessage $captured = null; + public int $deliveredTo = 1; + public ?string $error = null; public int $sendCount = 0; public function getName(): string @@ -34,10 +36,19 @@ final class SpyMailAdapter extends EmailAdapter $this->sendCount++; $this->captured = $message; + $result = [ + 'recipient' => $message->getTo()[0]['email'] ?? '', + 'status' => $this->deliveredTo === 0 ? 'failure' : 'success', + ]; + + if ($this->error !== null) { + $result['error'] = $this->error; + } + return [ - 'deliveredTo' => 1, + 'deliveredTo' => $this->deliveredTo, 'type' => $this->getType(), - 'results' => [['recipient' => $message->getTo()[0]['email'] ?? '', 'status' => 'sent']], + 'results' => [$result], ]; } } @@ -61,10 +72,12 @@ final class MailsTest extends TestCase 'queue' => 'v1-mails', 'timestamp' => \time(), 'payload' => [ + 'smtp' => [], 'recipient' => 'legacy@example.test', 'name' => 'Legacy User', 'subject' => 'Hello {{name}}', 'body' => 'Body {{name}}', + 'bodyTemplate' => '', 'variables' => ['name' => 'Legacy'], 'customMailOptions' => [ 'senderEmail' => 'sender@example.test', @@ -95,4 +108,46 @@ final class MailsTest extends TestCase $this->assertSame('reply@example.test', $message->getReplyToEmail()); $this->assertSame('Custom Reply', $message->getReplyToName()); } + + public function testMailDeliveryFailureIsThrownByMailsWorker(): void + { + $adapter = new SpyMailAdapter(); + $adapter->deliveredTo = 0; + $adapter->error = 'Domain not verified'; + + $registry = new Registry(); + $registry->set('smtp', static fn () => $adapter); + + $previousSmtpHost = \getenv('_APP_SMTP_HOST'); + \putenv('_APP_SMTP_HOST=spy.smtp.test'); + + try { + $this->expectException(\Exception::class); + $this->expectExceptionMessage('Error sending mail: Domain not verified'); + + $worker = new Mails(); + $worker->action( + new Message([ + 'pid' => 'pid', + 'queue' => 'v1-mails', + 'timestamp' => \time(), + 'payload' => [ + 'smtp' => [], + 'recipient' => 'legacy@example.test', + 'name' => 'Legacy User', + 'subject' => 'Hello', + 'body' => 'Body', + 'bodyTemplate' => '', + 'variables' => [], + ], + ]), + new Document(['$id' => 'project-x']), + $registry, + new Log(), + new None(), + ); + } finally { + \putenv($previousSmtpHost === false ? '_APP_SMTP_HOST' : '_APP_SMTP_HOST=' . $previousSmtpHost); + } + } }