From bebcec41e2889b3fa3b3e1cbfbf16cebe1ccefd9 Mon Sep 17 00:00:00 2001 From: harsh mahajan Date: Mon, 14 Sep 2026 15:13:37 +0530 Subject: [PATCH] Keep Msg91 providers disabled until a template is configured --- .../Messaging/Http/Providers/Msg91/Create.php | 1 + .../e2e/Services/Messaging/MessagingBase.php | 57 +++++++++++++++++++ 2 files changed, 58 insertions(+) diff --git a/src/Appwrite/Platform/Modules/Messaging/Http/Providers/Msg91/Create.php b/src/Appwrite/Platform/Modules/Messaging/Http/Providers/Msg91/Create.php index f24e0ad0f2..f8d009b556 100644 --- a/src/Appwrite/Platform/Modules/Messaging/Http/Providers/Msg91/Create.php +++ b/src/Appwrite/Platform/Modules/Messaging/Http/Providers/Msg91/Create.php @@ -88,6 +88,7 @@ class Create extends Action $enabled === true && \array_key_exists('senderId', $credentials) && \array_key_exists('authKey', $credentials) + && \array_key_exists('templateId', $credentials) ) { $enabled = true; } else { diff --git a/tests/e2e/Services/Messaging/MessagingBase.php b/tests/e2e/Services/Messaging/MessagingBase.php index d0a4f59140..ce999542e1 100644 --- a/tests/e2e/Services/Messaging/MessagingBase.php +++ b/tests/e2e/Services/Messaging/MessagingBase.php @@ -969,6 +969,63 @@ trait MessagingBase $this->assertEquals(false, $response['body']['enabled']); } + public function testCreateMsg91ProviderWithoutTemplate(): void + { + $headers = [ + 'content-type' => 'application/json', + 'x-appwrite-project' => $this->getProject()['$id'], + 'x-appwrite-key' => $this->getProject()['apiKey'], + ]; + $providerId = ID::unique(); + $completeProviderId = ID::unique(); + $params = [ + 'providerId' => $providerId, + 'name' => 'Msg91 without template', + 'senderId' => 'APPWRT', + 'authKey' => 'test-auth-key', + 'enabled' => true, + ]; + + try { + /** + * Test for FAILURE + */ + $response = $this->client->call(Client::METHOD_POST, '/messaging/providers/msg91', $headers, $params); + $this->assertEquals(201, $response['headers']['status-code']); + $this->assertFalse($response['body']['enabled']); + + $response = $this->client->call(Client::METHOD_GET, '/messaging/providers/' . $providerId, $headers); + $this->assertEquals(200, $response['headers']['status-code']); + $this->assertFalse($response['body']['enabled']); + + $response = $this->client->call(Client::METHOD_PATCH, '/messaging/providers/msg91/' . $providerId, $headers, [ + 'enabled' => true, + ]); + $this->assertEquals(400, $response['headers']['status-code']); + $this->assertEquals('provider_missing_credentials', $response['body']['type']); + + /** + * Test for SUCCESS + */ + $response = $this->client->call(Client::METHOD_PATCH, '/messaging/providers/msg91/' . $providerId, $headers, [ + 'templateId' => 'test-template-id', + 'enabled' => true, + ]); + $this->assertEquals(200, $response['headers']['status-code']); + $this->assertTrue($response['body']['enabled']); + + $params['providerId'] = $completeProviderId; + $params['templateId'] = 'test-template-id'; + $response = $this->client->call(Client::METHOD_POST, '/messaging/providers/msg91', $headers, $params); + $this->assertEquals(201, $response['headers']['status-code']); + $this->assertTrue($response['body']['enabled']); + } finally { + foreach ([$providerId, $completeProviderId] as $id) { + $this->client->call(Client::METHOD_DELETE, '/messaging/providers/' . $id, $headers); + } + } + } + public function testCreateFCMProviderInvalidCredentials(): void { $response = $this->client->call(Client::METHOD_POST, '/messaging/providers/fcm', [