From 119cc018311df2e7271f653f01f857004dad029b Mon Sep 17 00:00:00 2001 From: Chirag Aggarwal Date: Sat, 27 Jun 2026 19:49:26 +0530 Subject: [PATCH] Fix unit test warnings and deprecations --- src/Appwrite/Functions/Validator/Headers.php | 10 +++++++--- src/Appwrite/Task/Validator/Cron.php | 9 +++++++++ tests/extensions/SwooleCleanupSubscriber.php | 17 +++++++++++++++++ tests/extensions/TestHook.php | 1 + 4 files changed, 34 insertions(+), 3 deletions(-) create mode 100644 tests/extensions/SwooleCleanupSubscriber.php diff --git a/src/Appwrite/Functions/Validator/Headers.php b/src/Appwrite/Functions/Validator/Headers.php index 04003d535b..a18660fa2d 100644 --- a/src/Appwrite/Functions/Validator/Headers.php +++ b/src/Appwrite/Functions/Validator/Headers.php @@ -50,13 +50,17 @@ class Headers extends Validator $size = 0; foreach ($value as $key => $val) { - $length = \strlen($key); // Reject non-string keys - if (!\is_string($key) || $length === 0) { + if (!\is_string($key)) { return false; } - $size += $length + \strlen($val); + $length = \strlen($key); + if ($length === 0) { + return false; + } + + $size += $length + \strlen($val ?? ''); if ($size >= $this->maxSize) { return false; } diff --git a/src/Appwrite/Task/Validator/Cron.php b/src/Appwrite/Task/Validator/Cron.php index 18f3333a57..9e6fcd92a1 100644 --- a/src/Appwrite/Task/Validator/Cron.php +++ b/src/Appwrite/Task/Validator/Cron.php @@ -39,10 +39,19 @@ class Cron extends Validator } try { + \set_error_handler(static function (int $severity, string $message): bool { + if (($severity & E_WARNING) === E_WARNING) { + throw new \RuntimeException($message); + } + + return false; + }); (new CronExpression($value))->getNextRunDate(); return true; } catch (\RuntimeException) { return false; + } finally { + \restore_error_handler(); } } diff --git a/tests/extensions/SwooleCleanupSubscriber.php b/tests/extensions/SwooleCleanupSubscriber.php new file mode 100644 index 0000000000..8f14290211 --- /dev/null +++ b/tests/extensions/SwooleCleanupSubscriber.php @@ -0,0 +1,17 @@ +registerSubscriber(new TestPreparationStartedSubscriber()); $facade->registerSubscriber(new TestFinishedSubscriber(self::MAX_SECONDS_ALLOWED)); $facade->registerSubscriber(new RetrySubscriber()); + $facade->registerSubscriber(new SwooleCleanupSubscriber()); } }