From c331a3caae7345eb27dbeaf4221fd008735e662c Mon Sep 17 00:00:00 2001 From: Chirag Aggarwal Date: Wed, 25 Jun 2025 11:00:07 +0530 Subject: [PATCH] chore: minor fixes --- .github/workflows/tests.yml | 2 -- src/Appwrite/Network/Platform.php | 5 ++++- src/Appwrite/Network/Validator/Origin.php | 2 +- tests/e2e/Scopes/Scope.php | 2 ++ 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 97f3696e67..a69e11b892 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -283,8 +283,6 @@ jobs: name: E2E Service Test (Dev Keys) runs-on: ubuntu-latest needs: setup - strategy: - fail-fast: false steps: - name: checkout uses: actions/checkout@v4 diff --git a/src/Appwrite/Network/Platform.php b/src/Appwrite/Network/Platform.php index ab7b73cd17..cc59bd4508 100644 --- a/src/Appwrite/Network/Platform.php +++ b/src/Appwrite/Network/Platform.php @@ -69,7 +69,9 @@ class Platform switch ($type) { case self::TYPE_WEB: case self::TYPE_FLUTTER_WEB: - $hostnames[] = $hostname; + if (!empty($hostname)) { + $hostnames[] = $hostname; + } break; case self::TYPE_FLUTTER_IOS: case self::TYPE_FLUTTER_ANDROID: @@ -83,6 +85,7 @@ class Platform case self::TYPE_APPLE_TVOS: case self::TYPE_REACT_NATIVE_IOS: case self::TYPE_REACT_NATIVE_ANDROID: + case self::TYPE_UNITY: if (!empty($key)) { $hostnames[] = $key; } diff --git a/src/Appwrite/Network/Validator/Origin.php b/src/Appwrite/Network/Validator/Origin.php index 53598da324..b0aa4bd49b 100644 --- a/src/Appwrite/Network/Validator/Origin.php +++ b/src/Appwrite/Network/Validator/Origin.php @@ -16,7 +16,7 @@ class Origin extends Validator /** * Constructor * - * @param array $platforms + * @param array<\Utopia\Database\Document> $platforms */ public function __construct(array $platforms) { diff --git a/tests/e2e/Scopes/Scope.php b/tests/e2e/Scopes/Scope.php index dddc97e3a0..80eac2acc3 100644 --- a/tests/e2e/Scopes/Scope.php +++ b/tests/e2e/Scopes/Scope.php @@ -189,6 +189,8 @@ abstract class Scope extends TestCase 'name' => $name, ]); + fwrite(STDERR, json_encode($user, JSON_PRETTY_PRINT)); + $this->assertEquals(201, $user['headers']['status-code']); $session = $this->client->call(Client::METHOD_POST, '/account/sessions/email', [