From b8f6393df6ab538621812bc99ecc90f81d8fd2dc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Matej=20Ba=C4=8Do?= <matejbaco2000@gmail.com>
Date: Tue, 30 Aug 2022 08:57:10 +0000
Subject: [PATCH] PR review changes

---
 composer.lock                                            | 8 ++++----
 src/Appwrite/Utopia/Database/Validator/Queries.php       | 1 +
 src/Appwrite/Utopia/Database/Validator/Query/Base.php    | 9 ---------
 tests/unit/Utopia/Database/Validator/Query/LimitTest.php | 2 +-
 .../unit/Utopia/Database/Validator/Query/OffsetTest.php  | 2 +-
 tests/unit/Utopia/Database/Validator/Query/OrderTest.php | 1 +
 6 files changed, 8 insertions(+), 15 deletions(-)

diff --git a/composer.lock b/composer.lock
index d2f881d7cc..ebecc59afb 100644
--- a/composer.lock
+++ b/composer.lock
@@ -2841,12 +2841,12 @@
             "source": {
                 "type": "git",
                 "url": "https://github.com/appwrite/sdk-generator.git",
-                "reference": "bf05fc00755b9d27dac530669ca834f3ceb655ec"
+                "reference": "6e630a62f522ac68a7056bebf81cd032c7a053ba"
             },
             "dist": {
                 "type": "zip",
-                "url": "https://api.github.com/repos/appwrite/sdk-generator/zipball/bf05fc00755b9d27dac530669ca834f3ceb655ec",
-                "reference": "bf05fc00755b9d27dac530669ca834f3ceb655ec",
+                "url": "https://api.github.com/repos/appwrite/sdk-generator/zipball/6e630a62f522ac68a7056bebf81cd032c7a053ba",
+                "reference": "6e630a62f522ac68a7056bebf81cd032c7a053ba",
                 "shasum": ""
             },
             "require": {
@@ -2884,7 +2884,7 @@
                 "issues": "https://github.com/appwrite/sdk-generator/issues",
                 "source": "https://github.com/appwrite/sdk-generator/tree/master"
             },
-            "time": "2022-08-28T04:14:32+00:00"
+            "time": "2022-08-29T10:43:33+00:00"
         },
         {
             "name": "doctrine/instantiator",
diff --git a/src/Appwrite/Utopia/Database/Validator/Queries.php b/src/Appwrite/Utopia/Database/Validator/Queries.php
index ec77971496..1e9fe8f208 100644
--- a/src/Appwrite/Utopia/Database/Validator/Queries.php
+++ b/src/Appwrite/Utopia/Database/Validator/Queries.php
@@ -114,6 +114,7 @@ class Queries extends Validator
 
         return true;
     }
+
     /**
      * Is array
      *
diff --git a/src/Appwrite/Utopia/Database/Validator/Query/Base.php b/src/Appwrite/Utopia/Database/Validator/Query/Base.php
index b23d594ea7..71a1497d29 100644
--- a/src/Appwrite/Utopia/Database/Validator/Query/Base.php
+++ b/src/Appwrite/Utopia/Database/Validator/Query/Base.php
@@ -54,15 +54,6 @@ abstract class Base extends Validator
         return self::TYPE_OBJECT;
     }
 
-    /**
-     * Is valid.
-     *
-     * @param Query $value
-     *
-     * @return bool
-     */
-    abstract public function isValid($query): bool;
-
     /**
      * Returns what type of query this Validator is for
      */
diff --git a/tests/unit/Utopia/Database/Validator/Query/LimitTest.php b/tests/unit/Utopia/Database/Validator/Query/LimitTest.php
index e37cb49624..1594d0db1f 100644
--- a/tests/unit/Utopia/Database/Validator/Query/LimitTest.php
+++ b/tests/unit/Utopia/Database/Validator/Query/LimitTest.php
@@ -16,7 +16,7 @@ class LimitTest extends TestCase
 
     public function setUp(): void
     {
-        $this->validator = new Limit();
+        $this->validator = new Limit(100);
     }
 
     public function tearDown(): void
diff --git a/tests/unit/Utopia/Database/Validator/Query/OffsetTest.php b/tests/unit/Utopia/Database/Validator/Query/OffsetTest.php
index 8f7010c718..4a29117e83 100644
--- a/tests/unit/Utopia/Database/Validator/Query/OffsetTest.php
+++ b/tests/unit/Utopia/Database/Validator/Query/OffsetTest.php
@@ -16,7 +16,7 @@ class OffsetTest extends TestCase
 
     public function setUp(): void
     {
-        $this->validator = new Offset();
+        $this->validator = new Offset(5000);
     }
 
     public function tearDown(): void
diff --git a/tests/unit/Utopia/Database/Validator/Query/OrderTest.php b/tests/unit/Utopia/Database/Validator/Query/OrderTest.php
index e60b7ce9b9..fe1b42d5c1 100644
--- a/tests/unit/Utopia/Database/Validator/Query/OrderTest.php
+++ b/tests/unit/Utopia/Database/Validator/Query/OrderTest.php
@@ -50,5 +50,6 @@ class OrderTest extends TestCase
         $this->assertEquals($this->validator->isValid(Query::equal('dne', ['v'])), false, $this->validator->getDescription());
         $this->assertEquals($this->validator->isValid(Query::equal('', ['v'])), false, $this->validator->getDescription());
         $this->assertEquals($this->validator->isValid(Query::orderDesc('dne')), false, $this->validator->getDescription());
+        $this->assertEquals($this->validator->isValid(Query::orderAsc('dne')), false, $this->validator->getDescription());
     }
 }