From abaf46790ecf27eaa10da74d8ea9debd6a5d2ed6 Mon Sep 17 00:00:00 2001 From: harsh mahajan Date: Thu, 13 Aug 2026 00:15:15 +0530 Subject: [PATCH] Drop the redundant start command loop All twenty-three start commands in app/config/frameworks.php shell out to a helper script, so every value the loop asserted against was already caught by the helpers/ check two lines above it. Reading the config back only restated what that check covers, and it was the one thing pulling Config into the trait. --- tests/e2e/Services/Sites/SitesBase.php | 9 --------- 1 file changed, 9 deletions(-) diff --git a/tests/e2e/Services/Sites/SitesBase.php b/tests/e2e/Services/Sites/SitesBase.php index f56536f76c..a01b08f414 100644 --- a/tests/e2e/Services/Sites/SitesBase.php +++ b/tests/e2e/Services/Sites/SitesBase.php @@ -6,7 +6,6 @@ use Appwrite\Tests\Async; use Appwrite\Tests\Async\Exceptions\Critical; use CURLFile; use Tests\E2E\Client; -use Utopia\Config\Config; use Utopia\Console; use Utopia\Database\Helpers\ID; use Utopia\Database\Query; @@ -506,13 +505,5 @@ trait SitesBase // Every framework start command shells out to a helper script shipped in the runtime image. $this->assertStringNotContainsString('helpers/', $body); - - foreach (Config::getParam('frameworks', []) as $framework) { - foreach ($framework['adapters'] ?? [] as $adapter) { - if (!empty($adapter['startCommand'])) { - $this->assertStringNotContainsString($adapter['startCommand'], $body); - } - } - } } }