From a45db60313b52115eadbbfb0ddc3b4d473c71942 Mon Sep 17 00:00:00 2001
From: loks0n <22452787+loks0n@users.noreply.github.com>
Date: Wed, 2 Oct 2024 14:16:25 +0100
Subject: [PATCH] fix: falsy values

---
 tests/e2e/General/UsageTest.php                |  4 ++--
 .../Functions/FunctionsCustomClientTest.php    |  4 ++--
 .../Functions/FunctionsCustomServerTest.php    | 18 +++++++++---------
 .../FunctionsScheduleTest.php                  |  2 +-
 4 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/tests/e2e/General/UsageTest.php b/tests/e2e/General/UsageTest.php
index db75a5db45..c50a15fd3f 100644
--- a/tests/e2e/General/UsageTest.php
+++ b/tests/e2e/General/UsageTest.php
@@ -931,7 +931,7 @@ class UsageTest extends Scope
                 'x-appwrite-project' => $this->getProject()['$id']
             ], $this->getHeaders()),
             [
-                'async' => false,
+                'async' => 'false',
             ]
         );
 
@@ -955,7 +955,7 @@ class UsageTest extends Scope
                 'x-appwrite-project' => $this->getProject()['$id']
             ], $this->getHeaders()),
             [
-                'async' => false,
+                'async' => 'false',
             ]
         );
 
diff --git a/tests/e2e/Services/Functions/FunctionsCustomClientTest.php b/tests/e2e/Services/Functions/FunctionsCustomClientTest.php
index 3447ee0547..31cc05f423 100644
--- a/tests/e2e/Services/Functions/FunctionsCustomClientTest.php
+++ b/tests/e2e/Services/Functions/FunctionsCustomClientTest.php
@@ -97,7 +97,7 @@ class FunctionsCustomClientTest extends Scope
 
         $execution = $this->createExecution($functionId, [
             'body' => 'foobar',
-            'async' => false
+            'async' => 'false'
         ]);
         $output = json_decode($execution['body']['responseBody'], true);
         $this->assertEquals(201, $execution['headers']['status-code']);
@@ -208,7 +208,7 @@ class FunctionsCustomClientTest extends Scope
 
         $execution = $this->createExecution($functionId, [
             'body' => 'foobar',
-            // Testing default value, should be 'async' => false
+            // Testing default value, should be 'async' => 'false'
         ]);
         $output = json_decode($execution['body']['responseBody'], true);
         $this->assertEquals(201, $execution['headers']['status-code']);
diff --git a/tests/e2e/Services/Functions/FunctionsCustomServerTest.php b/tests/e2e/Services/Functions/FunctionsCustomServerTest.php
index 14ec660c4b..2c3ddbcf58 100644
--- a/tests/e2e/Services/Functions/FunctionsCustomServerTest.php
+++ b/tests/e2e/Services/Functions/FunctionsCustomServerTest.php
@@ -463,7 +463,7 @@ class FunctionsCustomServerTest extends Scope
 
         $deployment = $this->createDeployment($functionId, [
             'code' => $this->packageFunction('php'),
-            'activate' => false
+            'activate' => 'false'
         ]);
 
         $this->assertEquals(202, $deployment['headers']['status-code']);
@@ -502,7 +502,7 @@ class FunctionsCustomServerTest extends Scope
 
         $deployment = $this->createDeployment($functionId, [
             'code' => $this->packageFunction('php'),
-            'activate' => false
+            'activate' => 'false'
         ]);
 
         $deploymentId = $deployment['body']['$id'] ?? '';
@@ -845,7 +845,7 @@ class FunctionsCustomServerTest extends Scope
          * Test for SUCCESS
          */
         $execution = $this->createExecution($data['functionId'], [
-            'async' => false,
+            'async' => 'false',
         ]);
 
         $this->assertEquals(201, $execution['headers']['status-code']);
@@ -870,7 +870,7 @@ class FunctionsCustomServerTest extends Scope
         $executionId = $execution['body']['$id'] ?? '';
 
         $execution = $this->createExecution($data['functionId'], [
-            'async' => false,
+            'async' => 'false',
             'path' => '/?code=400'
         ]);
 
@@ -965,7 +965,7 @@ class FunctionsCustomServerTest extends Scope
          * Test for SUCCESS
          */
         $execution = $this->createExecution($data['functionId'], [
-            // Testing default value, should be 'async' => false
+            // Testing default value, should be 'async' => 'false'
         ]);
 
         $this->assertEquals(201, $execution['headers']['status-code']);
@@ -1281,7 +1281,7 @@ class FunctionsCustomServerTest extends Scope
 
         $execution = $this->createExecution($functionId, [
             'body' => 'foobar',
-            'async' => false
+            'async' => 'false'
         ]);
 
         $output = json_decode($execution['body']['responseBody'], true);
@@ -1447,7 +1447,7 @@ class FunctionsCustomServerTest extends Scope
 
         $execution = $this->createExecution($functionId, [
             'body' => 'foobar',
-            'async' => false
+            'async' => 'false'
         ]);
 
         $output = json_decode($execution['body']['responseBody'], true);
@@ -1561,7 +1561,7 @@ class FunctionsCustomServerTest extends Scope
         $this->assertStringContainsStringIgnoringCase('"users":', $deployment['body']['buildLogs']);
 
         $execution = $this->createExecution($functionId, [
-            'async' => false,
+            'async' => 'false',
         ]);
 
         $this->assertEquals(201, $execution['headers']['status-code']);
@@ -1611,7 +1611,7 @@ class FunctionsCustomServerTest extends Scope
 
         $cookie = 'cookieName=cookieValue; cookie2=value2; cookie3=value=3; cookie4=val:ue4; cookie5=value5';
         $execution = $this->createExecution($functionId, [
-            'async' => false,
+            'async' => 'false',
             'headers' => [
                 'cookie' => $cookie
             ]
diff --git a/tests/e2e/Services/FunctionsSchedule/FunctionsScheduleTest.php b/tests/e2e/Services/FunctionsSchedule/FunctionsScheduleTest.php
index cbe54b6445..b1315103b1 100644
--- a/tests/e2e/Services/FunctionsSchedule/FunctionsScheduleTest.php
+++ b/tests/e2e/Services/FunctionsSchedule/FunctionsScheduleTest.php
@@ -143,7 +143,7 @@ class FunctionsScheduleTest extends Scope
         /* Test for FAILURE */
         // Schedule synchronous execution
         $execution = $this->createExecution($functionId, [
-            'async' => false,
+            'async' => 'false',
             'scheduledAt' =>  $futureTime->format(\DateTime::ATOM),
         ]);
         $this->assertEquals(400, $execution['headers']['status-code']);