From a38e90dcf4266a5a5c6e342e52c2dd00ba2d79e8 Mon Sep 17 00:00:00 2001 From: harsh mahajan Date: Wed, 2 Sep 2026 13:50:44 +0530 Subject: [PATCH] chore: ship the GitLab endpoint variables empty System::getEnv is getenv($name) ?: $default, so a set-but-empty variable falls through to the https://gitlab.com default the config already carries. Shipping the value blank keeps the sample env and a generated install free of a URL that only self-hosted GitLab needs to change, matching the Gitea endpoint entry. The effective default moves into the descriptions. --- .env | 4 ++-- app/config/variables.php | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.env b/.env index 7fe753006f..6fcb35a315 100644 --- a/.env +++ b/.env @@ -41,7 +41,7 @@ _APP_CONSOLE_GITHUB_APP_ID= _APP_CONSOLE_GITHUB_SECRET= _APP_CONSOLE_GITLAB_APP_ID= _APP_CONSOLE_GITLAB_SECRET= -_APP_CONSOLE_GITLAB_ENDPOINT=https://gitlab.com +_APP_CONSOLE_GITLAB_ENDPOINT= _APP_CONSOLE_BITBUCKET_APP_ID= _APP_CONSOLE_BITBUCKET_SECRET= _APP_CONSOLE_GOOGLE_APP_ID= @@ -182,7 +182,7 @@ _APP_VCS_GITEA_BROWSER_ENDPOINT=http://localhost:9515 _APP_VCS_GITEA_CLIENT_ID= _APP_VCS_GITEA_CLIENT_SECRET= _APP_VCS_GITEA_WEBHOOK_SECRET=gitea-webhook-secret -_APP_VCS_GITLAB_ENDPOINT=https://gitlab.com +_APP_VCS_GITLAB_ENDPOINT= _APP_VCS_GITLAB_CLIENT_ID= _APP_VCS_GITLAB_CLIENT_SECRET= _APP_VCS_GITLAB_WEBHOOK_SECRET= diff --git a/app/config/variables.php b/app/config/variables.php index 2580d0046c..4b69212e75 100644 --- a/app/config/variables.php +++ b/app/config/variables.php @@ -297,9 +297,9 @@ return [ ], [ 'name' => '_APP_CONSOLE_GITLAB_ENDPOINT', - 'description' => 'URL of the GitLab instance used for signing in to the Appwrite console, for self-hosted GitLab. This is separate from _APP_VCS_GITLAB_ENDPOINT, which powers repository integration rather than console sign-in.', + 'description' => 'URL of the GitLab instance used for signing in to the Appwrite console, for self-hosted GitLab. Defaults to https://gitlab.com when unset. This is separate from _APP_VCS_GITLAB_ENDPOINT, which powers repository integration rather than console sign-in.', 'introduction' => '2.0.0', - 'default' => 'https://gitlab.com', + 'default' => '', 'required' => false, 'question' => '', 'filter' => '' @@ -1583,9 +1583,9 @@ return [ ], [ 'name' => '_APP_VCS_GITLAB_ENDPOINT', - 'description' => 'URL of your self-hosted GitLab instance, reachable from the Appwrite server and the browser.', + 'description' => 'URL of your self-hosted GitLab instance, reachable from the Appwrite server and the browser. Defaults to https://gitlab.com when unset.', 'introduction' => '2.0.0', - 'default' => 'https://gitlab.com', + 'default' => '', 'required' => false, 'question' => '', 'filter' => ''