From 982340e7f01d86c1819723034900097a6dc7103e Mon Sep 17 00:00:00 2001 From: harsh mahajan Date: Tue, 25 Aug 2026 17:32:07 +0530 Subject: [PATCH] refactor: enable GitLab and Bitbucket unconditionally, matching GitHub The conditional !empty() guard was redundant for sign-in: account.php already rejects empty appId/secret with the same PROJECT_PROVIDER_DISABLED exception immediately after the Enabled check. Matches the adjacent githubEnabled line instead. --- app/config/console.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/config/console.php b/app/config/console.php index d8d0ec0b56..7ef52ec06c 100644 --- a/app/config/console.php +++ b/app/config/console.php @@ -59,10 +59,10 @@ $console = [ 'githubSecret' => System::getEnv('_APP_CONSOLE_GITHUB_SECRET', ''), 'githubAppid' => System::getEnv('_APP_CONSOLE_GITHUB_APP_ID', ''), // Distinct from _APP_VCS_*, which powers repository integration, not sign-in - 'gitlabEnabled' => !empty(System::getEnv('_APP_CONSOLE_GITLAB_APP_ID', '')), + 'gitlabEnabled' => true, 'gitlabSecret' => System::getEnv('_APP_CONSOLE_GITLAB_SECRET', ''), 'gitlabAppid' => System::getEnv('_APP_CONSOLE_GITLAB_APP_ID', ''), - 'bitbucketEnabled' => !empty(System::getEnv('_APP_CONSOLE_BITBUCKET_APP_ID', '')), + 'bitbucketEnabled' => true, 'bitbucketSecret' => System::getEnv('_APP_CONSOLE_BITBUCKET_SECRET', ''), 'bitbucketAppid' => System::getEnv('_APP_CONSOLE_BITBUCKET_APP_ID', ''), ],