Address review feedback: Remove redundant Realtime triggers, correctly reorder hydration, and add E2E tests

This commit is contained in:
bhardwajparth51 committed 2026-04-03 22:07:24 +05:30
1 parent ccc74dea74
commit 912ea37af6
7 files changed
+166 -12

No files matched your search

@@ -84,7 +84,6 @@ class Decrement extends Action
->inject('dbForProject')
->inject('getDatabasesDB')
->inject('queueForEvents')
->inject('queueForRealtime')
->inject('usage')
->inject('plan')
->inject('authorization')
@@ -92,7 +91,7 @@ class Decrement extends Action
->callback($this->action(...));
}
public function action(string $databaseId, string $collectionId, string $documentId, string $attribute, int|float $value, int|float|null $min, ?string $transactionId, UtopiaResponse $response, Database $dbForProject, callable $getDatabasesDB, Event $queueForEvents, Event $queueForRealtime, Context $usage, array $plan, Authorization $authorization, User $user): void
public function action(string $databaseId, string $collectionId, string $documentId, string $attribute, int|float $value, int|float|null $min, ?string $transactionId, UtopiaResponse $response, Database $dbForProject, callable $getDatabasesDB, Event $queueForEvents, Context $usage, array $plan, Authorization $authorization, User $user): void
{
$isAPIKey = $user->isApp($authorization->getRoles());
$isPrivilegedUser = $user->isPrivileged($authorization->getRoles());
@@ -219,7 +218,5 @@ class Decrement extends Action
->setContext('database', $database)
->setContext($this->getCollectionsEventsContext(), $collection)
->setPayload($response->getPayload(), sensitive: $relationships);
$queueForRealtime->from($queueForEvents)->trigger();
}
}
@@ -84,7 +84,6 @@ class Increment extends Action
->inject('dbForProject')
->inject('getDatabasesDB')
->inject('queueForEvents')
->inject('queueForRealtime')
->inject('usage')
->inject('plan')
->inject('authorization')
@@ -92,7 +91,7 @@ class Increment extends Action
->callback($this->action(...));
}
public function action(string $databaseId, string $collectionId, string $documentId, string $attribute, int|float $value, int|float|null $max, ?string $transactionId, UtopiaResponse $response, Database $dbForProject, callable $getDatabasesDB, Event $queueForEvents, Event $queueForRealtime, Context $usage, array $plan, Authorization $authorization, User $user): void
public function action(string $databaseId, string $collectionId, string $documentId, string $attribute, int|float $value, int|float|null $max, ?string $transactionId, UtopiaResponse $response, Database $dbForProject, callable $getDatabasesDB, Event $queueForEvents, Context $usage, array $plan, Authorization $authorization, User $user): void
{
$isAPIKey = $user->isApp($authorization->getRoles());
$isPrivilegedUser = $user->isPrivileged($authorization->getRoles());
@@ -219,7 +218,5 @@ class Increment extends Action
->setContext('database', $database)
->setContext($this->getCollectionsEventsContext(), $collection)
->setPayload($response->getPayload(), sensitive: $relationships);
$queueForRealtime->from($queueForEvents)->trigger();
}
}
@@ -65,7 +65,6 @@ class Decrement extends DecrementDocumentAttribute
->inject('dbForProject')
->inject('getDatabasesDB')
->inject('queueForEvents')
->inject('queueForRealtime')
->inject('usage')
->inject('plan')
->inject('authorization')
@@ -65,7 +65,6 @@ class Increment extends IncrementDocumentAttribute
->inject('dbForProject')
->inject('getDatabasesDB')
->inject('queueForEvents')
->inject('queueForRealtime')
->inject('usage')
->inject('plan')
->inject('authorization')
@@ -67,7 +67,6 @@ class Decrement extends DecrementDocumentAttribute
->inject('dbForProject')
->inject('getDatabasesDB')
->inject('queueForEvents')
->inject('queueForRealtime')
->inject('usage')
->inject('plan')
->inject('authorization')
@@ -67,7 +67,6 @@ class Increment extends IncrementDocumentAttribute
->inject('dbForProject')
->inject('getDatabasesDB')
->inject('queueForEvents')
->inject('queueForRealtime')
->inject('usage')
->inject('plan')
->inject('authorization')