Address PR comments

This commit is contained in:
Khushboo Verma
2025-01-08 13:55:21 +05:30
parent f196cfe993
commit 857046ecb8
7 changed files with 14 additions and 50 deletions
+1
View File
@@ -122,6 +122,7 @@ jobs:
Locale,
Projects,
Realtime,
Sites,
Storage,
Teams,
Users,
+1
View File
@@ -3,6 +3,7 @@
/node_modules/
/tests/resources/storage/
/tests/resources/functions/**/code.tar.gz
/tests/resources/sites/**/code.tar.gz
/app/sdks/*
/.idea/
!/.idea/workspace.xml
+1 -1
View File
@@ -155,7 +155,7 @@ trait SitesBase
protected function listLogs(string $siteId, mixed $params = []): mixed
{
$logs = $this->client->call(Client::METHOD_GET, '/sites/' . $siteId . '/executions', array_merge([
$logs = $this->client->call(Client::METHOD_GET, '/sites/' . $siteId . '/logs', array_merge([
'content-type' => 'application/json',
'x-appwrite-project' => $this->getProject()['$id'],
], $this->getHeaders()), $params);
@@ -23,14 +23,11 @@ class SitesCustomServerTest extends Scope
* Test for SUCCESS
*/
$site = $this->createSite([
'adapter' => 'static',
'buildRuntime' => 'node-22',
'fallbackFile' => null,
'framework' => 'other',
'name' => 'Test Site',
'outputDirectory' => './',
'providerBranch' => 'main',
'providerRootDirectory' => './',
'siteId' => ID::unique()
]);
@@ -43,12 +40,9 @@ class SitesCustomServerTest extends Scope
$this->assertEquals('other', $site['body']['framework']);
$this->assertEquals(true, $dateValidator->isValid($site['body']['$createdAt']));
$this->assertEquals(true, $dateValidator->isValid($site['body']['$updatedAt']));
$this->assertEquals('static', $site['body']['adapter']);
$this->assertEquals('node-22', $site['body']['buildRuntime']);
$this->assertEquals(null, $site['body']['fallbackFile']);
$this->assertEquals('./', $site['body']['outputDirectory']);
$this->assertEquals('main', $site['body']['providerBranch']);
$this->assertEquals('./', $site['body']['providerRootDirectory']);
$variable = $this->createVariable($siteId, [
'key' => 'siteKey1',
@@ -76,7 +70,6 @@ class SitesCustomServerTest extends Scope
* Test for SUCCESS
*/
$siteId = $this->setupSite([
'adapter' => 'static',
'buildRuntime' => 'node-22',
'fallbackFile' => null,
'framework' => 'other',
Binary file not shown.
-42
View File
@@ -1,42 +0,0 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Hello World</title>
<style>
body {
font-family: Arial, sans-serif;
display: flex;
justify-content: center;
align-items: center;
height: 100vh;
margin: 0;
background-color: #f0f0f0;
}
.container {
text-align: center;
padding: 20px;
background-color: white;
border-radius: 8px;
box-shadow: 0 2px 4px rgba(0, 0, 0, 0.1);
}
h1 {
color: #333;
margin-bottom: 10px;
}
p {
color: #666;
}
</style>
</head>
<body>
<div class="container">
<h1>Hello World!</h1>
<p>Welcome to my first Appwrite deployment</p>
</div>
</body>
</html>
+11
View File
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Hello Appwrite</title>
</head>
<body>
<h1>Hello Appwrite</h1>
</body>
</html>