Address benchmark review feedback

This commit is contained in:
Chirag Aggarwal
2026-04-21 16:10:08 +05:30
parent dcd01a8fb0
commit 83f182b444
2 changed files with 13 additions and 15 deletions
+8 -1
View File
@@ -704,13 +704,15 @@ jobs:
- name: Benchmark before
run: |
rm -f benchmark-before-summary.json benchmark-after-summary.json benchmark-before.txt benchmark.txt
docker run --rm -i --network host --user "$(id -u):$(id -g)" -v "$PWD:/scripts" -w /scripts grafana/k6 run --quiet \
docker run --rm -i --network host --user "$(id -u):$(id -g)" -v "/tmp/appwrite-benchmark-before:/scripts" -w /scripts grafana/k6 run --quiet \
--summary-export benchmark-before-summary.json \
-e APPWRITE_ENDPOINT=http://localhost/v1 \
-e APPWRITE_MAILDEV_ENDPOINT=http://localhost:9503/email \
-e APPWRITE_BENCHMARK_ITERATIONS=1 \
-e APPWRITE_BENCHMARK_VUS=1 \
-e APPWRITE_BENCHMARK_SUMMARY_PATH=benchmark-before-summary.json \
tests/benchmarks/http.js | tee benchmark-before.txt
cp /tmp/appwrite-benchmark-before/benchmark-before-summary.json benchmark-before-summary.json
- name: Stop before Appwrite
if: always()
@@ -733,9 +735,14 @@ jobs:
-e APPWRITE_MAILDEV_ENDPOINT=http://localhost:9503/email \
-e APPWRITE_BENCHMARK_ITERATIONS=1 \
-e APPWRITE_BENCHMARK_VUS=1 \
-e APPWRITE_BENCHMARK_PREVIOUS_SUMMARY_PATH=/scripts/benchmark-before-summary.json \
-e APPWRITE_BENCHMARK_SUMMARY_PATH=benchmark-after-summary.json \
tests/benchmarks/http.js | tee benchmark.txt
- name: Stop after Appwrite
if: always()
run: docker compose down -v
- name: Prepare comment
run: |
node <<'NODE' > benchmark-comment.txt