From 82f734f274a1afbeaab2758dde997aefcc423fc6 Mon Sep 17 00:00:00 2001 From: Hemachandar Date: Tue, 24 Mar 2026 17:39:05 +0530 Subject: [PATCH] test refactor --- tests/unit/Network/Validators/DNSTest.php | 27 ++++++++++++++--------- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/tests/unit/Network/Validators/DNSTest.php b/tests/unit/Network/Validators/DNSTest.php index 0dc28da273..d28b07643f 100644 --- a/tests/unit/Network/Validators/DNSTest.php +++ b/tests/unit/Network/Validators/DNSTest.php @@ -8,36 +8,41 @@ use Utopia\DNS\Message\Record; class DNSTest extends TestCase { + private function runInCoroutine(callable $test): void + { + \Swoole\Coroutine\run($test); + } + public function testSingleDNSServer(): void { - \Swoole\Coroutine\run(function () { + $this->runInCoroutine(function () { $validator = new DNS('appwrite.io', Record::TYPE_CNAME, ['8.8.8.8']); - $this->assertEquals(false, $validator->isValid('')); - $this->assertEquals(false, $validator->isValid(null)); + $this->assertFalse($validator->isValid('')); + $this->assertFalse($validator->isValid(null)); $this->assertEquals('string', $validator->getType()); }); } public function testMultipleDNSServers(): void { - \Swoole\Coroutine\run(function () { + $this->runInCoroutine(function () { $validator = new DNS('appwrite.io', Record::TYPE_CNAME, ['8.8.8.8', '1.1.1.1']); - $this->assertEquals(false, $validator->isValid('')); - $this->assertEquals(false, $validator->isValid(null)); + $this->assertFalse($validator->isValid('')); + $this->assertFalse($validator->isValid(null)); $this->assertEquals('string', $validator->getType()); }); } public function testValidationFailure(): void { - \Swoole\Coroutine\run(function () { + $this->runInCoroutine(function () { $validator = new DNS('invalid-target.example.com', Record::TYPE_CNAME, ['8.8.8.8', '1.1.1.1']); $result = $validator->isValid('nonexistent-domain-' . \uniqid() . '.com'); - $this->assertEquals(false, $result); + $this->assertFalse($result); $this->assertIsInt($validator->count); $this->assertIsString($validator->value); $this->assertIsArray($validator->records); @@ -47,15 +52,15 @@ class DNSTest extends TestCase public function testCoreDNSFailure(): void { - \Swoole\Coroutine\run(function () { + $this->runInCoroutine(function () { // CoreDNS is configured to return cname.localhost. for stage.webapp.com $validator = new DNS('cname.localhost.', Record::TYPE_CNAME, ['172.16.238.100', '8.8.8.8']); $result = $validator->isValid('stage.webapp.com'); - $this->assertEquals(false, $result); + $this->assertFalse($result); $result = $validator->isValid('stage-wrong-cname.webapp.com'); - $this->assertEquals(false, $result); + $this->assertFalse($result); }); } }