fix: address review feedback for installer PR

- Initialize $isUpgrade=false in Install.php action() to prevent undefined variable
- Assign $this->lockedDatabase in Upgrade.php before calling parent::action()
- Remove stack trace exposure from buildErrorDetails() in Http Install action
- Suppress raw exception messages for 500+ errors in Error handler
- Remove sessionSecret from progress details to prevent credential leak
- Hash name/email in analytics payload to avoid sending raw PII
- Validate and default dbService in compose.phtml to prevent invalid output
- Fix host normalization in progress.js redirect URL builder
- Release global lock on early return for existing installation conflict
- Consolidate duplicate database host/port assignment blocks
- Add @runInSeparateProcess to testRouteRegistration to prevent global state leak

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Jake Barnby
2026-02-27 01:44:46 +13:00
co-authored by Claude Opus 4.6
parent f8d8997ae3
commit 7a27cf4ac7
7 changed files with 19 additions and 19 deletions
@@ -112,6 +112,9 @@ class ModuleTest extends TestCase
$this->assertActionInjects($action, ['error', 'response']);
}
/**
* @runInSeparateProcess
*/
public function testRouteRegistration(): void
{
$services = $this->module->getServicesByType(Service::TYPE_HTTP);