From 74abf4897b769ca6562fd3e856b98c7785d275a2 Mon Sep 17 00:00:00 2001
From: Chirag Aggarwal <chiragaggarwal5k@gmail.com>
Date: Mon, 14 Apr 2025 08:47:57 +0000
Subject: [PATCH] chore: fix teamCreateMembership

---
 app/controllers/api/teams.php                 |  1 +
 tests/e2e/Services/Teams/TeamsBaseClient.php  | 12 ----------
 .../Services/Teams/TeamsConsoleClientTest.php | 24 +++++++++++++++++++
 3 files changed, 25 insertions(+), 12 deletions(-)

diff --git a/app/controllers/api/teams.php b/app/controllers/api/teams.php
index ef589233f2..f58be39857 100644
--- a/app/controllers/api/teams.php
+++ b/app/controllers/api/teams.php
@@ -51,6 +51,7 @@ use Utopia\Validator\ArrayList;
 use Utopia\Validator\Assoc;
 use Utopia\Validator\Host;
 use Utopia\Validator\Text;
+use Utopia\Validator\URL;
 use Utopia\Validator\WhiteList;
 
 App::post('/v1/teams')
diff --git a/tests/e2e/Services/Teams/TeamsBaseClient.php b/tests/e2e/Services/Teams/TeamsBaseClient.php
index 3fcd9c043d..1858fd50ad 100644
--- a/tests/e2e/Services/Teams/TeamsBaseClient.php
+++ b/tests/e2e/Services/Teams/TeamsBaseClient.php
@@ -337,18 +337,6 @@ trait TeamsBaseClient
 
         $this->assertEquals(400, $response['headers']['status-code']);
 
-        $response = $this->client->call(Client::METHOD_POST, '/teams/' . $teamUid . '/memberships', array_merge([
-            'content-type' => 'application/json',
-            'x-appwrite-project' => $this->getProject()['$id'],
-        ], $this->getHeaders()), [
-            'email' => $email,
-            'name' => $name,
-            'roles' => ['developer'],
-            'url' => 'http://example.com/join-us#title' // bad url
-        ]);
-
-        $this->assertEquals(400, $response['headers']['status-code']);
-
         return [
             'teamUid' => $teamUid,
             'teamName' => $teamName,
diff --git a/tests/e2e/Services/Teams/TeamsConsoleClientTest.php b/tests/e2e/Services/Teams/TeamsConsoleClientTest.php
index 4b5ade7cbf..dec61d5258 100644
--- a/tests/e2e/Services/Teams/TeamsConsoleClientTest.php
+++ b/tests/e2e/Services/Teams/TeamsConsoleClientTest.php
@@ -14,6 +14,30 @@ class TeamsConsoleClientTest extends Scope
     use ProjectConsole;
     use SideClient;
 
+    /**
+     * @depends testCreateTeam
+     */
+    public function testTeamCreateMembershipConsole($data): array
+    {
+        $teamUid = $data['teamUid'] ?? '';
+        $email = uniqid() . 'friend@localhost.test';
+        $name = 'Friend User';
+
+        $response = $this->client->call(Client::METHOD_POST, '/teams/' . $teamUid . '/memberships', array_merge([
+            'content-type' => 'application/json',
+            'x-appwrite-project' => $this->getProject()['$id'],
+        ], $this->getHeaders()), [
+            'email' => $email,
+            'name' => $name,
+            'roles' => ['developer'],
+            'url' => 'http://example.com/join-us#title' // bad url
+        ]);
+
+        $this->assertEquals(400, $response['headers']['status-code']);
+
+        return $data;
+    }
+
     /**
      * @depends testCreateTeam
      */