From 7498c330eb4e7d92b698313a5aa7848ce2aec912 Mon Sep 17 00:00:00 2001 From: Jake Barnby Date: Thu, 15 Jan 2026 18:18:55 +1300 Subject: [PATCH] Add missing PHPUnit #[Depends] to Functions, Messaging, Webhooks tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixed missing #[Depends] attributes: - FunctionsCustomServerTest: testCancelDeploymentBuild → testCreateDeployment - MessagingBase: testDeleteMessage → testSendEmail - WebhooksBase: testDeleteDocument → testUpdateDocument, testDeleteRow → testUpdateRow - WebhooksCustomClientTest: testUpdateAccountName → testDeleteAccountSessions Co-Authored-By: Claude Opus 4.5 --- tests/e2e/Services/Functions/FunctionsCustomServerTest.php | 3 +-- tests/e2e/Services/Messaging/MessagingBase.php | 1 + tests/e2e/Services/Webhooks/WebhooksBase.php | 6 ++---- tests/e2e/Services/Webhooks/WebhooksCustomClientTest.php | 3 +-- 4 files changed, 5 insertions(+), 8 deletions(-) diff --git a/tests/e2e/Services/Functions/FunctionsCustomServerTest.php b/tests/e2e/Services/Functions/FunctionsCustomServerTest.php index 818c772434..3d79e3ba4e 100644 --- a/tests/e2e/Services/Functions/FunctionsCustomServerTest.php +++ b/tests/e2e/Services/Functions/FunctionsCustomServerTest.php @@ -707,9 +707,8 @@ class FunctionsCustomServerTest extends Scope return array_merge($data, ['deploymentId' => $deploymentIdActive]); } - /** - */ #[Retry(count: 3)] + #[Depends('testCreateDeployment')] public function testCancelDeploymentBuild($data): void { $functionId = $data['functionId']; diff --git a/tests/e2e/Services/Messaging/MessagingBase.php b/tests/e2e/Services/Messaging/MessagingBase.php index 0227450fc6..65aa84f30c 100644 --- a/tests/e2e/Services/Messaging/MessagingBase.php +++ b/tests/e2e/Services/Messaging/MessagingBase.php @@ -1743,6 +1743,7 @@ trait MessagingBase * @return void * @throws \Exception */ + #[Depends('testSendEmail')] public function testDeleteMessage(array $params): void { $message = $params['message']; diff --git a/tests/e2e/Services/Webhooks/WebhooksBase.php b/tests/e2e/Services/Webhooks/WebhooksBase.php index b29c721c75..d9445b678c 100644 --- a/tests/e2e/Services/Webhooks/WebhooksBase.php +++ b/tests/e2e/Services/Webhooks/WebhooksBase.php @@ -314,9 +314,8 @@ trait WebhooksBase return $data; } - /** - */ #[Retry(count: 1)] + #[Depends('testUpdateDocument')] public function testDeleteDocument(array $data): array { $actorsId = $data['actorsId']; @@ -658,9 +657,8 @@ trait WebhooksBase return $data; } - /** - */ #[Retry(count: 1)] + #[Depends('testUpdateRow')] public function testDeleteRow(array $data): array { $actorsId = $data['actorsId']; diff --git a/tests/e2e/Services/Webhooks/WebhooksCustomClientTest.php b/tests/e2e/Services/Webhooks/WebhooksCustomClientTest.php index 91cca30a3b..79f6e3e373 100644 --- a/tests/e2e/Services/Webhooks/WebhooksCustomClientTest.php +++ b/tests/e2e/Services/Webhooks/WebhooksCustomClientTest.php @@ -406,9 +406,8 @@ class WebhooksCustomClientTest extends Scope ]); } - /** - */ #[Retry(count: 1)] + #[Depends('testDeleteAccountSessions')] public function testUpdateAccountName($data): array { $id = $data['id'] ?? '';