AI-recommended changes

.github/workflows/cleanup-cache.yml

@@ -10,7 +10,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Check out code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         
       - name: Cleanup
         run: |

.github/workflows/codeql-analysis.yml

@@ -34,7 +34,7 @@ jobs:
 
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         # We must fetch at least the immediate parents so that if this is
         # a pull request then we can checkout the head.

.github/workflows/linter.yml

@@ -12,7 +12,7 @@ jobs:
 
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         fetch-depth: 2
 

.github/workflows/publish.yml

@@ -12,7 +12,7 @@ jobs:
 
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         fetch-depth: 2
         submodules: recursive

.github/workflows/release.yml

@@ -11,7 +11,7 @@ jobs:
 
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         # We must fetch at least the immediate parents so that if this is
         # a pull request then we can checkout the head.

.github/workflows/static-analysis.yml

@@ -8,7 +8,7 @@ jobs:
 
     steps:
     - name: Check out the repo
-      uses: actions/checkout@v2
+      uses: actions/checkout@v4
 
     - name: Run CodeQL
       run: |

app/views/install/compose.phtml

@@ -867,7 +867,7 @@ $image = $this->getParam('image', '');
     <<: *x-logging
     restart: unless-stopped
     stop_signal: SIGINT
-    image: openruntimes/executor:0.7.0
+    image: openruntimes/executor:0.7.13
     networks:
       - appwrite
       - runtimes

app/worker.php

@@ -396,7 +396,7 @@ Server::setResource('logError', function (Registry $register, Document $project)
             $log->addExtra('trace', $error->getTraceAsString());
 
 
-            foreach ($extras as $key => $value) {
+            foreach (($extras ?? []) as $key => $value) {
                 $log->addExtra($key, $value);
             }
 

src/Appwrite/Platform/Modules/Functions/Http/Deployments/Get.php

@@ -65,11 +65,11 @@ class Get extends Action
 
         $deployment = $dbForProject->getDocument('deployments', $deploymentId);
 
-        if ($deployment->getAttribute('resourceId') !== $function->getId()) {
+        if ($deployment->isEmpty()) {
             throw new Exception(Exception::DEPLOYMENT_NOT_FOUND);
         }
 
-        if ($deployment->isEmpty()) {
+        if ($deployment->getAttribute('resourceId') !== $function->getId()) {
             throw new Exception(Exception::DEPLOYMENT_NOT_FOUND);
         }
 

src/Appwrite/Platform/Modules/Functions/Http/Deployments/Status/Update.php

@@ -86,7 +86,7 @@ class Update extends Action
             throw new Exception(Exception::BUILD_ALREADY_COMPLETED);
         }
 
-        $startTime = new \DateTime($deployment->getAttribute('buildStartAt'));
+        $startTime = new \DateTime($deployment->getAttribute('buildStartAt', 'now'));
         $endTime = new \DateTime('now');
         $duration = $endTime->getTimestamp() - $startTime->getTimestamp();
 

src/Appwrite/Platform/Modules/Functions/Http/Executions/Get.php

@@ -71,7 +71,7 @@ class Get extends Base
 
         $execution = $dbForProject->getDocument('executions', $executionId);
 
-        if ($execution->getAttribute('resourceType') !== 'functions' && $execution->getAttribute('resourceInternalId') !== $function->getInternalId()) {
+        if ($execution->getAttribute('resourceType') !== 'functions' || $execution->getAttribute('resourceInternalId') !== $function->getInternalId()) {
             throw new Exception(Exception::EXECUTION_NOT_FOUND);
         }
 

src/Appwrite/Platform/Modules/Functions/Http/Templates/XList.php

@@ -75,10 +75,11 @@ class XList extends Base
             return $b['score'] <=> $a['score'];
         });
 
+        $total = \count($templates);
         $templates = \array_slice($templates, $offset, $limit);
         $response->dynamic(new Document([
             'templates' => $templates,
-            'total' => \count($templates),
+            'total' => $total,
         ]), Response::MODEL_TEMPLATE_FUNCTION_LIST);
     }
 }

src/Appwrite/Platform/Modules/Functions/Http/Variables/Update.php

@@ -84,10 +84,6 @@ class Update extends Base
             throw new Exception(Exception::VARIABLE_NOT_FOUND);
         }
 
-        if ($variable === false || $variable->isEmpty()) {
-            throw new Exception(Exception::VARIABLE_NOT_FOUND);
-        }
-
         if ($variable->getAttribute('secret') === true && $secret === false) {
             throw new Exception(Exception::VARIABLE_CANNOT_UNSET_SECRET);
         }

src/Appwrite/Platform/Modules/Sites/Http/Deployments/Get.php

@@ -61,11 +61,11 @@ class Get extends Action
 
         $deployment = $dbForProject->getDocument('deployments', $deploymentId);
 
-        if ($deployment->getAttribute('resourceId') !== $site->getId()) {
+        if ($deployment->isEmpty()) {
             throw new Exception(Exception::DEPLOYMENT_NOT_FOUND);
         }
-
-        if ($deployment->isEmpty()) {
+        
+        if ($deployment->getAttribute('resourceId') !== $site->getId()) {
             throw new Exception(Exception::DEPLOYMENT_NOT_FOUND);
         }
 

src/Appwrite/Platform/Modules/Sites/Http/Deployments/Status/Update.php

@@ -84,7 +84,7 @@ class Update extends Action
             throw new Exception(Exception::BUILD_ALREADY_COMPLETED);
         }
 
-        $startTime = new \DateTime($deployment->getAttribute('buildStartAt'));
+        $startTime = new \DateTime($deployment->getAttribute('buildStartAt', 'now'));
         $endTime = new \DateTime('now');
         $duration = $endTime->getTimestamp() - $startTime->getTimestamp();
 

src/Appwrite/Platform/Modules/Sites/Http/Templates/XList.php

@@ -80,11 +80,11 @@ class XList extends Base
             return $b['score'] <=> $a['score'];
         });
 
+        $total = \count($templates);
         $templates = \array_slice($templates, $offset, $limit);
-
         $response->dynamic(new Document([
             'templates' => $templates,
-            'total' => \count($templates),
+            'total' => $total,
         ]), Response::MODEL_TEMPLATE_SITE_LIST);
     }
 }

src/Appwrite/Platform/Modules/Sites/Http/Variables/Update.php

@@ -80,10 +80,6 @@ class Update extends Base
             throw new Exception(Exception::VARIABLE_NOT_FOUND);
         }
 
-        if ($variable === false || $variable->isEmpty()) {
-            throw new Exception(Exception::VARIABLE_NOT_FOUND);
-        }
-
         if ($variable->getAttribute('secret') === true && $secret === false) {
             throw new Exception(Exception::VARIABLE_CANNOT_UNSET_SECRET);
         }