From 6a41f8b2b9d587eb6ae381c88f90faed6be0d41f Mon Sep 17 00:00:00 2001 From: fogelito Date: Sun, 2 Nov 2025 11:16:12 +0200 Subject: [PATCH] Remove todos --- app/controllers/api/account.php | 8 ++++---- app/controllers/api/teams.php | 4 ++-- app/controllers/api/users.php | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/app/controllers/api/account.php b/app/controllers/api/account.php index e54dd3ef42..00b4c619d7 100644 --- a/app/controllers/api/account.php +++ b/app/controllers/api/account.php @@ -412,8 +412,8 @@ App::post('/v1/account') 'emailCanonical' => $emailCanonical?->getCanonical(), 'emailIsCanonical' => $emailCanonical?->isCanonicalSupported(), 'emailIsCorporate' => $emailCanonical?->isCorporate(), - 'emailIsDisposable' => $emailCanonical?->isDisposable(), // todo: fix throw - 'emailIsFree' => $emailCanonical?->isFree(), // todo: fix throw + 'emailIsDisposable' => $emailCanonical?->isDisposable(), + 'emailIsFree' => $emailCanonical?->isFree(), ]); $user->removeAttribute('$sequence'); @@ -2275,8 +2275,8 @@ App::post('/v1/account/tokens/email') 'emailCanonical' => $emailCanonical?->getCanonical(), 'emailIsCanonical' => $emailCanonical?->isCanonicalSupported(), 'emailIsCorporate' => $emailCanonical?->isCorporate(), - 'emailIsDisposable' => $emailCanonical?->isDisposable(), // todo: fix throw - 'emailIsFree' => $emailCanonical?->isFree(), // todo: fix throw + 'emailIsDisposable' => $emailCanonical?->isDisposable(), + 'emailIsFree' => $emailCanonical?->isFree(), ]); $user->removeAttribute('$sequence'); diff --git a/app/controllers/api/teams.php b/app/controllers/api/teams.php index 7fbf4e2d38..3a9908ffe3 100644 --- a/app/controllers/api/teams.php +++ b/app/controllers/api/teams.php @@ -606,8 +606,8 @@ App::post('/v1/teams/:teamId/memberships') 'emailCanonical' => $emailCanonical?->getCanonical(), 'emailIsCanonical' => $emailCanonical?->isCanonicalSupported(), 'emailIsCorporate' => $emailCanonical?->isCorporate(), - 'emailIsDisposable' => $emailCanonical?->isDisposable(), // todo: fix throw - 'emailIsFree' => $emailCanonical?->isFree(), // todo: fix throw + 'emailIsDisposable' => $emailCanonical?->isDisposable(), + 'emailIsFree' => $emailCanonical?->isFree(), ]); try { diff --git a/app/controllers/api/users.php b/app/controllers/api/users.php index dccfec1101..d88148b5a1 100644 --- a/app/controllers/api/users.php +++ b/app/controllers/api/users.php @@ -134,8 +134,8 @@ function createUser(string $hash, mixed $hashOptions, string $userId, ?string $e 'emailCanonical' => $emailCanonical?->getCanonical(), 'emailIsCanonical' => $emailCanonical?->isCanonicalSupported(), 'emailIsCorporate' => $emailCanonical?->isCorporate(), - 'emailIsDisposable' => $emailCanonical?->isDisposable(), // todo: fix throw - 'emailIsFree' => $emailCanonical?->isFree(), // todo: fix throw + 'emailIsDisposable' => $emailCanonical?->isDisposable(), + 'emailIsFree' => $emailCanonical?->isFree(), ]); if ($hash === 'plaintext') {