From 6319d961ebca5b151b84ae72f04b0a52049683ca Mon Sep 17 00:00:00 2001 From: Jake Barnby Date: Fri, 13 Mar 2026 00:32:42 +1300 Subject: [PATCH] (refactor): Simplify installer progress completion flow --- .../install/installer/js/modules/progress.js | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/app/views/install/installer/js/modules/progress.js b/app/views/install/installer/js/modules/progress.js index 1ebf8ec6ae..5aa72928d0 100644 --- a/app/views/install/installer/js/modules/progress.js +++ b/app/views/install/installer/js/modules/progress.js @@ -599,8 +599,9 @@ }); if (!allDone) return; const accountState = progressState.get(STEP_IDS.ACCOUNT_SETUP); + const sessionDetails = accountState?.details; finalizeInstall(); - notifyInstallComplete(activeInstall?.installId, accountState?.details).finally(() => { + notifyInstallComplete(activeInstall?.installId, sessionDetails).finally(() => { setTimeout(() => redirectToApp(), TIMINGS?.redirectDelay ?? 0); }); }; @@ -725,21 +726,7 @@ renderProgress(); const accountState = progressState.get(STEP_IDS.ACCOUNT_SETUP); - const accountRequired = INSTALLATION_STEPS.some((step) => step.id === STEP_IDS.ACCOUNT_SETUP); - if (accountRequired && accountState?.status === STATUS.ERROR) { - finalizeInstall(); - return; - } const sessionDetails = accountState?.details; - if (accountRequired && !(sessionDetails?.sessionSecret || sessionDetails?.secret)) { - handleProgress({ - step: STEP_IDS.ACCOUNT_SETUP, - status: STATUS.ERROR, - message: 'Account creation did not complete. Please retry.' - }); - finalizeInstall(); - return; - } finalizeInstall(); notifyInstallComplete(activeInstall?.installId, sessionDetails).finally(() => { setTimeout(() => redirectToApp(), TIMINGS?.redirectDelay ?? 0);