From 62cf3f303b7b59520e77799647743c84f6500a9e Mon Sep 17 00:00:00 2001 From: Chirag Aggarwal Date: Mon, 22 Jun 2026 14:26:45 +0530 Subject: [PATCH] Fix project OAuth provider sparse update (#12646) --- app/controllers/api/projects.php | 34 ++++++++++++++++++-------------- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/app/controllers/api/projects.php b/app/controllers/api/projects.php index 8ab30fac99..a39ce3c4bd 100644 --- a/app/controllers/api/projects.php +++ b/app/controllers/api/projects.php @@ -38,27 +38,31 @@ Http::patch('/v1/projects/:projectId/oauth2') ->inject('dbForPlatform') ->action(function (string $projectId, string $provider, ?string $appId, ?string $secret, ?bool $enabled, Response $response, Database $dbForPlatform) { - $project = $dbForPlatform->getDocument('projects', $projectId); + $project = $dbForPlatform->withTransaction(function () use ($dbForPlatform, $projectId, $provider, $appId, $secret, $enabled) { + $project = $dbForPlatform->getDocument('projects', $projectId, forUpdate: true); - if ($project->isEmpty()) { - throw new Exception(Exception::PROJECT_NOT_FOUND); - } + if ($project->isEmpty()) { + throw new Exception(Exception::PROJECT_NOT_FOUND); + } - $providers = $project->getAttribute('oAuthProviders', []); + $providers = $project->getAttribute('oAuthProviders', []); - if ($appId !== null) { - $providers[$provider . 'Appid'] = $appId; - } + if ($appId !== null) { + $providers[$provider . 'Appid'] = $appId; + } - if ($secret !== null) { - $providers[$provider . 'Secret'] = $secret; - } + if ($secret !== null) { + $providers[$provider . 'Secret'] = $secret; + } - if ($enabled !== null) { - $providers[$provider . 'Enabled'] = $enabled; - } + if ($enabled !== null) { + $providers[$provider . 'Enabled'] = $enabled; + } - $project = $dbForPlatform->updateDocument('projects', $project->getId(), $project->setAttribute('oAuthProviders', $providers)); + return $dbForPlatform->updateDocument('projects', $project->getId(), new Document([ + 'oAuthProviders' => $providers, + ])); + }); $response->dynamic($project, Response::MODEL_PROJECT); });