From 5f5d9b4fcb1fd9cbbe4e2be9414147e5b3d40e34 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matej=20Ba=C4=8Do?= Date: Mon, 29 Dec 2025 09:04:47 +0100 Subject: [PATCH] Add async key cleanup --- app/controllers/api/teams.php | 12 +++++++-- app/init/constants.php | 1 + src/Appwrite/Platform/Workers/Deletes.php | 30 +++++++++++++++++++++++ 3 files changed, 41 insertions(+), 2 deletions(-) diff --git a/app/controllers/api/teams.php b/app/controllers/api/teams.php index 8771588d3a..661e99ef1b 100644 --- a/app/controllers/api/teams.php +++ b/app/controllers/api/teams.php @@ -431,15 +431,23 @@ App::delete('/v1/teams/:teamId') throw new Exception(Exception::GENERAL_SERVER_ERROR, 'Failed to remove team from DB'); } + $clone = clone $team; + + // Sync delete $deletes = new Deletes(); - $deletes->deleteMemberships($getProjectDB, $team, $project); + $deletes->deleteMemberships($getProjectDB, $clone, $project); if ($project->getId() === 'console') { $queueForDeletes ->setType(DELETE_TYPE_TEAM_PROJECTS) - ->setDocument($team); + ->setDocument($clone); } + // Async delete + $queueForDeletes + ->setType(DELETE_TYPE_DOCUMENT) + ->setDocument($clone); + $queueForEvents ->setParam('teamId', $team->getId()) ->setPayload($response->output($team, Response::MODEL_TEAM)) diff --git a/app/init/constants.php b/app/init/constants.php index 3a8eb72e62..b27c681bcd 100644 --- a/app/init/constants.php +++ b/app/init/constants.php @@ -189,6 +189,7 @@ const DELETE_TYPE_SITES = 'sites'; const DELETE_TYPE_FUNCTIONS = 'functions'; const DELETE_TYPE_DEPLOYMENTS = 'deployments'; const DELETE_TYPE_USERS = 'users'; +const DELETE_TYPE_TEAMS = 'teams'; const DELETE_TYPE_TEAM_PROJECTS = 'teams_projects'; const DELETE_TYPE_EXECUTIONS = 'executions'; const DELETE_TYPE_AUDIT = 'audit'; diff --git a/src/Appwrite/Platform/Workers/Deletes.php b/src/Appwrite/Platform/Workers/Deletes.php index 5cd2402783..2f9ecaeee1 100644 --- a/src/Appwrite/Platform/Workers/Deletes.php +++ b/src/Appwrite/Platform/Workers/Deletes.php @@ -120,6 +120,9 @@ class Deletes extends Action case DELETE_TYPE_USERS: $this->deleteUser($getProjectDB, $document, $project); break; + case DELETE_TYPE_TEAMS: + $this->deleteTeam($getProjectDB, $document, $project); + break; case DELETE_TYPE_BUCKETS: $this->deleteBucket($getProjectDB, $deviceForFiles, $document, $project); break; @@ -634,6 +637,24 @@ class Deletes extends Action $deviceForCache->delete($deviceForCache->getRoot(), true); } + private function deleteTeam(callable $getProjectDB, Document $document, Document $project): void + { + $teamId = $document->getId(); + $teamInternalId = $document->getSequence(); + $dbForProject = $getProjectDB($project); + + if ($project->getId() === 'console') { + // Delete Keys + $this->deleteByGroup('keys', [ + Query::equal('resourceInternalId', [$teamInternalId]), + Query::equal('resourceType', ['teams']), + Query::orderAsc() + ], $dbForProject); + } + + $dbForProject->purgeCachedDocument('teams', $teamId); + } + /** * @param callable $getProjectDB * @param Document $document user document @@ -653,6 +674,15 @@ class Deletes extends Action Query::orderAsc() ], $dbForProject); + if ($project->getId() === 'console') { + // Delete Keys + $this->deleteByGroup('keys', [ + Query::equal('resourceInternalId', [$userInternalId]), + Query::equal('resourceType', ['users']), + Query::orderAsc() + ], $dbForProject); + } + $dbForProject->purgeCachedDocument('users', $userId); // Delete Memberships and decrement team membership counts