From 5f29af2c271d63f1320d84cfb2384d4fc01a1bd3 Mon Sep 17 00:00:00 2001
From: Christy Jacob <christyjacob4@gmail.com>
Date: Fri, 8 Nov 2024 22:08:13 +0100
Subject: [PATCH] feat: use getDocument instead of find() for rules

---
 app/controllers/api/functions.php              |  2 +-
 app/controllers/api/proxy.php                  |  2 +-
 app/controllers/general.php                    | 11 ++++-------
 src/Appwrite/Migration/Version/V19.php         |  1 +
 src/Appwrite/Platform/Workers/Certificates.php |  4 +---
 5 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/app/controllers/api/functions.php b/app/controllers/api/functions.php
index 0ca73ee6ac..2309defe5a 100644
--- a/app/controllers/api/functions.php
+++ b/app/controllers/api/functions.php
@@ -326,9 +326,9 @@ App::post('/v1/functions')
 
         $functionsDomain = System::getEnv('_APP_DOMAIN_FUNCTIONS', '');
         if (!empty($functionsDomain)) {
-            $ruleId = ID::unique();
             $routeSubdomain = ID::unique();
             $domain = "{$routeSubdomain}.{$functionsDomain}";
+            $ruleId = md5($domain);
 
             $rule = Authorization::skip(
                 fn () => $dbForConsole->createDocument('rules', new Document([
diff --git a/app/controllers/api/proxy.php b/app/controllers/api/proxy.php
index 02a3ec8e9d..9860bd8276 100644
--- a/app/controllers/api/proxy.php
+++ b/app/controllers/api/proxy.php
@@ -103,7 +103,7 @@ App::post('/v1/proxy/rules')
             throw new Exception(Exception::GENERAL_ARGUMENT_INVALID, 'Domain may not start with http:// or https://.');
         }
 
-        $ruleId = ID::unique();
+        $ruleId = md5($domain->get());
         $rule = new Document([
             '$id' => $ruleId,
             'projectId' => $project->getId(),
diff --git a/app/controllers/general.php b/app/controllers/general.php
index b08ecb3d12..908ffdcb71 100644
--- a/app/controllers/general.php
+++ b/app/controllers/general.php
@@ -52,14 +52,10 @@ function router(App $utopia, Database $dbForConsole, callable $getProjectDB, Swo
 
     $host = $request->getHostname() ?? '';
 
-    $route = Authorization::skip(
-        fn () => $dbForConsole->find('rules', [
-            Query::equal('domain', [$host]),
-            Query::limit(1)
-        ])
-    )[0] ?? null;
+    $ruleId = md5($host);
+    $route = Authorization::skip(fn () => $dbForConsole->getDocument('rules', $ruleId));
 
-    if ($route === null) {
+    if ($route->isEmpty()) {
         if ($host === System::getEnv('_APP_DOMAIN_FUNCTIONS', '')) {
             throw new AppwriteException(AppwriteException::GENERAL_ACCESS_FORBIDDEN, 'This domain cannot be used for security reasons. Please use any subdomain instead.');
         }
@@ -531,6 +527,7 @@ App::init()
 
                     if ($domainDocument->isEmpty()) {
                         $domainDocument = new Document([
+                            '$id' => md5($domain->get()),
                             'domain' => $domain->get(),
                             'resourceType' => 'api',
                             'status' => 'verifying',
diff --git a/src/Appwrite/Migration/Version/V19.php b/src/Appwrite/Migration/Version/V19.php
index 18234ebdc4..2546ae9baf 100644
--- a/src/Appwrite/Migration/Version/V19.php
+++ b/src/Appwrite/Migration/Version/V19.php
@@ -72,6 +72,7 @@ class V19 extends Migration
                 }
 
                 $ruleDocument = new Document([
+                    '$id' => md5($domain->getAttribute('domain')),
                     'projectId' => $domain->getAttribute('projectId'),
                     'projectInternalId' => $domain->getAttribute('projectInternalId'),
                     'domain' => $domain->getAttribute('domain'),
diff --git a/src/Appwrite/Platform/Workers/Certificates.php b/src/Appwrite/Platform/Workers/Certificates.php
index a14f164295..21d967d9e1 100644
--- a/src/Appwrite/Platform/Workers/Certificates.php
+++ b/src/Appwrite/Platform/Workers/Certificates.php
@@ -478,9 +478,7 @@ class Certificates extends Action
     private function updateDomainDocuments(string $certificateId, string $domain, bool $success, Database $dbForConsole, Event $queueForEvents, Func $queueForFunctions): void
     {
 
-        $rule = $dbForConsole->findOne('rules', [
-            Query::equal('domain', [$domain]),
-        ]);
+        $rule = $dbForConsole->getDocument('rules', md5($domain));
 
         if (!$rule->isEmpty()) {
             $rule->setAttribute('certificateId', $certificateId);