From b21730dea6be7cc60d16a697b3c980019040d39d Mon Sep 17 00:00:00 2001 From: Chirag Aggarwal Date: Fri, 29 May 2026 11:47:51 +0530 Subject: [PATCH 01/16] Move execution log persistence to cloud --- Dockerfile | 1 - app/init/resources.php | 6 --- app/listeners.php | 2 - app/views/install/compose.phtml | 29 ----------- bin/worker-executions | 3 -- docker-compose.yml | 31 ----------- src/Appwrite/Bus/Events/ExecutionLogged.php | 18 +++++++ src/Appwrite/Bus/Listeners/Log.php | 50 ------------------ .../Functions/Http/Executions/Create.php | 18 +++++-- src/Appwrite/Platform/Services/Workers.php | 2 - src/Appwrite/Platform/Tasks/ScheduleBase.php | 10 +++- src/Appwrite/Platform/Workers/Executions.php | 51 ------------------- tests/resources/docker/docker-compose.yml | 21 -------- 13 files changed, 41 insertions(+), 201 deletions(-) delete mode 100755 bin/worker-executions create mode 100644 src/Appwrite/Bus/Events/ExecutionLogged.php delete mode 100644 src/Appwrite/Bus/Listeners/Log.php delete mode 100644 src/Appwrite/Platform/Workers/Executions.php diff --git a/Dockerfile b/Dockerfile index 9a61635415..58150321d6 100755 --- a/Dockerfile +++ b/Dockerfile @@ -89,7 +89,6 @@ RUN chmod +x /usr/local/bin/doctor && \ chmod +x /usr/local/bin/worker-certificates && \ chmod +x /usr/local/bin/worker-databases && \ chmod +x /usr/local/bin/worker-deletes && \ - chmod +x /usr/local/bin/worker-executions && \ chmod +x /usr/local/bin/worker-functions && \ chmod +x /usr/local/bin/worker-mails && \ chmod +x /usr/local/bin/worker-messaging && \ diff --git a/app/init/resources.php b/app/init/resources.php index 34f66d3de7..b9f2e90a15 100644 --- a/app/init/resources.php +++ b/app/init/resources.php @@ -7,7 +7,6 @@ use Appwrite\Event\Publisher\Build as BuildPublisher; use Appwrite\Event\Publisher\Certificate as CertificatePublisher; use Appwrite\Event\Publisher\Database as DatabasePublisher; use Appwrite\Event\Publisher\Delete as DeletePublisher; -use Appwrite\Event\Publisher\Execution as ExecutionPublisher; use Appwrite\Event\Publisher\Func as FunctionPublisher; use Appwrite\Event\Publisher\Mail as MailPublisher; use Appwrite\Event\Publisher\Messaging as MessagingPublisher; @@ -105,11 +104,6 @@ $container->set('publisherForUsage', fn (Publisher $publisher) => new UsagePubli new Queue(System::getEnv('_APP_STATS_USAGE_QUEUE_NAME', Event::STATS_USAGE_QUEUE_NAME)) ), ['publisher']); -$container->set('publisherForExecutions', fn (Publisher $publisher) => new ExecutionPublisher( - $publisher, - new Queue(System::getEnv('_APP_EXECUTIONS_QUEUE_NAME', Event::EXECUTIONS_QUEUE_NAME)) -), ['publisher']); - $container->set('publisherForFunctions', fn (Publisher $publisher) => new FunctionPublisher( $publisher, new Queue(System::getEnv('_APP_FUNCTIONS_QUEUE_NAME', Event::FUNCTIONS_QUEUE_NAME), 'utopia-queue', Event::FUNCTIONS_QUEUE_TTL) diff --git a/app/listeners.php b/app/listeners.php index 240225dc45..9f959ac6ab 100644 --- a/app/listeners.php +++ b/app/listeners.php @@ -1,11 +1,9 @@ getParam('hostPath', ''), '/'); - _APP_DB_PASS - _APP_LOGGING_CONFIG - appwrite-worker-executions: - image: /: - entrypoint: worker-executions - <<: *x-logging - container_name: appwrite-worker-executions - restart: unless-stopped - networks: - - appwrite - depends_on: - redis: - condition: service_healthy - : - condition: service_healthy - environment: - - _APP_ENV - - _APP_WORKER_PER_CORE - - _APP_REDIS_HOST - - _APP_REDIS_PORT - - _APP_REDIS_USER - - _APP_REDIS_PASS - - _APP_ENV - - _APP_DB_ADAPTER - - _APP_DB_HOST - - _APP_DB_PORT - - _APP_DB_SCHEMA - - _APP_DB_USER - - _APP_DB_PASS - - _APP_LOGGING_CONFIG - appwrite-worker-functions: image: /: entrypoint: worker-functions diff --git a/bin/worker-executions b/bin/worker-executions deleted file mode 100755 index 6789fb8da8..0000000000 --- a/bin/worker-executions +++ /dev/null @@ -1,3 +0,0 @@ -#!/bin/sh - -exec php /usr/src/code/app/worker.php executions "$@" diff --git a/docker-compose.yml b/docker-compose.yml index 7d3f6bdc5f..e2a5a7161e 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -690,37 +690,6 @@ services: - _APP_LOGGING_CONFIG - _APP_DATABASE_SHARED_TABLES - appwrite-worker-executions: - entrypoint: worker-executions - <<: [*x-logging, *x-build] - container_name: appwrite-worker-executions - image: appwrite-dev - networks: - - appwrite - volumes: - - ./app:/usr/src/code/app - - ./src:/usr/src/code/src - depends_on: - - redis - - ${_APP_DB_HOST:-mongodb} - environment: - - _APP_ENV - - _APP_WORKER_PER_CORE - - _APP_POOL_ADAPTER - - _APP_OPENSSL_KEY_V1 - - _APP_REDIS_HOST - - _APP_REDIS_PORT - - _APP_REDIS_USER - - _APP_REDIS_PASS - - _APP_DB_ADAPTER - - _APP_DB_HOST - - _APP_DB_PORT - - _APP_DB_SCHEMA - - _APP_DB_USER - - _APP_DB_PASS - - _APP_LOGGING_CONFIG - - _APP_DATABASE_SHARED_TABLES - appwrite-worker-functions: entrypoint: worker-functions <<: [*x-logging, *x-build] diff --git a/src/Appwrite/Bus/Events/ExecutionLogged.php b/src/Appwrite/Bus/Events/ExecutionLogged.php new file mode 100644 index 0000000000..eabdc618e8 --- /dev/null +++ b/src/Appwrite/Bus/Events/ExecutionLogged.php @@ -0,0 +1,18 @@ + $execution + * @param array $project + */ + public function __construct( + public readonly array $execution, + public readonly array $project, + ) { + } +} diff --git a/src/Appwrite/Bus/Listeners/Log.php b/src/Appwrite/Bus/Listeners/Log.php deleted file mode 100644 index e0376a4f81..0000000000 --- a/src/Appwrite/Bus/Listeners/Log.php +++ /dev/null @@ -1,50 +0,0 @@ -desc('Persists execution logs to database via queue') - ->inject('publisherForExecutions') - ->callback($this->handle(...)); - } - - public function handle(ExecutionCompleted $event, ExecutionPublisher $publisherForExecutions): void - { - $project = new Document($event->project); - $execution = new Document($event->execution); - - if ($execution->getAttribute('resourceType', '') === 'functions') { - Span::add('project.id', $project->getId()); - Span::add('function.id', $execution->getAttribute('resourceId', '')); - Span::add('execution.id', $execution->getId()); - Span::add('deployment.id', $execution->getAttribute('deploymentId', '')); - Span::add('execution.status', $execution->getAttribute('status', '')); - } - - $publisherForExecutions->enqueue(new ExecutionMessage( - project: $project, - execution: $execution, - )); - } -} diff --git a/src/Appwrite/Platform/Modules/Functions/Http/Executions/Create.php b/src/Appwrite/Platform/Modules/Functions/Http/Executions/Create.php index ba36b47884..b866e7b579 100644 --- a/src/Appwrite/Platform/Modules/Functions/Http/Executions/Create.php +++ b/src/Appwrite/Platform/Modules/Functions/Http/Executions/Create.php @@ -3,6 +3,7 @@ namespace Appwrite\Platform\Modules\Functions\Http\Executions; use Ahc\Jwt\JWT; +use Appwrite\Bus\Events\ExecutionLogged; use Appwrite\Event\Event; use Appwrite\Event\Message\Delete as DeleteMessage; use Appwrite\Event\Message\Func as FunctionMessage; @@ -24,6 +25,7 @@ use Executor\Executor; use MaxMind\Db\Reader; use Utopia\Auth\Proofs\Token; use Utopia\Auth\Store; +use Utopia\Bus\Bus; use Utopia\Config\Config; use Utopia\Console; use Utopia\Database\Database; @@ -107,6 +109,7 @@ class Create extends Base ->inject('authorization') ->inject('publisherForDeletes') ->inject('executionsRetentionCount') + ->inject('bus') ->callback($this->action(...)); } @@ -135,6 +138,7 @@ class Create extends Base Authorization $authorization, DeletePublisher $publisherForDeletes, int $executionsRetentionCount, + Bus $bus, ) { $async = \strval($async) === 'true' || \strval($async) === '1'; @@ -296,7 +300,6 @@ class Create extends Base if ($async) { if (is_null($scheduledAt)) { - $execution = $authorization->skip(fn () => $dbForProject->createDocument('executions', $execution)); $publisherForFunctions->enqueue(new FunctionMessage( project: $project, user: $user, @@ -316,7 +319,8 @@ class Create extends Base 'path' => $path, 'method' => $method, 'body' => $body, - 'userId' => $user->getId() + 'userId' => $user->getId(), + 'execution' => $execution->getArrayCopy(), ]; $schedule = $dbForPlatform->createDocument('schedules', new Document([ @@ -336,7 +340,10 @@ class Create extends Base ->setAttribute('scheduleInternalId', $schedule->getSequence()) ->setAttribute('scheduledAt', $scheduledAt); - $execution = $authorization->skip(fn () => $dbForProject->createDocument('executions', $execution)); + $bus->dispatch(new ExecutionLogged( + execution: $execution->getArrayCopy(), + project: $project->getArrayCopy(), + )); } if ($executionsRetentionCount > 0 && ENABLE_EXECUTIONS_LIMIT_ON_ROUTE) { @@ -506,7 +513,10 @@ class Create extends Base ->addMetric(str_replace(['{resourceType}', '{resourceInternalId}'], [RESOURCE_TYPE_FUNCTIONS, $function->getSequence()], METRIC_RESOURCE_TYPE_ID_EXECUTIONS_MB_SECONDS), (int)(($spec['memory'] ?? APP_COMPUTE_MEMORY_DEFAULT) * $execution->getAttribute('duration', 0) * ($spec['cpus'] ?? APP_COMPUTE_CPUS_DEFAULT))) ; - $execution = $authorization->skip(fn () => $dbForProject->createDocument('executions', $execution)); + $bus->dispatch(new ExecutionLogged( + execution: $execution->getArrayCopy(), + project: $project->getArrayCopy(), + )); } $executionResponse['headers']['x-appwrite-execution-id'] = $execution->getId(); diff --git a/src/Appwrite/Platform/Services/Workers.php b/src/Appwrite/Platform/Services/Workers.php index fa77725f7a..f2cbeb390a 100644 --- a/src/Appwrite/Platform/Services/Workers.php +++ b/src/Appwrite/Platform/Services/Workers.php @@ -5,7 +5,6 @@ namespace Appwrite\Platform\Services; use Appwrite\Platform\Workers\Audits; use Appwrite\Platform\Workers\Certificates; use Appwrite\Platform\Workers\Deletes; -use Appwrite\Platform\Workers\Executions; use Appwrite\Platform\Workers\Functions; use Appwrite\Platform\Workers\Mails; use Appwrite\Platform\Workers\Messaging; @@ -24,7 +23,6 @@ class Workers extends Service ->addAction(Audits::getName(), new Audits()) ->addAction(Certificates::getName(), new Certificates()) ->addAction(Deletes::getName(), new Deletes()) - ->addAction(Executions::getName(), new Executions()) ->addAction(Functions::getName(), new Functions()) ->addAction(Mails::getName(), new Mails()) ->addAction(Messaging::getName(), new Messaging()) diff --git a/src/Appwrite/Platform/Tasks/ScheduleBase.php b/src/Appwrite/Platform/Tasks/ScheduleBase.php index 1213f78924..2662369cf3 100644 --- a/src/Appwrite/Platform/Tasks/ScheduleBase.php +++ b/src/Appwrite/Platform/Tasks/ScheduleBase.php @@ -173,6 +173,7 @@ abstract class ScheduleBase extends Action 'schedule' => $schedule->getAttribute('schedule'), 'active' => $schedule->getAttribute('active'), 'resourceUpdatedAt' => $schedule->getAttribute('resourceUpdatedAt'), + 'data' => $schedule->getAttribute('data', []), ]; } catch (\Throwable $th) { Console::error("Failed to load schedule for project {$schedule->getAttribute('projectId')} {$collectionId} {$schedule->getAttribute('resourceId')}"); @@ -269,7 +270,14 @@ abstract class ScheduleBase extends Action // In case the resource is not found (project deleted). try { - $resource = $getProjectDB($project)->getDocument(static::getCollectionId(), $schedule['resourceId']); + $data = \is_array($schedule['data']) ? $schedule['data'] : []; + $resource = static::getSupportedResource() === SCHEDULE_RESOURCE_TYPE_EXECUTION + ? new Document($data['execution'] ?? []) + : new Document(); + + if ($resource->isEmpty()) { + $resource = $getProjectDB($project)->getDocument(static::getCollectionId(), $schedule['resourceId']); + } } catch (\Throwable $th) { Console::error("Failed to load resource: projectId::{$schedule['projectId']} resourceId::{$schedule['resourceId']}"); Console::error($th->getMessage()); diff --git a/src/Appwrite/Platform/Workers/Executions.php b/src/Appwrite/Platform/Workers/Executions.php deleted file mode 100644 index 8dbf10cae6..0000000000 --- a/src/Appwrite/Platform/Workers/Executions.php +++ /dev/null @@ -1,51 +0,0 @@ -desc('Executions worker') - ->groups(['executions']) - ->inject('message') - ->inject('dbForProject') - ->callback($this->action(...)); - } - - public function action( - Message $message, - Database $dbForProject, - ): void { - $executionMessage = Execution::fromArray($message->getPayload()); - $execution = $executionMessage->execution; - - if ($execution->isEmpty()) { - throw new Exception('Missing execution'); - } - - Span::add('project.id', $executionMessage->project->getId()); - Span::add('function.id', $execution->getAttribute('resourceId', '')); - Span::add('execution.id', $execution->getId()); - Span::add('deployment.id', $execution->getAttribute('deploymentId', '')); - Span::add('resource.type', $execution->getAttribute('resourceType', '')); - - $dbForProject->upsertDocument('executions', $execution); - } -} diff --git a/tests/resources/docker/docker-compose.yml b/tests/resources/docker/docker-compose.yml index 47a69f077b..735e88525e 100644 --- a/tests/resources/docker/docker-compose.yml +++ b/tests/resources/docker/docker-compose.yml @@ -216,27 +216,6 @@ services: - _APP_DB_USER - _APP_DB_PASS - appwrite-worker-executions: - entrypoint: worker-executions - container_name: appwrite-worker-executions - build: - context: . - restart: unless-stopped - networks: - - appwrite - depends_on: - - redis - - mariadb - environment: - - _APP_ENV - - _APP_REDIS_HOST - - _APP_REDIS_PORT - - _APP_DB_HOST - - _APP_DB_PORT - - _APP_DB_SCHEMA - - _APP_DB_USER - - _APP_DB_PASS - appwrite-worker-functions: entrypoint: worker-functions container_name: appwrite-worker-functions From 56dce499c0dcc9a84515102e8ef3dabc1b22b58f Mon Sep 17 00:00:00 2001 From: Chirag Aggarwal Date: Fri, 29 May 2026 13:02:09 +0530 Subject: [PATCH 02/16] Keep execution documents without logs --- .../Functions/Http/Executions/Create.php | 13 ++++++++++ src/Appwrite/Platform/Workers/Functions.php | 26 +++++++++++++++---- .../Functions/FunctionsCustomClientTest.php | 3 ++- .../Functions/FunctionsCustomServerTest.php | 14 +++++----- .../FunctionsScheduleTest.php | 12 +++------ tests/unit/Docker/ComposeTest.php | 2 +- 6 files changed, 48 insertions(+), 22 deletions(-) diff --git a/src/Appwrite/Platform/Modules/Functions/Http/Executions/Create.php b/src/Appwrite/Platform/Modules/Functions/Http/Executions/Create.php index b866e7b579..5d2c6c1d0e 100644 --- a/src/Appwrite/Platform/Modules/Functions/Http/Executions/Create.php +++ b/src/Appwrite/Platform/Modules/Functions/Http/Executions/Create.php @@ -300,6 +300,8 @@ class Create extends Base if ($async) { if (is_null($scheduledAt)) { + $execution = $authorization->skip(fn () => $dbForProject->createDocument('executions', $execution)); + $publisherForFunctions->enqueue(new FunctionMessage( project: $project, user: $user, @@ -340,6 +342,8 @@ class Create extends Base ->setAttribute('scheduleInternalId', $schedule->getSequence()) ->setAttribute('scheduledAt', $scheduledAt); + $execution = $authorization->skip(fn () => $dbForProject->createDocument('executions', $execution)); + $bus->dispatch(new ExecutionLogged( execution: $execution->getArrayCopy(), project: $project->getArrayCopy(), @@ -360,6 +364,8 @@ class Create extends Base return; } + $execution = $authorization->skip(fn () => $dbForProject->createDocument('executions', $execution)); + $durationStart = \microtime(true); $vars = []; @@ -513,6 +519,13 @@ class Create extends Base ->addMetric(str_replace(['{resourceType}', '{resourceInternalId}'], [RESOURCE_TYPE_FUNCTIONS, $function->getSequence()], METRIC_RESOURCE_TYPE_ID_EXECUTIONS_MB_SECONDS), (int)(($spec['memory'] ?? APP_COMPUTE_MEMORY_DEFAULT) * $execution->getAttribute('duration', 0) * ($spec['cpus'] ?? APP_COMPUTE_CPUS_DEFAULT))) ; + $authorization->skip(fn () => $dbForProject->updateDocument('executions', $execution->getId(), new Document([ + 'status' => $execution->getAttribute('status'), + 'responseStatusCode' => $execution->getAttribute('responseStatusCode'), + 'responseHeaders' => $execution->getAttribute('responseHeaders'), + 'duration' => $execution->getAttribute('duration'), + ]))); + $bus->dispatch(new ExecutionLogged( execution: $execution->getArrayCopy(), project: $project->getArrayCopy(), diff --git a/src/Appwrite/Platform/Workers/Functions.php b/src/Appwrite/Platform/Workers/Functions.php index 73c1db9444..75bda7aa18 100644 --- a/src/Appwrite/Platform/Workers/Functions.php +++ b/src/Appwrite/Platform/Workers/Functions.php @@ -263,6 +263,7 @@ class Functions extends Action /** * @param string $message + * @param Database $dbForProject * @param Document $function * @param string $trigger * @param string $path @@ -274,6 +275,7 @@ class Functions extends Action */ private function fail( string $message, + Database $dbForProject, Document $project, Bus $bus, Document $function, @@ -313,19 +315,24 @@ class Functions extends Action 'requestPath' => $path, 'requestMethod' => $method, 'requestHeaders' => $headersFiltered, - 'errors' => $message, + 'errors' => '', 'logs' => '', 'duration' => 0.0, ]); + $executionForEvent = new Document($execution->getArrayCopy()) + ->setAttribute('errors', $message); + Span::add('function.id', $function->getId()); Span::add('execution.id', $execution->getId()); Span::add('deployment.id', $execution->getAttribute('deploymentId', '')); Span::add('execution.trigger', $trigger); Span::add('execution.status', $execution->getAttribute('status', '')); + $dbForProject->upsertDocument('executions', $execution); + $bus->dispatch(new ExecutionCompleted( - execution: $execution->getArrayCopy(), + execution: $executionForEvent->getArrayCopy(), project: $project->getArrayCopy(), )); } @@ -390,19 +397,19 @@ class Functions extends Action if ($deployment->getAttribute('resourceId') !== $functionId) { $errorMessage = 'The execution could not be completed because a corresponding deployment was not found. A function deployment needs to be created before it can be executed. Please create a deployment for your function and try again.'; - $this->fail($errorMessage, $project, $bus, $function, $trigger, $path, $method, $user, $jwt, $event); + $this->fail($errorMessage, $dbForProject, $project, $bus, $function, $trigger, $path, $method, $user, $jwt, $event); return; } if ($deployment->isEmpty()) { $errorMessage = 'The execution could not be completed because a corresponding deployment was not found. A function deployment needs to be created before it can be executed. Please create a deployment for your function and try again.'; - $this->fail($errorMessage, $project, $bus, $function, $trigger, $path, $method, $user, $jwt, $event); + $this->fail($errorMessage, $dbForProject, $project, $bus, $function, $trigger, $path, $method, $user, $jwt, $event); return; } if ($deployment->getAttribute('status') !== 'ready') { $errorMessage = 'The execution could not be completed because the build is not ready. Please wait for the build to complete and try again.'; - $this->fail($errorMessage, $project, $bus, $function, $trigger, $path, $method, $user, $jwt, $event); + $this->fail($errorMessage, $dbForProject, $project, $bus, $function, $trigger, $path, $method, $user, $jwt, $event); return; } @@ -471,6 +478,8 @@ class Functions extends Action 'duration' => 0.0, ]); + $dbForProject->upsertDocument('executions', $execution); + $durationStart = \microtime(true); $body = $eventData ?? ''; @@ -626,6 +635,13 @@ class Functions extends Action /** Persist final execution status and record usage */ Span::add('execution.status', $execution->getAttribute('status', '')); + $dbForProject->updateDocument('executions', $execution->getId(), new Document([ + 'status' => $execution->getAttribute('status'), + 'responseStatusCode' => $execution->getAttribute('responseStatusCode'), + 'responseHeaders' => $execution->getAttribute('responseHeaders'), + 'duration' => $execution->getAttribute('duration'), + ])); + $bus->dispatch(new ExecutionCompleted( execution: $execution->getArrayCopy(), project: $project->getArrayCopy(), diff --git a/tests/e2e/Services/Functions/FunctionsCustomClientTest.php b/tests/e2e/Services/Functions/FunctionsCustomClientTest.php index 1208121077..032307a723 100644 --- a/tests/e2e/Services/Functions/FunctionsCustomClientTest.php +++ b/tests/e2e/Services/Functions/FunctionsCustomClientTest.php @@ -605,7 +605,8 @@ class FunctionsCustomClientTest extends Scope $lastExecution = $executions['body']['executions'][0]; $this->assertEquals('completed', $lastExecution['status']); $this->assertEquals(204, $lastExecution['responseStatusCode']); - $this->assertStringContainsString($documentId, $lastExecution['logs']); + $this->assertEmpty($lastExecution['logs']); + $this->assertEmpty($lastExecution['errors']); }, 20000, 500); $this->client->call(Client::METHOD_DELETE, '/databases/' . $databaseId, [ diff --git a/tests/e2e/Services/Functions/FunctionsCustomServerTest.php b/tests/e2e/Services/Functions/FunctionsCustomServerTest.php index 44d5d274da..8527a90d40 100644 --- a/tests/e2e/Services/Functions/FunctionsCustomServerTest.php +++ b/tests/e2e/Services/Functions/FunctionsCustomServerTest.php @@ -745,7 +745,7 @@ class FunctionsCustomServerTest extends Scope $executionId = $execution['body']['$id'] ?? ''; - $this->assertEventually(function () use ($functionId, $executionId, $totalUsers) { + $this->assertEventually(function () use ($functionId, $executionId) { $execution = $this->getExecution($functionId, $executionId); $this->assertEquals(200, $execution['headers']['status-code']); @@ -753,7 +753,7 @@ class FunctionsCustomServerTest extends Scope $this->assertEquals('completed', $execution['body']['status']); $this->assertEmpty($execution['body']['responseBody']); $this->assertEmpty($execution['body']['errors']); - $this->assertStringContainsString("Total users: " . $totalUsers, $execution['body']['logs']); + $this->assertEmpty($execution['body']['logs']); }, 10000, 500); $deployment = $this->getDeployment($functionId, $deployment['body']['$id']); @@ -2124,7 +2124,7 @@ class FunctionsCustomServerTest extends Scope $this->assertLessThan(20, $execution['body']['duration']); $this->assertEquals('', $execution['body']['responseBody']); $this->assertEquals('', $execution['body']['logs']); - $this->assertStringContainsString('timed out', $execution['body']['errors']); + $this->assertEquals('', $execution['body']['errors']); }, 10000, 500); $this->cleanupFunction($functionId); @@ -2357,8 +2357,8 @@ class FunctionsCustomServerTest extends Scope $this->assertEquals('completed', $lastExecution['status']); $this->assertEquals(204, $lastExecution['responseStatusCode']); - $this->assertStringContainsString($userId, $lastExecution['logs']); - $this->assertStringContainsString('Event User', $lastExecution['logs']); + $this->assertEmpty($lastExecution['logs']); + $this->assertEmpty($lastExecution['errors']); $this->assertNotEmpty($lastExecution['$id']); $headers = array_column($lastExecution['requestHeaders'] ?? [], 'value', 'name'); $this->assertEmpty($headers['x-appwrite-client-ip'] ?? ''); @@ -2426,8 +2426,8 @@ class FunctionsCustomServerTest extends Scope $this->assertEquals('completed', $execution['body']['status']); $this->assertEquals(200, $execution['body']['responseStatusCode']); $this->assertGreaterThan(0, $execution['body']['duration']); - $this->assertNotEmpty($execution['body']['logs']); - $this->assertStringContainsString("total", $execution['body']['logs']); + $this->assertEmpty($execution['body']['logs']); + $this->assertEmpty($execution['body']['errors']); }, 10000, 500); $this->cleanupFunction($functionId); diff --git a/tests/e2e/Services/FunctionsSchedule/FunctionsScheduleTest.php b/tests/e2e/Services/FunctionsSchedule/FunctionsScheduleTest.php index f4a70b5a9e..2a8529b580 100644 --- a/tests/e2e/Services/FunctionsSchedule/FunctionsScheduleTest.php +++ b/tests/e2e/Services/FunctionsSchedule/FunctionsScheduleTest.php @@ -58,8 +58,8 @@ class FunctionsScheduleTest extends Scope $this->assertEquals('completed', $asyncExecution['status']); $this->assertEquals(200, $asyncExecution['responseStatusCode']); $this->assertEquals('', $asyncExecution['responseBody']); - $this->assertNotEmpty($asyncExecution['logs']); - $this->assertNotEmpty($asyncExecution['errors']); + $this->assertEmpty($asyncExecution['logs']); + $this->assertEmpty($asyncExecution['errors']); $this->assertGreaterThan(0, $asyncExecution['duration']); $this->assertNotEmpty($asyncExecution['$id']); $headers = array_column($asyncExecution['requestHeaders'] ?? [], 'value', 'name'); @@ -132,12 +132,8 @@ class FunctionsScheduleTest extends Scope $this->assertEquals('completed', $execution['body']['status']); $this->assertEquals('/custom-path', $execution['body']['requestPath']); $this->assertEquals('PATCH', $execution['body']['requestMethod']); - $this->assertStringContainsString('body-is-custom-body', $execution['body']['logs']); - $this->assertStringContainsString('custom-header-is-custom-value', $execution['body']['logs']); - $this->assertStringContainsString('method-is-patch', $execution['body']['logs']); - $this->assertStringContainsString('path-is-/custom-path', $execution['body']['logs']); - $this->assertStringContainsString('user-is-' . $this->getUser()['$id'], $execution['body']['logs']); - $this->assertStringContainsString('jwt-is-valid', $execution['body']['logs']); + $this->assertEmpty($execution['body']['logs']); + $this->assertEmpty($execution['body']['errors']); $this->assertGreaterThan(0, $execution['body']['duration']); }, 120000, 500); diff --git a/tests/unit/Docker/ComposeTest.php b/tests/unit/Docker/ComposeTest.php index e63d877baf..74779230ac 100644 --- a/tests/unit/Docker/ComposeTest.php +++ b/tests/unit/Docker/ComposeTest.php @@ -23,7 +23,7 @@ class ComposeTest extends TestCase public function testServices(): void { - $this->assertCount(16, $this->object->getServices()); + $this->assertCount(15, $this->object->getServices()); $this->assertEquals('appwrite', $this->object->getService('appwrite')->getContainerName()); $this->assertEquals('', $this->object->getService('appwrite')->getImageVersion()); $this->assertEquals('3.6', $this->object->getService('traefik')->getImageVersion()); From 502fafdc585985c1d2d588adb3595f3ca9ad6081 Mon Sep 17 00:00:00 2001 From: Chirag Aggarwal Date: Fri, 29 May 2026 13:04:39 +0530 Subject: [PATCH 03/16] Load scheduled executions from database --- .../Modules/Functions/Http/Executions/Create.php | 4 +--- src/Appwrite/Platform/Tasks/ScheduleBase.php | 9 +-------- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/src/Appwrite/Platform/Modules/Functions/Http/Executions/Create.php b/src/Appwrite/Platform/Modules/Functions/Http/Executions/Create.php index 5d2c6c1d0e..8ce70d5c91 100644 --- a/src/Appwrite/Platform/Modules/Functions/Http/Executions/Create.php +++ b/src/Appwrite/Platform/Modules/Functions/Http/Executions/Create.php @@ -301,7 +301,6 @@ class Create extends Base if ($async) { if (is_null($scheduledAt)) { $execution = $authorization->skip(fn () => $dbForProject->createDocument('executions', $execution)); - $publisherForFunctions->enqueue(new FunctionMessage( project: $project, user: $user, @@ -321,8 +320,7 @@ class Create extends Base 'path' => $path, 'method' => $method, 'body' => $body, - 'userId' => $user->getId(), - 'execution' => $execution->getArrayCopy(), + 'userId' => $user->getId() ]; $schedule = $dbForPlatform->createDocument('schedules', new Document([ diff --git a/src/Appwrite/Platform/Tasks/ScheduleBase.php b/src/Appwrite/Platform/Tasks/ScheduleBase.php index 2662369cf3..d3e4ad9705 100644 --- a/src/Appwrite/Platform/Tasks/ScheduleBase.php +++ b/src/Appwrite/Platform/Tasks/ScheduleBase.php @@ -270,14 +270,7 @@ abstract class ScheduleBase extends Action // In case the resource is not found (project deleted). try { - $data = \is_array($schedule['data']) ? $schedule['data'] : []; - $resource = static::getSupportedResource() === SCHEDULE_RESOURCE_TYPE_EXECUTION - ? new Document($data['execution'] ?? []) - : new Document(); - - if ($resource->isEmpty()) { - $resource = $getProjectDB($project)->getDocument(static::getCollectionId(), $schedule['resourceId']); - } + $resource = $getProjectDB($project)->getDocument(static::getCollectionId(), $schedule['resourceId']); } catch (\Throwable $th) { Console::error("Failed to load resource: projectId::{$schedule['projectId']} resourceId::{$schedule['resourceId']}"); Console::error($th->getMessage()); From ca603a64eda06b4408ca3cb630a2f816fd42b465 Mon Sep 17 00:00:00 2001 From: Chirag Aggarwal Date: Fri, 29 May 2026 13:08:19 +0530 Subject: [PATCH 04/16] Create sync executions after completion --- .../Modules/Functions/Http/Executions/Create.php | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/Appwrite/Platform/Modules/Functions/Http/Executions/Create.php b/src/Appwrite/Platform/Modules/Functions/Http/Executions/Create.php index 8ce70d5c91..092cb772a5 100644 --- a/src/Appwrite/Platform/Modules/Functions/Http/Executions/Create.php +++ b/src/Appwrite/Platform/Modules/Functions/Http/Executions/Create.php @@ -362,8 +362,6 @@ class Create extends Base return; } - $execution = $authorization->skip(fn () => $dbForProject->createDocument('executions', $execution)); - $durationStart = \microtime(true); $vars = []; @@ -517,12 +515,7 @@ class Create extends Base ->addMetric(str_replace(['{resourceType}', '{resourceInternalId}'], [RESOURCE_TYPE_FUNCTIONS, $function->getSequence()], METRIC_RESOURCE_TYPE_ID_EXECUTIONS_MB_SECONDS), (int)(($spec['memory'] ?? APP_COMPUTE_MEMORY_DEFAULT) * $execution->getAttribute('duration', 0) * ($spec['cpus'] ?? APP_COMPUTE_CPUS_DEFAULT))) ; - $authorization->skip(fn () => $dbForProject->updateDocument('executions', $execution->getId(), new Document([ - 'status' => $execution->getAttribute('status'), - 'responseStatusCode' => $execution->getAttribute('responseStatusCode'), - 'responseHeaders' => $execution->getAttribute('responseHeaders'), - 'duration' => $execution->getAttribute('duration'), - ]))); + $execution = $authorization->skip(fn () => $dbForProject->createDocument('executions', $execution)); $bus->dispatch(new ExecutionLogged( execution: $execution->getArrayCopy(), From 07bedbd1f50d195f53f33c69322c78a56f261411 Mon Sep 17 00:00:00 2001 From: Chirag Aggarwal Date: Fri, 29 May 2026 13:09:21 +0530 Subject: [PATCH 05/16] Remove cached schedule data --- src/Appwrite/Platform/Tasks/ScheduleBase.php | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Appwrite/Platform/Tasks/ScheduleBase.php b/src/Appwrite/Platform/Tasks/ScheduleBase.php index d3e4ad9705..1213f78924 100644 --- a/src/Appwrite/Platform/Tasks/ScheduleBase.php +++ b/src/Appwrite/Platform/Tasks/ScheduleBase.php @@ -173,7 +173,6 @@ abstract class ScheduleBase extends Action 'schedule' => $schedule->getAttribute('schedule'), 'active' => $schedule->getAttribute('active'), 'resourceUpdatedAt' => $schedule->getAttribute('resourceUpdatedAt'), - 'data' => $schedule->getAttribute('data', []), ]; } catch (\Throwable $th) { Console::error("Failed to load schedule for project {$schedule->getAttribute('projectId')} {$collectionId} {$schedule->getAttribute('resourceId')}"); From 5955c020e7e40c956b339d59e37a884af87e17f0 Mon Sep 17 00:00:00 2001 From: Chirag Aggarwal Date: Fri, 29 May 2026 13:16:07 +0530 Subject: [PATCH 06/16] Fix execution log test analysis --- tests/e2e/Services/Functions/FunctionsCustomClientTest.php | 4 +--- tests/e2e/Services/Functions/FunctionsCustomServerTest.php | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/e2e/Services/Functions/FunctionsCustomClientTest.php b/tests/e2e/Services/Functions/FunctionsCustomClientTest.php index 032307a723..617bf57ae9 100644 --- a/tests/e2e/Services/Functions/FunctionsCustomClientTest.php +++ b/tests/e2e/Services/Functions/FunctionsCustomClientTest.php @@ -590,9 +590,7 @@ class FunctionsCustomClientTest extends Scope 'data' => ['name' => 'Test Document'], ]); $this->assertEquals(201, $document['headers']['status-code']); - $documentId = $document['body']['$id']; - - $this->assertEventually(function () use ($functionId, $documentId) { + $this->assertEventually(function () use ($functionId) { $executions = $this->client->call(Client::METHOD_GET, '/functions/' . $functionId . '/executions', [ 'content-type' => 'application/json', 'x-appwrite-project' => $this->getProject()['$id'], diff --git a/tests/e2e/Services/Functions/FunctionsCustomServerTest.php b/tests/e2e/Services/Functions/FunctionsCustomServerTest.php index 8527a90d40..34a3bba500 100644 --- a/tests/e2e/Services/Functions/FunctionsCustomServerTest.php +++ b/tests/e2e/Services/Functions/FunctionsCustomServerTest.php @@ -2347,7 +2347,7 @@ class FunctionsCustomServerTest extends Scope $userId = $user['body']['$id'] ?? ''; - $this->assertEventually(function () use ($functionId, $userId) { + $this->assertEventually(function () use ($functionId) { $executions = $this->listExecutions($functionId); $this->assertEquals(200, $executions['headers']['status-code']); From c0e276663a7af56c546e8c22a73f9005f8364a54 Mon Sep 17 00:00:00 2001 From: Chirag Aggarwal Date: Fri, 29 May 2026 13:19:22 +0530 Subject: [PATCH 07/16] Fix function worker parser compatibility --- src/Appwrite/Platform/Workers/Functions.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Appwrite/Platform/Workers/Functions.php b/src/Appwrite/Platform/Workers/Functions.php index 75bda7aa18..273847859b 100644 --- a/src/Appwrite/Platform/Workers/Functions.php +++ b/src/Appwrite/Platform/Workers/Functions.php @@ -320,7 +320,7 @@ class Functions extends Action 'duration' => 0.0, ]); - $executionForEvent = new Document($execution->getArrayCopy()) + $executionForEvent = (new Document($execution->getArrayCopy())) ->setAttribute('errors', $message); Span::add('function.id', $function->getId()); From 3fe1959cde4b2d09a6228b399f1f2c8c0d1c17b3 Mon Sep 17 00:00:00 2001 From: Chirag Aggarwal Date: Fri, 29 May 2026 13:33:30 +0530 Subject: [PATCH 08/16] Persist proxy execution documents --- app/controllers/general.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/controllers/general.php b/app/controllers/general.php index 219c14774f..5cbd1794f9 100644 --- a/app/controllers/general.php +++ b/app/controllers/general.php @@ -719,6 +719,8 @@ function router(Http $utopia, Database $dbForPlatform, callable $getProjectDB, S $execution->setAttribute('logs', ''); $execution->setAttribute('errors', ''); + $execution = $authorization->skip(fn () => $dbForProject->createDocument('executions', $execution)); + $headers = []; foreach (($executionResponse['headers'] ?? []) as $key => $value) { $headers[] = ['name' => $key, 'value' => \is_array($value) ? \implode(', ', $value) : $value]; From f8d4b06c10173957d6a88e1d5f7ccf5ce967497c Mon Sep 17 00:00:00 2001 From: Chirag Aggarwal Date: Fri, 29 May 2026 14:02:01 +0530 Subject: [PATCH 09/16] Remove execution log assertions from function tests --- .../e2e/Services/Functions/FunctionsCustomClientTest.php | 2 -- .../e2e/Services/Functions/FunctionsCustomServerTest.php | 8 -------- .../Services/FunctionsSchedule/FunctionsScheduleTest.php | 4 ---- 3 files changed, 14 deletions(-) diff --git a/tests/e2e/Services/Functions/FunctionsCustomClientTest.php b/tests/e2e/Services/Functions/FunctionsCustomClientTest.php index 617bf57ae9..18c99e856f 100644 --- a/tests/e2e/Services/Functions/FunctionsCustomClientTest.php +++ b/tests/e2e/Services/Functions/FunctionsCustomClientTest.php @@ -603,8 +603,6 @@ class FunctionsCustomClientTest extends Scope $lastExecution = $executions['body']['executions'][0]; $this->assertEquals('completed', $lastExecution['status']); $this->assertEquals(204, $lastExecution['responseStatusCode']); - $this->assertEmpty($lastExecution['logs']); - $this->assertEmpty($lastExecution['errors']); }, 20000, 500); $this->client->call(Client::METHOD_DELETE, '/databases/' . $databaseId, [ diff --git a/tests/e2e/Services/Functions/FunctionsCustomServerTest.php b/tests/e2e/Services/Functions/FunctionsCustomServerTest.php index 34a3bba500..0d189e0c69 100644 --- a/tests/e2e/Services/Functions/FunctionsCustomServerTest.php +++ b/tests/e2e/Services/Functions/FunctionsCustomServerTest.php @@ -752,8 +752,6 @@ class FunctionsCustomServerTest extends Scope $this->assertEquals(200, $execution['body']['responseStatusCode']); $this->assertEquals('completed', $execution['body']['status']); $this->assertEmpty($execution['body']['responseBody']); - $this->assertEmpty($execution['body']['errors']); - $this->assertEmpty($execution['body']['logs']); }, 10000, 500); $deployment = $this->getDeployment($functionId, $deployment['body']['$id']); @@ -2123,8 +2121,6 @@ class FunctionsCustomServerTest extends Scope $this->assertGreaterThan(2, $execution['body']['duration']); $this->assertLessThan(20, $execution['body']['duration']); $this->assertEquals('', $execution['body']['responseBody']); - $this->assertEquals('', $execution['body']['logs']); - $this->assertEquals('', $execution['body']['errors']); }, 10000, 500); $this->cleanupFunction($functionId); @@ -2357,8 +2353,6 @@ class FunctionsCustomServerTest extends Scope $this->assertEquals('completed', $lastExecution['status']); $this->assertEquals(204, $lastExecution['responseStatusCode']); - $this->assertEmpty($lastExecution['logs']); - $this->assertEmpty($lastExecution['errors']); $this->assertNotEmpty($lastExecution['$id']); $headers = array_column($lastExecution['requestHeaders'] ?? [], 'value', 'name'); $this->assertEmpty($headers['x-appwrite-client-ip'] ?? ''); @@ -2426,8 +2420,6 @@ class FunctionsCustomServerTest extends Scope $this->assertEquals('completed', $execution['body']['status']); $this->assertEquals(200, $execution['body']['responseStatusCode']); $this->assertGreaterThan(0, $execution['body']['duration']); - $this->assertEmpty($execution['body']['logs']); - $this->assertEmpty($execution['body']['errors']); }, 10000, 500); $this->cleanupFunction($functionId); diff --git a/tests/e2e/Services/FunctionsSchedule/FunctionsScheduleTest.php b/tests/e2e/Services/FunctionsSchedule/FunctionsScheduleTest.php index 2a8529b580..c1e79b1d68 100644 --- a/tests/e2e/Services/FunctionsSchedule/FunctionsScheduleTest.php +++ b/tests/e2e/Services/FunctionsSchedule/FunctionsScheduleTest.php @@ -58,8 +58,6 @@ class FunctionsScheduleTest extends Scope $this->assertEquals('completed', $asyncExecution['status']); $this->assertEquals(200, $asyncExecution['responseStatusCode']); $this->assertEquals('', $asyncExecution['responseBody']); - $this->assertEmpty($asyncExecution['logs']); - $this->assertEmpty($asyncExecution['errors']); $this->assertGreaterThan(0, $asyncExecution['duration']); $this->assertNotEmpty($asyncExecution['$id']); $headers = array_column($asyncExecution['requestHeaders'] ?? [], 'value', 'name'); @@ -132,8 +130,6 @@ class FunctionsScheduleTest extends Scope $this->assertEquals('completed', $execution['body']['status']); $this->assertEquals('/custom-path', $execution['body']['requestPath']); $this->assertEquals('PATCH', $execution['body']['requestMethod']); - $this->assertEmpty($execution['body']['logs']); - $this->assertEmpty($execution['body']['errors']); $this->assertGreaterThan(0, $execution['body']['duration']); }, 120000, 500); From 995c8428d369e0d3467a874c784664a9a6e63368 Mon Sep 17 00:00:00 2001 From: Chirag Aggarwal Date: Fri, 29 May 2026 14:13:54 +0530 Subject: [PATCH 10/16] Persist proxy execution documents from finally --- app/controllers/general.php | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/app/controllers/general.php b/app/controllers/general.php index 5cbd1794f9..c53e0c29dd 100644 --- a/app/controllers/general.php +++ b/app/controllers/general.php @@ -714,13 +714,12 @@ function router(Http $utopia, Database $dbForPlatform, callable $getProjectDB, S spec: $spec, resource: $resource->getArrayCopy(), )); + + $execution->setAttribute('logs', ''); + $execution->setAttribute('errors', ''); + $execution = $authorization->skip(fn () => $dbForProject->createDocument('executions', $execution)); } - $execution->setAttribute('logs', ''); - $execution->setAttribute('errors', ''); - - $execution = $authorization->skip(fn () => $dbForProject->createDocument('executions', $execution)); - $headers = []; foreach (($executionResponse['headers'] ?? []) as $key => $value) { $headers[] = ['name' => $key, 'value' => \is_array($value) ? \implode(', ', $value) : $value]; From c51d75a3f200d963bc4c88001693a1b4c14abe7a Mon Sep 17 00:00:00 2001 From: Chirag Aggarwal Date: Fri, 29 May 2026 13:58:00 +0530 Subject: [PATCH 11/16] Wait for benchmark health check --- .github/workflows/ci.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8a7537cf1d..343d22fdf2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -761,11 +761,11 @@ jobs: run: | docker tag ${{ env.IMAGE }}:before ${{ env.IMAGE }} docker compose up -d --wait --no-build - for attempt in $(seq 1 5); do - if curl -fsS http://localhost/v1/health; then + for attempt in $(seq 1 10); do + if curl -fsS http://localhost/v1/health/version; then break fi - if [ "$attempt" -eq 5 ]; then + if [ "$attempt" -eq 10 ]; then exit 1 fi sleep 1 @@ -825,11 +825,11 @@ jobs: run: | docker tag ${{ env.IMAGE }}:after ${{ env.IMAGE }} docker compose up -d --wait --no-build - for attempt in $(seq 1 5); do - if curl -fsS http://localhost/v1/health; then + for attempt in $(seq 1 10); do + if curl -fsS http://localhost/v1/health/version; then break fi - if [ "$attempt" -eq 5 ]; then + if [ "$attempt" -eq 10 ]; then exit 1 fi sleep 1 From 185fcb81e70256d4329eb9cddac46487646dad14 Mon Sep 17 00:00:00 2001 From: Chirag Aggarwal Date: Fri, 29 May 2026 15:52:01 +0530 Subject: [PATCH 12/16] site tests --- .../Services/Sites/SitesCustomServerTest.php | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/tests/e2e/Services/Sites/SitesCustomServerTest.php b/tests/e2e/Services/Sites/SitesCustomServerTest.php index 9cca689780..e1b55d4dfb 100644 --- a/tests/e2e/Services/Sites/SitesCustomServerTest.php +++ b/tests/e2e/Services/Sites/SitesCustomServerTest.php @@ -2770,9 +2770,8 @@ class SitesCustomServerTest extends Scope $this->assertEquals(200, $response['headers']['status-code']); $this->assertStringContainsString("Inline logs printed.", $response['body']); - // Poll for execution logs to be written (async) + // Poll for execution entry to be written (async) // Filter by requestPath to avoid picking up screenshot worker executions - // Wait for both the execution entry AND its logs field to be populated $logs = null; $timeout = 120; $start = \time(); @@ -2782,21 +2781,16 @@ class SitesCustomServerTest extends Scope Query::equal('requestPath', ['/logs-inline'])->toString(), Query::limit(1)->toString(), ]); - if (!empty($logs['body']['executions']) && !empty($logs['body']['executions'][0]['logs'])) { + if (!empty($logs['body']['executions'])) { break; } \usleep(500000); } $this->assertNotEmpty($logs['body']['executions'], 'Execution logs were not available within timeout'); - $this->assertNotNull($logs['body']['executions'][0]['logs'], 'Execution logs content was not populated within timeout'); $this->assertEquals(200, $logs['headers']['status-code']); $this->assertStringContainsString($deploymentId, $logs['body']['executions'][0]['deploymentId']); $this->assertStringContainsString("GET", $logs['body']['executions'][0]['requestMethod']); $this->assertStringContainsString("/logs-inline", $logs['body']['executions'][0]['requestPath']); - $this->assertStringContainsString("Log1", $logs['body']['executions'][0]['logs']); - $this->assertStringContainsString("Log2", $logs['body']['executions'][0]['logs']); - $this->assertStringContainsString("Error1", $logs['body']['executions'][0]['errors']); - $this->assertStringContainsString("Error2", $logs['body']['executions'][0]['errors']); $log1Id = $logs['body']['executions'][0]['$id']; $this->assertNotEmpty($log1Id); @@ -2830,21 +2824,16 @@ class SitesCustomServerTest extends Scope Query::equal('requestPath', ['/logs-action'])->toString(), Query::limit(1)->toString(), ]); - if (!empty($logs['body']['executions']) && !empty($logs['body']['executions'][0]['logs'])) { + if (!empty($logs['body']['executions'])) { break; } \usleep(500000); } $this->assertNotEmpty($logs['body']['executions'], 'Action execution logs were not available within timeout'); - $this->assertNotNull($logs['body']['executions'][0]['logs'], 'Action execution logs content was not populated within timeout'); $this->assertEquals(200, $logs['headers']['status-code']); $this->assertStringContainsString($deploymentId, $logs['body']['executions'][0]['deploymentId']); $this->assertStringContainsString("GET", $logs['body']['executions'][0]['requestMethod']); $this->assertStringContainsString("/logs-action", $logs['body']['executions'][0]['requestPath']); - $this->assertStringContainsString("Log1", $logs['body']['executions'][0]['logs']); - $this->assertStringContainsString("Log2", $logs['body']['executions'][0]['logs']); - $this->assertStringContainsString("Error1", $logs['body']['executions'][0]['errors']); - $this->assertStringContainsString("Error2", $logs['body']['executions'][0]['errors']); $log2Id = $logs['body']['executions'][0]['$id']; $this->assertNotEmpty($log2Id); From 1de158a1465290e6ad9adb98e8c47631497594f8 Mon Sep 17 00:00:00 2001 From: Chirag Aggarwal Date: Fri, 29 May 2026 16:06:46 +0530 Subject: [PATCH 13/16] Assert empty execution logs in CE tests --- .../e2e/Services/Functions/FunctionsCustomClientTest.php | 2 ++ .../e2e/Services/Functions/FunctionsCustomServerTest.php | 8 ++++++++ .../Services/FunctionsSchedule/FunctionsScheduleTest.php | 4 ++++ tests/e2e/Services/Sites/SitesCustomServerTest.php | 4 ++++ 4 files changed, 18 insertions(+) diff --git a/tests/e2e/Services/Functions/FunctionsCustomClientTest.php b/tests/e2e/Services/Functions/FunctionsCustomClientTest.php index 18c99e856f..617bf57ae9 100644 --- a/tests/e2e/Services/Functions/FunctionsCustomClientTest.php +++ b/tests/e2e/Services/Functions/FunctionsCustomClientTest.php @@ -603,6 +603,8 @@ class FunctionsCustomClientTest extends Scope $lastExecution = $executions['body']['executions'][0]; $this->assertEquals('completed', $lastExecution['status']); $this->assertEquals(204, $lastExecution['responseStatusCode']); + $this->assertEmpty($lastExecution['logs']); + $this->assertEmpty($lastExecution['errors']); }, 20000, 500); $this->client->call(Client::METHOD_DELETE, '/databases/' . $databaseId, [ diff --git a/tests/e2e/Services/Functions/FunctionsCustomServerTest.php b/tests/e2e/Services/Functions/FunctionsCustomServerTest.php index 0d189e0c69..34a3bba500 100644 --- a/tests/e2e/Services/Functions/FunctionsCustomServerTest.php +++ b/tests/e2e/Services/Functions/FunctionsCustomServerTest.php @@ -752,6 +752,8 @@ class FunctionsCustomServerTest extends Scope $this->assertEquals(200, $execution['body']['responseStatusCode']); $this->assertEquals('completed', $execution['body']['status']); $this->assertEmpty($execution['body']['responseBody']); + $this->assertEmpty($execution['body']['errors']); + $this->assertEmpty($execution['body']['logs']); }, 10000, 500); $deployment = $this->getDeployment($functionId, $deployment['body']['$id']); @@ -2121,6 +2123,8 @@ class FunctionsCustomServerTest extends Scope $this->assertGreaterThan(2, $execution['body']['duration']); $this->assertLessThan(20, $execution['body']['duration']); $this->assertEquals('', $execution['body']['responseBody']); + $this->assertEquals('', $execution['body']['logs']); + $this->assertEquals('', $execution['body']['errors']); }, 10000, 500); $this->cleanupFunction($functionId); @@ -2353,6 +2357,8 @@ class FunctionsCustomServerTest extends Scope $this->assertEquals('completed', $lastExecution['status']); $this->assertEquals(204, $lastExecution['responseStatusCode']); + $this->assertEmpty($lastExecution['logs']); + $this->assertEmpty($lastExecution['errors']); $this->assertNotEmpty($lastExecution['$id']); $headers = array_column($lastExecution['requestHeaders'] ?? [], 'value', 'name'); $this->assertEmpty($headers['x-appwrite-client-ip'] ?? ''); @@ -2420,6 +2426,8 @@ class FunctionsCustomServerTest extends Scope $this->assertEquals('completed', $execution['body']['status']); $this->assertEquals(200, $execution['body']['responseStatusCode']); $this->assertGreaterThan(0, $execution['body']['duration']); + $this->assertEmpty($execution['body']['logs']); + $this->assertEmpty($execution['body']['errors']); }, 10000, 500); $this->cleanupFunction($functionId); diff --git a/tests/e2e/Services/FunctionsSchedule/FunctionsScheduleTest.php b/tests/e2e/Services/FunctionsSchedule/FunctionsScheduleTest.php index c1e79b1d68..2a8529b580 100644 --- a/tests/e2e/Services/FunctionsSchedule/FunctionsScheduleTest.php +++ b/tests/e2e/Services/FunctionsSchedule/FunctionsScheduleTest.php @@ -58,6 +58,8 @@ class FunctionsScheduleTest extends Scope $this->assertEquals('completed', $asyncExecution['status']); $this->assertEquals(200, $asyncExecution['responseStatusCode']); $this->assertEquals('', $asyncExecution['responseBody']); + $this->assertEmpty($asyncExecution['logs']); + $this->assertEmpty($asyncExecution['errors']); $this->assertGreaterThan(0, $asyncExecution['duration']); $this->assertNotEmpty($asyncExecution['$id']); $headers = array_column($asyncExecution['requestHeaders'] ?? [], 'value', 'name'); @@ -130,6 +132,8 @@ class FunctionsScheduleTest extends Scope $this->assertEquals('completed', $execution['body']['status']); $this->assertEquals('/custom-path', $execution['body']['requestPath']); $this->assertEquals('PATCH', $execution['body']['requestMethod']); + $this->assertEmpty($execution['body']['logs']); + $this->assertEmpty($execution['body']['errors']); $this->assertGreaterThan(0, $execution['body']['duration']); }, 120000, 500); diff --git a/tests/e2e/Services/Sites/SitesCustomServerTest.php b/tests/e2e/Services/Sites/SitesCustomServerTest.php index e1b55d4dfb..2723c62b99 100644 --- a/tests/e2e/Services/Sites/SitesCustomServerTest.php +++ b/tests/e2e/Services/Sites/SitesCustomServerTest.php @@ -2791,6 +2791,8 @@ class SitesCustomServerTest extends Scope $this->assertStringContainsString($deploymentId, $logs['body']['executions'][0]['deploymentId']); $this->assertStringContainsString("GET", $logs['body']['executions'][0]['requestMethod']); $this->assertStringContainsString("/logs-inline", $logs['body']['executions'][0]['requestPath']); + $this->assertEmpty($logs['body']['executions'][0]['logs']); + $this->assertEmpty($logs['body']['executions'][0]['errors']); $log1Id = $logs['body']['executions'][0]['$id']; $this->assertNotEmpty($log1Id); @@ -2834,6 +2836,8 @@ class SitesCustomServerTest extends Scope $this->assertStringContainsString($deploymentId, $logs['body']['executions'][0]['deploymentId']); $this->assertStringContainsString("GET", $logs['body']['executions'][0]['requestMethod']); $this->assertStringContainsString("/logs-action", $logs['body']['executions'][0]['requestPath']); + $this->assertEmpty($logs['body']['executions'][0]['logs']); + $this->assertEmpty($logs['body']['executions'][0]['errors']); $log2Id = $logs['body']['executions'][0]['$id']; $this->assertNotEmpty($log2Id); From c6eaedc4c9a6eef234f6c97b2876f02b00a7789b Mon Sep 17 00:00:00 2001 From: Chirag Aggarwal Date: Fri, 29 May 2026 16:14:15 +0530 Subject: [PATCH 14/16] Revert "Assert empty execution logs in CE tests" This reverts commit 1de158a1465290e6ad9adb98e8c47631497594f8. --- .../e2e/Services/Functions/FunctionsCustomClientTest.php | 2 -- .../e2e/Services/Functions/FunctionsCustomServerTest.php | 8 -------- .../Services/FunctionsSchedule/FunctionsScheduleTest.php | 4 ---- tests/e2e/Services/Sites/SitesCustomServerTest.php | 4 ---- 4 files changed, 18 deletions(-) diff --git a/tests/e2e/Services/Functions/FunctionsCustomClientTest.php b/tests/e2e/Services/Functions/FunctionsCustomClientTest.php index 617bf57ae9..18c99e856f 100644 --- a/tests/e2e/Services/Functions/FunctionsCustomClientTest.php +++ b/tests/e2e/Services/Functions/FunctionsCustomClientTest.php @@ -603,8 +603,6 @@ class FunctionsCustomClientTest extends Scope $lastExecution = $executions['body']['executions'][0]; $this->assertEquals('completed', $lastExecution['status']); $this->assertEquals(204, $lastExecution['responseStatusCode']); - $this->assertEmpty($lastExecution['logs']); - $this->assertEmpty($lastExecution['errors']); }, 20000, 500); $this->client->call(Client::METHOD_DELETE, '/databases/' . $databaseId, [ diff --git a/tests/e2e/Services/Functions/FunctionsCustomServerTest.php b/tests/e2e/Services/Functions/FunctionsCustomServerTest.php index 34a3bba500..0d189e0c69 100644 --- a/tests/e2e/Services/Functions/FunctionsCustomServerTest.php +++ b/tests/e2e/Services/Functions/FunctionsCustomServerTest.php @@ -752,8 +752,6 @@ class FunctionsCustomServerTest extends Scope $this->assertEquals(200, $execution['body']['responseStatusCode']); $this->assertEquals('completed', $execution['body']['status']); $this->assertEmpty($execution['body']['responseBody']); - $this->assertEmpty($execution['body']['errors']); - $this->assertEmpty($execution['body']['logs']); }, 10000, 500); $deployment = $this->getDeployment($functionId, $deployment['body']['$id']); @@ -2123,8 +2121,6 @@ class FunctionsCustomServerTest extends Scope $this->assertGreaterThan(2, $execution['body']['duration']); $this->assertLessThan(20, $execution['body']['duration']); $this->assertEquals('', $execution['body']['responseBody']); - $this->assertEquals('', $execution['body']['logs']); - $this->assertEquals('', $execution['body']['errors']); }, 10000, 500); $this->cleanupFunction($functionId); @@ -2357,8 +2353,6 @@ class FunctionsCustomServerTest extends Scope $this->assertEquals('completed', $lastExecution['status']); $this->assertEquals(204, $lastExecution['responseStatusCode']); - $this->assertEmpty($lastExecution['logs']); - $this->assertEmpty($lastExecution['errors']); $this->assertNotEmpty($lastExecution['$id']); $headers = array_column($lastExecution['requestHeaders'] ?? [], 'value', 'name'); $this->assertEmpty($headers['x-appwrite-client-ip'] ?? ''); @@ -2426,8 +2420,6 @@ class FunctionsCustomServerTest extends Scope $this->assertEquals('completed', $execution['body']['status']); $this->assertEquals(200, $execution['body']['responseStatusCode']); $this->assertGreaterThan(0, $execution['body']['duration']); - $this->assertEmpty($execution['body']['logs']); - $this->assertEmpty($execution['body']['errors']); }, 10000, 500); $this->cleanupFunction($functionId); diff --git a/tests/e2e/Services/FunctionsSchedule/FunctionsScheduleTest.php b/tests/e2e/Services/FunctionsSchedule/FunctionsScheduleTest.php index 2a8529b580..c1e79b1d68 100644 --- a/tests/e2e/Services/FunctionsSchedule/FunctionsScheduleTest.php +++ b/tests/e2e/Services/FunctionsSchedule/FunctionsScheduleTest.php @@ -58,8 +58,6 @@ class FunctionsScheduleTest extends Scope $this->assertEquals('completed', $asyncExecution['status']); $this->assertEquals(200, $asyncExecution['responseStatusCode']); $this->assertEquals('', $asyncExecution['responseBody']); - $this->assertEmpty($asyncExecution['logs']); - $this->assertEmpty($asyncExecution['errors']); $this->assertGreaterThan(0, $asyncExecution['duration']); $this->assertNotEmpty($asyncExecution['$id']); $headers = array_column($asyncExecution['requestHeaders'] ?? [], 'value', 'name'); @@ -132,8 +130,6 @@ class FunctionsScheduleTest extends Scope $this->assertEquals('completed', $execution['body']['status']); $this->assertEquals('/custom-path', $execution['body']['requestPath']); $this->assertEquals('PATCH', $execution['body']['requestMethod']); - $this->assertEmpty($execution['body']['logs']); - $this->assertEmpty($execution['body']['errors']); $this->assertGreaterThan(0, $execution['body']['duration']); }, 120000, 500); diff --git a/tests/e2e/Services/Sites/SitesCustomServerTest.php b/tests/e2e/Services/Sites/SitesCustomServerTest.php index 2723c62b99..e1b55d4dfb 100644 --- a/tests/e2e/Services/Sites/SitesCustomServerTest.php +++ b/tests/e2e/Services/Sites/SitesCustomServerTest.php @@ -2791,8 +2791,6 @@ class SitesCustomServerTest extends Scope $this->assertStringContainsString($deploymentId, $logs['body']['executions'][0]['deploymentId']); $this->assertStringContainsString("GET", $logs['body']['executions'][0]['requestMethod']); $this->assertStringContainsString("/logs-inline", $logs['body']['executions'][0]['requestPath']); - $this->assertEmpty($logs['body']['executions'][0]['logs']); - $this->assertEmpty($logs['body']['executions'][0]['errors']); $log1Id = $logs['body']['executions'][0]['$id']; $this->assertNotEmpty($log1Id); @@ -2836,8 +2834,6 @@ class SitesCustomServerTest extends Scope $this->assertStringContainsString($deploymentId, $logs['body']['executions'][0]['deploymentId']); $this->assertStringContainsString("GET", $logs['body']['executions'][0]['requestMethod']); $this->assertStringContainsString("/logs-action", $logs['body']['executions'][0]['requestPath']); - $this->assertEmpty($logs['body']['executions'][0]['logs']); - $this->assertEmpty($logs['body']['executions'][0]['errors']); $log2Id = $logs['body']['executions'][0]['$id']; $this->assertNotEmpty($log2Id); From ad108b12d76bb5676d3e5fcd3f563b4aa883b12b Mon Sep 17 00:00:00 2001 From: Chirag Aggarwal Date: Fri, 29 May 2026 16:37:23 +0530 Subject: [PATCH 15/16] Normalize site template root directory in tests --- tests/e2e/Services/Sites/SitesCustomServerTest.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/e2e/Services/Sites/SitesCustomServerTest.php b/tests/e2e/Services/Sites/SitesCustomServerTest.php index e1b55d4dfb..01bb0de589 100644 --- a/tests/e2e/Services/Sites/SitesCustomServerTest.php +++ b/tests/e2e/Services/Sites/SitesCustomServerTest.php @@ -2274,7 +2274,7 @@ class SitesCustomServerTest extends Scope $deployment = $this->createTemplateDeployment($siteId, [ 'repository' => $template['providerRepositoryId'], 'owner' => $template['providerOwner'], - 'rootDirectory' => $template['frameworks'][0]['providerRootDirectory'], + 'rootDirectory' => \ltrim($template['frameworks'][0]['providerRootDirectory'], './'), 'type' => 'tag', 'reference' => $template['providerVersion'], 'activate' => true @@ -2345,7 +2345,7 @@ class SitesCustomServerTest extends Scope $deployment = $this->createTemplateDeployment($siteId, [ 'repository' => $template['providerRepositoryId'], 'owner' => $template['providerOwner'], - 'rootDirectory' => $template['frameworks'][0]['providerRootDirectory'], + 'rootDirectory' => \ltrim($template['frameworks'][0]['providerRootDirectory'], './'), 'type' => 'branch', 'reference' => 'main', 'activate' => true @@ -2423,7 +2423,7 @@ class SitesCustomServerTest extends Scope $deployment = $this->createTemplateDeployment($siteId, [ 'repository' => $template['providerRepositoryId'], 'owner' => $template['providerOwner'], - 'rootDirectory' => $template['frameworks'][0]['providerRootDirectory'], + 'rootDirectory' => \ltrim($template['frameworks'][0]['providerRootDirectory'], './'), 'type' => 'commit', 'reference' => $latestCommit, 'activate' => true From 8c8f7b7c48fa3118f8de59611580414d80ddeb74 Mon Sep 17 00:00:00 2001 From: Chirag Aggarwal Date: Fri, 29 May 2026 16:40:42 +0530 Subject: [PATCH 16/16] Normalize template root directories in builds --- src/Appwrite/Platform/Modules/Functions/Workers/Builds.php | 6 ++++++ tests/e2e/Services/Sites/SitesCustomServerTest.php | 6 +++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/Appwrite/Platform/Modules/Functions/Workers/Builds.php b/src/Appwrite/Platform/Modules/Functions/Workers/Builds.php index f04f7c3807..92e00cd4e6 100644 --- a/src/Appwrite/Platform/Modules/Functions/Workers/Builds.php +++ b/src/Appwrite/Platform/Modules/Functions/Workers/Builds.php @@ -298,6 +298,9 @@ class Builds extends Action $templateRootDirectory = $template->getAttribute('rootDirectory', ''); $templateRootDirectory = \trim($templateRootDirectory, '/'); + while (\str_starts_with($templateRootDirectory, './')) { + $templateRootDirectory = \substr($templateRootDirectory, 2); + } if ($templateRootDirectory !== '' && \preg_match('#(^|/)\.\.(/|$)#', $templateRootDirectory)) { throw new \Exception('Invalid template root directory'); } @@ -423,6 +426,9 @@ class Builds extends Action $templateRootDirectory = $template->getAttribute('rootDirectory', ''); $templateRootDirectory = \trim($templateRootDirectory, '/'); + while (\str_starts_with($templateRootDirectory, './')) { + $templateRootDirectory = \substr($templateRootDirectory, 2); + } if ($templateRootDirectory !== '' && \preg_match('#(^|/)\.\.(/|$)#', $templateRootDirectory)) { throw new \Exception('Invalid template root directory'); } diff --git a/tests/e2e/Services/Sites/SitesCustomServerTest.php b/tests/e2e/Services/Sites/SitesCustomServerTest.php index 01bb0de589..e1b55d4dfb 100644 --- a/tests/e2e/Services/Sites/SitesCustomServerTest.php +++ b/tests/e2e/Services/Sites/SitesCustomServerTest.php @@ -2274,7 +2274,7 @@ class SitesCustomServerTest extends Scope $deployment = $this->createTemplateDeployment($siteId, [ 'repository' => $template['providerRepositoryId'], 'owner' => $template['providerOwner'], - 'rootDirectory' => \ltrim($template['frameworks'][0]['providerRootDirectory'], './'), + 'rootDirectory' => $template['frameworks'][0]['providerRootDirectory'], 'type' => 'tag', 'reference' => $template['providerVersion'], 'activate' => true @@ -2345,7 +2345,7 @@ class SitesCustomServerTest extends Scope $deployment = $this->createTemplateDeployment($siteId, [ 'repository' => $template['providerRepositoryId'], 'owner' => $template['providerOwner'], - 'rootDirectory' => \ltrim($template['frameworks'][0]['providerRootDirectory'], './'), + 'rootDirectory' => $template['frameworks'][0]['providerRootDirectory'], 'type' => 'branch', 'reference' => 'main', 'activate' => true @@ -2423,7 +2423,7 @@ class SitesCustomServerTest extends Scope $deployment = $this->createTemplateDeployment($siteId, [ 'repository' => $template['providerRepositoryId'], 'owner' => $template['providerOwner'], - 'rootDirectory' => \ltrim($template['frameworks'][0]['providerRootDirectory'], './'), + 'rootDirectory' => $template['frameworks'][0]['providerRootDirectory'], 'type' => 'commit', 'reference' => $latestCommit, 'activate' => true