From 4bced29ec90bc2a311a05dc1cdd923f764dbc0fe Mon Sep 17 00:00:00 2001
From: Christy Jacob <christyjacob4@gmail.com>
Date: Tue, 9 Aug 2022 01:36:36 +0530
Subject: [PATCH] feat: review comments

---
 app/controllers/general.php | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/app/controllers/general.php b/app/controllers/general.php
index 5cdf0f4995..f8ccf2617b 100644
--- a/app/controllers/general.php
+++ b/app/controllers/general.php
@@ -305,21 +305,21 @@ App::init()
                 if (time() > $key->getAttribute('accessedAt', 0) + APP_KEY_USAGE) {
                     $key->setAttribute('accessedAt', time());
                     $sdkValidator = new WhiteList([
-                        'appwrite:nodejs',
-                        'appwrite:deno',
-                        'appwrite:php',
-                        'appwrite:python',
-                        'appwrite:ruby',
-                        'appwrite:go',
-                        'appwrite:java',
-                        'appwrite:dotnet',
-                        'appwrite:dart',
-                        'appwrite:kotlin',
-                        'appwrite:swift'
+                        'nodejs',
+                        'deno',
+                        'php',
+                        'python',
+                        'ruby',
+                        'go',
+                        'java',
+                        'dotnet',
+                        'dart',
+                        'kotlin',
+                        'swift'
                     ], true);
     
                     $sdk = $request->getHeader('x-sdk-version', 'UNKNOWN');
-                    $sdk = substr($sdk, 0, strrpos($sdk, ':'));
+                    $sdk = explode(':', $sdk)[1] ?? 'UNKNOWN';
 
                     if ($sdkValidator->isValid($sdk)) {
                         $sdks = $key->getAttribute('sdks', []);