From 45a3793cc07fa1172fefb562179fda86b30047ab Mon Sep 17 00:00:00 2001 From: Jake Barnby Date: Thu, 5 Feb 2026 01:48:36 +1300 Subject: [PATCH] fix: correct expected default values and attribute name in tests - Update expected default values to match the actual defaults (update tests are skipped, so original defaults apply) - Fix varchar_max -> varchar_min (varchar_max was never created) Co-Authored-By: Claude Opus 4.5 --- .../Databases/Legacy/DatabasesStringTypesTest.php | 10 +++++----- .../Databases/TablesDB/DatabasesStringTypesTest.php | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/tests/e2e/Services/Databases/Legacy/DatabasesStringTypesTest.php b/tests/e2e/Services/Databases/Legacy/DatabasesStringTypesTest.php index 7e9400c144..387cc13aeb 100644 --- a/tests/e2e/Services/Databases/Legacy/DatabasesStringTypesTest.php +++ b/tests/e2e/Services/Databases/Legacy/DatabasesStringTypesTest.php @@ -622,9 +622,9 @@ class DatabasesStringTypesTest extends Scope ]); $this->assertEquals(201, $document['headers']['status-code']); - // Check that default values are applied - $this->assertEquals('updated default', $document['body']['varchar_with_default']); - $this->assertEquals('Updated text default value', $document['body']['text_with_default']); + // Check that default values are applied (original defaults, update tests are skipped) + $this->assertEquals('hello world', $document['body']['varchar_with_default']); + $this->assertEquals('This is a longer default text value that can contain more content.', $document['body']['text_with_default']); } public function testCreateDocumentFailures(): void @@ -740,7 +740,7 @@ class DatabasesStringTypesTest extends Scope $collectionId = self::$collectionId; // Test SUCCESS: Delete varchar attribute - $deleteVarchar = $this->client->call(Client::METHOD_DELETE, '/databases/' . $databaseId . '/collections/' . $collectionId . '/attributes/varchar_max', [ + $deleteVarchar = $this->client->call(Client::METHOD_DELETE, '/databases/' . $databaseId . '/collections/' . $collectionId . '/attributes/varchar_min', [ 'content-type' => 'application/json', 'x-appwrite-project' => $this->getProject()['$id'], 'x-appwrite-key' => $this->getProject()['apiKey'] @@ -749,7 +749,7 @@ class DatabasesStringTypesTest extends Scope $this->assertEquals(204, $deleteVarchar['headers']['status-code']); // Verify deletion - $getDeleted = $this->client->call(Client::METHOD_GET, '/databases/' . $databaseId . '/collections/' . $collectionId . '/attributes/varchar_max', [ + $getDeleted = $this->client->call(Client::METHOD_GET, '/databases/' . $databaseId . '/collections/' . $collectionId . '/attributes/varchar_min', [ 'content-type' => 'application/json', 'x-appwrite-project' => $this->getProject()['$id'], 'x-appwrite-key' => $this->getProject()['apiKey'] diff --git a/tests/e2e/Services/Databases/TablesDB/DatabasesStringTypesTest.php b/tests/e2e/Services/Databases/TablesDB/DatabasesStringTypesTest.php index f3d50d7e79..7150c31e18 100644 --- a/tests/e2e/Services/Databases/TablesDB/DatabasesStringTypesTest.php +++ b/tests/e2e/Services/Databases/TablesDB/DatabasesStringTypesTest.php @@ -622,9 +622,9 @@ class DatabasesStringTypesTest extends Scope ]); $this->assertEquals(201, $row['headers']['status-code']); - // Check that default values are applied - $this->assertEquals('updated default', $row['body']['varchar_with_default']); - $this->assertEquals('Updated text default value', $row['body']['text_with_default']); + // Check that default values are applied (original defaults, update tests are skipped) + $this->assertEquals('hello world', $row['body']['varchar_with_default']); + $this->assertEquals('This is a longer default text value that can contain more content.', $row['body']['text_with_default']); } public function testCreateRowFailures(): void @@ -805,7 +805,7 @@ class DatabasesStringTypesTest extends Scope $tableId = self::$tableId; // Test SUCCESS: Delete varchar column - $deleteVarchar = $this->client->call(Client::METHOD_DELETE, '/tablesdb/' . $databaseId . '/tables/' . $tableId . '/columns/varchar_max', [ + $deleteVarchar = $this->client->call(Client::METHOD_DELETE, '/tablesdb/' . $databaseId . '/tables/' . $tableId . '/columns/varchar_min', [ 'content-type' => 'application/json', 'x-appwrite-project' => $this->getProject()['$id'], 'x-appwrite-key' => $this->getProject()['apiKey'] @@ -814,7 +814,7 @@ class DatabasesStringTypesTest extends Scope $this->assertEquals(204, $deleteVarchar['headers']['status-code']); // Verify deletion - $getDeleted = $this->client->call(Client::METHOD_GET, '/tablesdb/' . $databaseId . '/tables/' . $tableId . '/columns/varchar_max', [ + $getDeleted = $this->client->call(Client::METHOD_GET, '/tablesdb/' . $databaseId . '/tables/' . $tableId . '/columns/varchar_min', [ 'content-type' => 'application/json', 'x-appwrite-project' => $this->getProject()['$id'], 'x-appwrite-key' => $this->getProject()['apiKey']