From 2207fff44d85fa7fb2a6b35a363470ec982e668b Mon Sep 17 00:00:00 2001 From: Chirag Aggarwal Date: Fri, 8 May 2026 10:52:31 +0530 Subject: [PATCH] Wait for storage preview cache hit in e2e --- tests/e2e/Services/Storage/StorageBase.php | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/tests/e2e/Services/Storage/StorageBase.php b/tests/e2e/Services/Storage/StorageBase.php index 9177108ca6..5e09031a9c 100644 --- a/tests/e2e/Services/Storage/StorageBase.php +++ b/tests/e2e/Services/Storage/StorageBase.php @@ -1001,16 +1001,20 @@ trait StorageBase $this->assertEquals('miss', $preview['headers']['x-appwrite-cache']); $this->assertNotEmpty($preview['body']); - $cachedPreview = $this->client->call( - Client::METHOD_GET, - '/storage/buckets/' . $bucketId . '/files/' . $fileId . '/preview', - $headers, - $params - ); + $cachedPreview = []; + $this->assertEventually(function () use (&$cachedPreview, $bucketId, $fileId, $headers, $params) { + $cachedPreview = $this->client->call( + Client::METHOD_GET, + '/storage/buckets/' . $bucketId . '/files/' . $fileId . '/preview', + $headers, + $params + ); + + $this->assertEquals('hit', $cachedPreview['headers']['x-appwrite-cache']); + }); $this->assertEquals(200, $cachedPreview['headers']['status-code']); $this->assertEquals('image/png', $cachedPreview['headers']['content-type']); - $this->assertEquals('hit', $cachedPreview['headers']['x-appwrite-cache']); $this->assertStringStartsWith('private, max-age=', $cachedPreview['headers']['cache-control']); $this->assertEquals($preview['body'], $cachedPreview['body']); }