From 2179f904fe9847daf171aa6c304e863e8cd287da Mon Sep 17 00:00:00 2001 From: harsh mahajan Date: Tue, 15 Sep 2026 14:15:52 +0530 Subject: [PATCH] feat(response): restore project devKeys for response formats before 2.3.0 Add the V28 response filter, which returns an empty devKeys list on projects for older response formats, and fill devKeys in the generated SDK hydration test since the published PHP SDK still requires it. --- app/controllers/general.php | 4 +++ src/Appwrite/Utopia/Response/Filters/V28.php | 26 ++++++++++++++++++++ tests/unit/Utopia/ResponseTest.php | 1 + 3 files changed, 31 insertions(+) create mode 100644 src/Appwrite/Utopia/Response/Filters/V28.php diff --git a/app/controllers/general.php b/app/controllers/general.php index e0e36d3a87..4636cbb540 100644 --- a/app/controllers/general.php +++ b/app/controllers/general.php @@ -51,6 +51,7 @@ use Appwrite\Utopia\Response\Filters\V24 as ResponseV24; use Appwrite\Utopia\Response\Filters\V25 as ResponseV25; use Appwrite\Utopia\Response\Filters\V26 as ResponseV26; use Appwrite\Utopia\Response\Filters\V27 as ResponseV27; +use Appwrite\Utopia\Response\Filters\V28 as ResponseV28; use Appwrite\Utopia\View; use Executor\Exception\Timeout as ExecutorTimeout; use Executor\Executor; @@ -992,6 +993,9 @@ Http::init() */ $responseFormat = $request->getHeaderLine('x-appwrite-response-format', System::getEnv('_APP_SYSTEM_RESPONSE_FORMAT', '')); if ($responseFormat) { + if (version_compare($responseFormat, '2.3.0', '<')) { + $response->addFilter(new ResponseV28()); + } if (version_compare($responseFormat, '2.0.0', '<')) { $response->addFilter(new ResponseV27()); } diff --git a/src/Appwrite/Utopia/Response/Filters/V28.php b/src/Appwrite/Utopia/Response/Filters/V28.php new file mode 100644 index 0000000000..81f82577c0 --- /dev/null +++ b/src/Appwrite/Utopia/Response/Filters/V28.php @@ -0,0 +1,26 @@ + $this->parseProject($content), + Response::MODEL_PROJECT_LIST => $this->handleList($content, 'projects', fn ($item) => $this->parseProject($item)), + default => $content, + }; + } + + protected function parseProject(array $content): array + { + $content['devKeys'] = []; + + return $content; + } +} diff --git a/tests/unit/Utopia/ResponseTest.php b/tests/unit/Utopia/ResponseTest.php index 92ef21c0a2..717ffbfad7 100644 --- a/tests/unit/Utopia/ResponseTest.php +++ b/tests/unit/Utopia/ResponseTest.php @@ -128,6 +128,7 @@ final class ResponseTest extends TestCase ]), Response::MODEL_PROJECT); $project['wafEnabled'] = false; + $project['devKeys'] = []; $provider = $this->response->output(new Document([ 'credentials' => [],