From 1410101db80cd4219ccf5f2c6d42edbf46202570 Mon Sep 17 00:00:00 2001
From: kodumbeats <brandon.leckemby@gmail.com>
Date: Thu, 2 Sep 2021 17:38:46 -0400
Subject: [PATCH] Test index cleanup when attribute is deleted

---
 .../Database/DatabaseCustomServerTest.php     | 97 +++++++++++++++++++
 1 file changed, 97 insertions(+)

diff --git a/tests/e2e/Services/Database/DatabaseCustomServerTest.php b/tests/e2e/Services/Database/DatabaseCustomServerTest.php
index e5a75fa685..b642a57673 100644
--- a/tests/e2e/Services/Database/DatabaseCustomServerTest.php
+++ b/tests/e2e/Services/Database/DatabaseCustomServerTest.php
@@ -241,6 +241,103 @@ class DatabaseCustomServerTest extends Scope
     /**
      * @depends testDeleteIndex
      */
+    public function testDeleteIndexOnDeleteAttribute($data)
+    {
+        $attribute1 = $this->client->call(Client::METHOD_POST, '/database/collections/' . $data['collectionId'] . '/attributes/string', array_merge([
+            'content-type' => 'application/json',
+            'x-appwrite-project' => $this->getProject()['$id'],
+            'x-appwrite-key' => $this->getProject()['apiKey']
+        ]), [
+            'attributeId' => 'attribute1',
+            'size' => 16,
+            'required' => true,
+        ]);
+
+        $attribute2 = $this->client->call(Client::METHOD_POST, '/database/collections/' . $data['collectionId'] . '/attributes/string', array_merge([
+            'content-type' => 'application/json',
+            'x-appwrite-project' => $this->getProject()['$id'],
+            'x-appwrite-key' => $this->getProject()['apiKey']
+        ]), [
+            'attributeId' => 'attribute2',
+            'size' => 16,
+            'required' => true,
+        ]);
+
+        $this->assertEquals(201, $attribute1['headers']['status-code']);
+        $this->assertEquals(201, $attribute2['headers']['status-code']);
+        $this->assertEquals('attribute1', $attribute1['body']['key']);
+        $this->assertEquals('attribute2', $attribute2['body']['key']);
+
+        sleep(2);
+
+        $index1 = $this->client->call(Client::METHOD_POST, '/database/collections/' . $data['collectionId'] . '/indexes', array_merge([
+            'content-type' => 'application/json',
+            'x-appwrite-project' => $this->getProject()['$id'],
+            'x-appwrite-key' => $this->getProject()['apiKey']
+        ]), [
+            'indexId' => 'index1',
+            'type' => 'key',
+            'attributes' => ['attribute1', 'attribute2'],
+            'orders' => ['ASC', 'ASC'],
+        ]);
+
+        $index2 = $this->client->call(Client::METHOD_POST, '/database/collections/' . $data['collectionId'] . '/indexes', array_merge([
+            'content-type' => 'application/json',
+            'x-appwrite-project' => $this->getProject()['$id'],
+            'x-appwrite-key' => $this->getProject()['apiKey']
+        ]), [
+            'indexId' => 'index2',
+            'type' => 'key',
+            'attributes' => ['attribute2'],
+        ]);
+
+        $this->assertEquals(201, $index1['headers']['status-code']);
+        $this->assertEquals(201, $index2['headers']['status-code']);
+        $this->assertEquals('index1', $index1['body']['key']);
+        $this->assertEquals('index2', $index2['body']['key']);
+
+        sleep(2);
+
+        $deleted = $this->client->call(Client::METHOD_DELETE, '/database/collections/' . $data['collectionId'] . '/attributes/'. $attribute2['body']['key'], array_merge([
+            'content-type' => 'application/json',
+            'x-appwrite-project' => $this->getProject()['$id'],
+            'x-appwrite-key' => $this->getProject()['apiKey']
+        ]));
+
+        $this->assertEquals($deleted['headers']['status-code'], 204);
+
+        // wait for database worker to complete
+        sleep(2);
+
+        $collection = $this->client->call(Client::METHOD_GET, '/database/collections/' . $data['collectionId'], array_merge([
+            'content-type' => 'application/json',
+            'x-appwrite-project' => $this->getProject()['$id'],
+            'x-appwrite-key' => $this->getProject()['apiKey']
+        ]));
+
+        $this->assertEquals(200, $collection['headers']['status-code']);
+        $this->assertIsArray($collection['body']['indexes']);
+        $this->assertCount(1, $collection['body']['indexes']);
+        $this->assertEquals($index1['body']['key'], $collection['body']['indexes'][0]['key']);
+        $this->assertIsArray($collection['body']['indexes'][0]['attributes']);
+        $this->assertCount(1, $collection['body']['indexes'][0]['attributes']);
+        $this->assertEquals($attribute1['body']['key'], $collection['body']['indexes'][0]['attributes'][0]);
+
+        // Delete attribute
+        $deleted = $this->client->call(Client::METHOD_DELETE, '/database/collections/' . $data['collectionId'] . '/attributes/' . $attribute1['body']['key'], array_merge([
+            'content-type' => 'application/json',
+            'x-appwrite-project' => $this->getProject()['$id'],
+            'x-appwrite-key' => $this->getProject()['apiKey']
+        ]));
+
+        $this->assertEquals($deleted['headers']['status-code'], 204);
+
+        return $data;
+    }
+
+    /**
+     * @depends testDeleteIndexOnDeleteAttribute
+     */
     public function testDeleteCollection($data)
     {
         $collectionId = $data['collectionId'];