From 105e5fe71cd83b01114d026c0cbc864591ca02d1 Mon Sep 17 00:00:00 2001 From: Christy Jacob Date: Wed, 14 Sep 2022 01:44:56 +0530 Subject: [PATCH] feat: rename getMemberships to listMemberships --- CHANGES.md | 1 + app/controllers/api/teams.php | 6 +++--- .../teams/{get-team-members.md => list-team-members.md} | 0 3 files changed, 4 insertions(+), 3 deletions(-) rename docs/references/teams/{get-team-members.md => list-team-members.md} (100%) diff --git a/CHANGES.md b/CHANGES.md index d11186427b..9718116a0b 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -12,6 +12,7 @@ - `createExecution` parameter `async` default value was changed from `true` to `false` [#3781](https://github.com/appwrite/appwrite/pull/3781) - String attribute `status` has been refactored to a Boolean attribute `enabled` in the functions collection [#3798](https://github.com/appwrite/appwrite/pull/3798) - `time` attribute in Execution response model has been reanamed to `duration` to be more consistent with other response models. [#3801](https://github.com/appwrite/appwrite/pull/3801) +- Updated the `getMemberships` endpoint to `listMemberships` to stay stay consistent with other endpoints ## Features - Added the UI to see the Parent ID of all resources within the UI. [#3653](https://github.com/appwrite/appwrite/pull/3653) diff --git a/app/controllers/api/teams.php b/app/controllers/api/teams.php index ae819973a6..c975370223 100644 --- a/app/controllers/api/teams.php +++ b/app/controllers/api/teams.php @@ -463,13 +463,13 @@ App::post('/v1/teams/:teamId/memberships') }); App::get('/v1/teams/:teamId/memberships') - ->desc('Get Team Memberships') + ->desc('List Team Memberships') ->groups(['api', 'teams']) ->label('scope', 'teams.read') ->label('sdk.auth', [APP_AUTH_TYPE_SESSION, APP_AUTH_TYPE_KEY, APP_AUTH_TYPE_JWT]) ->label('sdk.namespace', 'teams') - ->label('sdk.method', 'getMemberships') - ->label('sdk.description', '/docs/references/teams/get-team-members.md') + ->label('sdk.method', 'listMemberships') + ->label('sdk.description', '/docs/references/teams/list-team-members.md') ->label('sdk.response.code', Response::STATUS_CODE_OK) ->label('sdk.response.type', Response::CONTENT_TYPE_JSON) ->label('sdk.response.model', Response::MODEL_MEMBERSHIP_LIST) diff --git a/docs/references/teams/get-team-members.md b/docs/references/teams/list-team-members.md similarity index 100% rename from docs/references/teams/get-team-members.md rename to docs/references/teams/list-team-members.md