From 0839822a66418316dada33cc45acb69fbc091cfd Mon Sep 17 00:00:00 2001 From: Christy Jacob Date: Sun, 30 Apr 2023 01:54:45 +0530 Subject: [PATCH] Apply suggestions from code review --- app/config/errors.php | 2 +- phpunit.xml | 2 +- tests/e2e/Services/Projects/ProjectsConsoleClientTest.php | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/config/errors.php b/app/config/errors.php index a27e77a58f..66352e9bf4 100644 --- a/app/config/errors.php +++ b/app/config/errors.php @@ -487,7 +487,7 @@ return [ Exception::PROJECT_ALREADY_EXISTS => [ 'name' => Exception::PROJECT_ALREADY_EXISTS, 'description' => 'Project with the requested ID already exists.', - 'code' => 403, + 'code' => 409, ], Exception::PROJECT_UNKNOWN => [ 'name' => Exception::PROJECT_UNKNOWN, diff --git a/phpunit.xml b/phpunit.xml index 4074fe0f1c..4012c8c276 100644 --- a/phpunit.xml +++ b/phpunit.xml @@ -6,7 +6,7 @@ convertNoticesToExceptions="true" convertWarningsToExceptions="true" processIsolation="false" - stopOnFailure="true" + stopOnFailure="false" > diff --git a/tests/e2e/Services/Projects/ProjectsConsoleClientTest.php b/tests/e2e/Services/Projects/ProjectsConsoleClientTest.php index 6380a81326..7254f88efe 100644 --- a/tests/e2e/Services/Projects/ProjectsConsoleClientTest.php +++ b/tests/e2e/Services/Projects/ProjectsConsoleClientTest.php @@ -126,8 +126,8 @@ class ProjectsConsoleClientTest extends Scope 'region' => 'default' ]); - $this->assertEquals(403, $response['headers']['status-code']); - $this->assertEquals(403, $response['body']['code']); + $this->assertEquals(409, $response['headers']['status-code']); + $this->assertEquals(409, $response['body']['code']); $this->assertEquals(Exception::PROJECT_ALREADY_EXISTS, $response['body']['type']); $this->assertEquals('Project with the requested ID already exists.', $response['body']['message']); }