From 02a09aa5e78dbf940ee6cf40d48ded15dbbb01bf Mon Sep 17 00:00:00 2001 From: Prem Palanisamy Date: Wed, 27 May 2026 15:01:41 +0100 Subject: [PATCH] Tighten secret project-variable assertion (Greptile P1) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit assertNotEquals('real-secret-value', $value) only rules out that exact string — a partial/corrupted leak (e.g. 'real-secret', 'REAL-SECRET-VALUE', hash) would still pass. The documented behavior is the destination stores '' because the source SDK strips secret values from list responses, so assertEmpty is the strictly tighter assertion. --- tests/e2e/Services/Migrations/MigrationsBase.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/e2e/Services/Migrations/MigrationsBase.php b/tests/e2e/Services/Migrations/MigrationsBase.php index d9181262fc..0c66cf8762 100644 --- a/tests/e2e/Services/Migrations/MigrationsBase.php +++ b/tests/e2e/Services/Migrations/MigrationsBase.php @@ -2707,7 +2707,7 @@ trait MigrationsBase $this->assertEquals($secretKey, $foundSecret['key']); // Secret variables: source SDK never returned the real value, so the destination // also stores empty. The original 'real-secret-value' must not have leaked. - $this->assertNotEquals('real-secret-value', $foundSecret['value']); + $this->assertEmpty($foundSecret['value']); $this->assertTrue($foundSecret['secret']); // Cleanup on destination